From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B995A328611 for ; Tue, 23 Jun 2026 03:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782185234; cv=none; b=KSeb1vZ+uUwT7vcQ1qWYQ0ut7wBem+LX+Qv2jX1nNMB+5lp0zLxy7xjQIfhUW6gMj5zY7JtAF11Pv4QGQTSBnsM8YwtMGpZqWLEUV+chpUriN0GYYQiDMyHvwt5tM3uzKc+V2kJjJGQA5cTTWK3FmpwrEbB7U2CcK7+b2lUGkqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782185234; c=relaxed/simple; bh=RmL2AmJ8mRRrPisH5tU2XfIlMF7SMHDlEPI7VSHI/rA=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=ci4x89eD6gKHzGHuGkDVKrtAhKp1M+2QiFySU2TzlW6vrTsUyRwqvGsr7L/fJRSe1gxixaBiAjP2M40qTwsUXRYBpm4+SVVrrHNnwjedrwOS+QZVkDm53QYDwPGFhno2zR+5xyjxLI0wOmXTvSRWXWJNoM9U+e4tr0KtE3kDjKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joannechien.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=whLWGwem; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joannechien.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="whLWGwem" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c88e0f04e51so3145441a12.0 for ; Mon, 22 Jun 2026 20:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782185232; x=1782790032; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=IVbGMEHq6fOsFJEOohLfitPVsUIbpddyCfsWs6SQcgs=; b=whLWGwemHCs6By0bVXzOqBmKQUHmEysvFYXGe4hOI4FPCwNI2RIgjDasG/U2p99ptP xkeyPZDB/naR46pl2XVDqrGAwsf8Cn4D4VMjlWv84zhcXfQZrH9yMKLlbDFwWpR5QqNT YVHnq4SBMOMC0YIps78QIM0VRjrv2vhgqKRAdSJvhRe86x/0wmbxdO1DSZQ7OnAomiM6 6R6eZrjeVpmOxVQOaKCkyaQ2FFY27TVaBlaKJej+fmjJFnccfy1SPUd6FHEMKwhFJ9k3 kyN23DDaCwEtBMLEwVhjesMryFc6OmZUKM8yX3k0u/aRoFPSuLKUKx7kkq7LQOg7Y4sr u0Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782185232; x=1782790032; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IVbGMEHq6fOsFJEOohLfitPVsUIbpddyCfsWs6SQcgs=; b=kZHzLjMCR605kGrkK6gC8xwFhDIm4baqsNU8DIyL8r61fo839FAuQs609tF54HGpFe rXPav5hzZXuJt1jEkxw1r0kMmmR/iMQ2Lblk5wAKISRb7hnQIdf9yEgHCV9o1gQbt1lk tSYXBWiLCseA7DVju0VT22ZhW0zkRB2nxZbaPI29P83EABYY0Rq8a+xWBbID+0n6Uvku xj1I41qvXmfgkm0kIu6IL7T2iqcqlE+Kcv/RqZYu2mVv4V8TgQd0pFbB8ohTvvUBxpnx MJeAvd1i2E1nHDqzxbL6gILPQ+RP5LrsNr4y7qHErE/Tm3zegrfUtj6MB0ltcG4uswzH 0bfw== X-Forwarded-Encrypted: i=1; AFNElJ+gQRqjZkl/8qlEnItZ6Aovt7fU8YB3LFaF38ntoBl115yNiVc7pmsk7FUrCm7WaTrTt7He3wo/WVlAxM8=@vger.kernel.org X-Gm-Message-State: AOJu0YzxgsPbb6FLB/w7N+ZSqTq/F2ecTP8Hc8gaOVjeVyToITQWfxgm /wAnZIScVshz1L7W+u5rqvI5kivAaW89rZw1VzWlOMKrgCU+lw7MFU4i0lRa6pl+eD/zDuEW/ov vfFsXJ66Q8uLGjvVdp+Jmbd/zqA== X-Received: from pgo1.prod.google.com ([2002:a63:e41:0:b0:c85:9c9a:ab4a]) (user=joannechien job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:438d:b0:3b7:d8d5:2340 with SMTP id adf61e73a8af0-3bb31dfaaeemr19667668637.11.1782185231754; Mon, 22 Jun 2026 20:27:11 -0700 (PDT) Date: Tue, 23 Jun 2026 03:27:01 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.rc0.786.g65d90a0328-goog Message-ID: <20260623032701.173516-1-joannechien@google.com> Subject: [PATCH v1] f2fs: dirty directory inodes on mtime/ctime update From: Joanne Chang To: Jaegeuk Kim , Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Joanne Chang Content-Type: text/plain; charset="UTF-8" Xfstests generic/547 sometimes fail with mismatched directory metadata before and after a power failure. This happens because when a directory entry is added, renamed, or deleted, its mtime and ctime are updated and the inode is marked dirty via f2fs_mark_inode_dirty_sync(dir, sync=false). The sync=false flag means the dirty inode is not added to the global DIRTY_META list. Therefore, subsequent checkpoints skip flushing these updated directory blocks, causing directory timestamps to revert to stale values after a sudden power failure. Address this by changing the dirtying parameter to sync=true during directory entry mutations and renames. This forces F2FS to immediately queue the updated directory blocks on the global DIRTY_META list, ensuring timestamps are committed to checkpoints. Signed-off-by: Joanne Chang --- fs/f2fs/dir.c | 6 +++--- fs/f2fs/inline.c | 2 +- fs/f2fs/namei.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index a9563f7fcd88..e1c42d2b5c15 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -460,7 +460,7 @@ void f2fs_set_link(struct inode *dir, struct f2fs_dir_entry *de, folio_mark_dirty(folio); inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); f2fs_folio_put(folio, true); } @@ -615,7 +615,7 @@ void f2fs_update_parent_metadata(struct inode *dir, struct inode *inode, clear_inode_flag(inode, FI_NEW_INODE); } inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); if (F2FS_I(dir)->i_current_depth != current_depth) f2fs_i_depth_write(dir, current_depth); @@ -927,7 +927,7 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentry, struct folio *folio, f2fs_folio_put(folio, true); inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); if (inode) f2fs_drop_nlink(dir, inode); diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index e2f7bedf1552..aec06fb4fd76 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -732,7 +732,7 @@ void f2fs_delete_inline_entry(struct f2fs_dir_entry *dentry, f2fs_folio_put(folio, true); inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); if (inode) f2fs_drop_nlink(dir, inode); diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index cac03b8e91a1..7ffdf23cea5e 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -1076,7 +1076,7 @@ static int f2fs_rename(struct mnt_idmap *idmap, struct inode *old_dir, f2fs_up_write(&F2FS_I(old_inode)->i_sem); inode_set_ctime_current(old_inode); - f2fs_mark_inode_dirty_sync(old_inode, false); + f2fs_mark_inode_dirty_sync(old_inode, true); f2fs_delete_entry(old_entry, old_folio, old_dir, NULL); old_folio = NULL; @@ -1246,7 +1246,7 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry, f2fs_i_links_write(old_dir, old_nlink > 0); f2fs_up_write(&F2FS_I(old_dir)->i_sem); } - f2fs_mark_inode_dirty_sync(old_dir, false); + f2fs_mark_inode_dirty_sync(old_dir, true); /* update directory entry info of new dir inode */ f2fs_set_link(new_dir, new_entry, new_folio, old_inode); @@ -1265,7 +1265,7 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry, f2fs_i_links_write(new_dir, new_nlink > 0); f2fs_up_write(&F2FS_I(new_dir)->i_sem); } - f2fs_mark_inode_dirty_sync(new_dir, false); + f2fs_mark_inode_dirty_sync(new_dir, true); if (F2FS_OPTION(sbi).fsync_mode == FSYNC_MODE_STRICT) { f2fs_add_ino_entry(sbi, old_dir->i_ino, TRANS_DIR_INO); -- 2.54.0.1189.g8c84645362-goog