From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B4B43C65E0 for ; Tue, 23 Jun 2026 07:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782199506; cv=none; b=eSQIAVFmGYFoKvoHxaBckUvMHgn5v9rcb6JyyKNw9IsDdGZpvBUG57uYOco693lyrrkC94KxlEGdjc3JQZqVHUYWk474lS4owDY+DsgmZev7ERNoJd6Cri3YoBwlfZhb1OdGgCcCpbqLZHWa5jphuCJUP7nhlz1UeRWpRczw+uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782199506; c=relaxed/simple; bh=Ti5Z20ExIs0K9WHF8/Xe9meA6hiiaxMXXpdKn+AHPjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=meZdV4gTyhSjddZSti8A4VZJsaIiamndSQafk6Yx81b6MRO2kM1bjpHKieQduxw7vSg2e9TwsIm075yKfUVFaczjbyMugId7PbBBTHpoQO/fQlLJWmjbrb3wVi9sh9uTvsCulkFUvuGkElEh+17JDN0fCsBRcuolyIQHDs8PMMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W45ABOqZ; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W45ABOqZ" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-4629051c946so453925f8f.1 for ; Tue, 23 Jun 2026 00:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782199504; x=1782804304; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cixHBYeYe02mLr64ZFg9yFOYVilxOSWazCrgIgCACI8=; b=W45ABOqZ/FIppzlzl6HO67+NssCBwraMUgTdge9Vn64rqodjPDq4QbVj/PA8ZUgNGl Yg8xOhmxf7w/sSDNz9Ed2zvRXh623vhGM/EQqLFkiYishdRLfGZ36olk0MYIuVBe5Wso 3piXL5eQ2/sorfmeAzCpcqsbUoI+np0HPI+P4MSa7Lwzn5qI3qYrhsbbkZl02CTeeh54 G2u04Nab4rKiVuwX0UtqjBEwvfmIegGn/DOifHbnleGgpGwXNtEOv2ivph1qGLA6O/Vz z7mfuL+tJ6JjSdVDLZ+G5uzPM18WcikmWo7t0DZVT4Pspzs8L+UiILOlhC2CBE0WxnQK XIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782199504; x=1782804304; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cixHBYeYe02mLr64ZFg9yFOYVilxOSWazCrgIgCACI8=; b=hRPal3ma2YCJb3qwhwFriP3e/R4i0I4Um5bY9l64ib0GUbsqTL1icLd2xblas5nyGM GU/KCxropum6wFPmerhCI2bBhvilIOHwrMMPyoijOtmApWNfrmxDVkQSg/AoXLzaZJ+h 3kmSLyRHuhiJkfw5NxKMOGXTnP7KYZ3VrjugrUVN7jK2Mca0Vqx5YTS6K/QnwHzZz2du b664kCWpeTDQjtKiwDeDFJjjEodSKXFOcHwKM0b5DyQBBKnYE+W0tqrQySbAJ6ymyp9G xPrErQ2hmup/ehaWlyzX3UZn/sAIbFJiIxtJRjJFRWCNVC97hUfK503P5Aj/jGFwzjvI Dm0Q== X-Forwarded-Encrypted: i=1; AHgh+Rpv+F3w7zwrvKQTBR94LVdO6zozrJ6TLP9Y0ebUl5ITUDnbxjHl4g4s5wBke336eakkP2xkJQqM7b5OpM8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3nNaSFTaKp2QhUbRZqWzEBmP/ynkaMj/j3DVEHy6/zpRR81bN 9ANDmS9g5tTZZpNZokKyHjHjKy3SKzWzL3d9ZkgTySvQRcgHVvc91Kkq X-Gm-Gg: AfdE7cmEbumBkcdw1OHYRthjqUD8PSRe2GI4LDlMOqSU5YWX38F0N06uajgdVdeeP3T Te4xMqcTq2IBY1IoHJUXoOSi490QOCTTKpYM0Ulf3lvu/zE29d65EO+ryvF7TS6Jkp5sA3uvdjN XwG2zHH1H1v5XZotGZY5ZZ/t5UiqRFbyaUv5cfgcO2b/5bQ6vHT0mAawefb+LQU3pdsp2b9MtSI k7z1TpVMYguNl3bXtFWZuIrd2Jit9lPNX0i6ONfOMg1mC+t4Vhg/ofpo8VQ/L+J6X2zJxIGMy7/ vZ0/smdpgnmHdV10Ln2dd3qZ0ZN8pF0wHLDz/JMFVbTIVaGTJnOQlTOLshDcG0pHsap5gyiq85O f3/w0cuSkL3tRCVb5cuxHmMyFoJBiR0O7ZQFTbQ/U5GlvxmEnAyovPozh9Vwl06KzgPKBu635w7 TJUiozNSHtt9H0JIA0MO7DI6EzTY4FtJr79fBW1zj80yg= X-Received: by 2002:a5d:5c84:0:b0:460:1378:7b0 with SMTP id ffacd0b85a97d-46a7e9f3dc7mr3809613f8f.5.1782199502728; Tue, 23 Jun 2026 00:25:02 -0700 (PDT) Received: from yocto.rz.uni-frankfurt.de ([141.2.113.173]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c57afasm34278743f8f.29.2026.06.23.00.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 00:25:02 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, john.g.garry@oracle.com, martin.petersen@oracle.com, abd.masalkhi@gmail.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, sashiko-bot Subject: [PATCH 1/7] md/raid10: fix r10bio leak in raid10_write_request() error paths Date: Tue, 23 Jun 2026 07:24:50 +0000 Message-ID: <20260623072456.333437-2-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260623072456.333437-1-abd.masalkhi@gmail.com> References: <20260623072456.333437-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When raid10_write_request() fails because REQ_NOWAIT is set, the allocated r10_bio is not freed before returning, resulting in a memory leak. Free r10_bio before returning from the REQ_NOWAIT error paths. Fixes: c9aa889b035f ("md: raid10 add nowait support") Reported-by: sashiko-bot Closes: https://lore.kernel.org/linux-raid/20260613184042.BCEC01F000E9@smtp.kernel.org/ Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/raid10.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 0a3cfdd3f5df..bd322eccdc3f 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1365,6 +1365,7 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, /* Bail out if REQ_NOWAIT is set for the bio */ if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); + free_r10bio(r10_bio); return false; } for (;;) { @@ -1398,6 +1399,7 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, if (bio->bi_opf & REQ_NOWAIT) { allow_barrier(conf); bio_wouldblock_error(bio); + free_r10bio(r10_bio); return false; } mddev_add_trace_msg(conf->mddev, -- 2.43.0