From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A943C9456 for ; Tue, 23 Jun 2026 07:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782199512; cv=none; b=k3fv6T50Tw4hYrpmfWyBtjnAMbLcWMtyI6gj/p6sYVLryKLfdTJlVI+LsKrmJtz7jnxuLrMBOzgcwoZI8eoryFm6Uza+LCP/5f5bEafoNcDDp2AQkqUHomdc1KiduWknz3O3gPHTaBn3BespDm9WEdn0xkQKMPaaVj4Pop+S6lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782199512; c=relaxed/simple; bh=vZhKRbTK19IGFJ42ixC/mDzsJd/XKY9fdrJd46AOGWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HGLGkl7iZzUI4zhaOMt1ZkMBgfoETf8ofkFt8JWKwsn83N2KgIypMnkrRHb2xcJcetCNT1U6myfqf8xJ0/4FNCsx4stUHNBI1/bwVUA7AoEF+5kqH9VmBcgjKIVFc1zV2vnEM5se7zd2Tnc21PSrxKrN7N1L4h8LQbJzHcpNR4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TNtRFoqN; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TNtRFoqN" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4626fdc829aso3669361f8f.3 for ; Tue, 23 Jun 2026 00:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782199510; x=1782804310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KY47xf/CQxrGCGwB8Qcv69Q2WQ+OmvTJyRKFMzDLFQA=; b=TNtRFoqNhtmGCu+cd2EkaNMwFbIH/1kovGVMHU8qUgvX+gmZFDfDGDFBpqalFxCOZZ plAi1epnPJ1qMzGBz861NHls2ADZTLYnu7t8R5mmEzYE79t3Ei1rPAaqtLrddROBI4mj YT08Guj0fhCBYYwkDa2qACP0xROPqqgjowjkNoUsit0xER46oh+ApzWAuBPpn0xqrzHW 2UCcmLv/hgklnSlh6/UdiDHpON5UOQquwGeLP9bfz3MToJGLSeWRUBFKtleR5z5Y/D0t RiGI/qjmBk1DtE5RHBWEdtt2dJWMd0xqob3DD8VaOxaM8fzeHLdQZ6MZH0v+4MNKck1H WUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782199510; x=1782804310; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KY47xf/CQxrGCGwB8Qcv69Q2WQ+OmvTJyRKFMzDLFQA=; b=Hk82sm9v8N8RbUAMt/Jdpza38StjQfXHtu/49IkuohozzTbX7bGnVCoSG5BnX/gDUW wYeak0m2tB9AhphG02Mdpyyh4b1sefGFsuX7ZOnMDsy4BOjk8+6SiAMOqXVvc6n858cb kV2ucNxzw2Aqi1YkxI68sbtWNrx48rfom9UtMRDpd++1S6Ce2N4CWesCLDvrEOv5Gcxv kVUl/SUfYUPUrna0Kqbw+jCim8Kc2T9xjU25RDjtKuiUCqHR6t3x3GjcTa94Qi3cYB6a HfbFDsViwFqqNUaB+KsF/Xyb2O8oi4bP4yK+EZOSaSLkY03hXsJqodrDnvy0qJe66jL6 fcVA== X-Forwarded-Encrypted: i=1; AHgh+RpghOQktzP5oCD+LlBOo1WmnTccCTI+p2VVS0rqzQEw4oVmpE5vanr9ZGq91yzVX3DShzh2CI6IUWUFHIw=@vger.kernel.org X-Gm-Message-State: AOJu0YxlW8vjUhGHDefQPMUe+6IXC54y6CCFWsfS7zQw+FrPpOEjSB8C hMMEWSfHGcS7Sayt0Enex7A1+fWvXpcBCaYzrHYKHtdDPdzOmsNIHCBX X-Gm-Gg: AfdE7cntwoP/C0+tTm+t5EcTvirjcSYQVuImsT9MQj0gVZ3dzRLR79V+Usgs0tNayK/ vTu7kdK6fvFR+J+UdcsMsQRhB7JMGgLM1Jo4SKRmAn/JFfwuve0FQeUysD/vz65VFS/W0tg7QvH ufJwlFOTk1g+vcbQb8AXsN9LrjOAJqwRK3RReJxMyrJwyygAVtDZtmpVntox8PY4qp4/yrB3bqh AsmriHQoR5HLioG1jmqCKyI+pz3hM8dh4t7LeA/5sq+O7NzWZN7/lGAv0LOtNdO12mIWfi1BKH7 04RvImu8zCCCEpKzuntYHEnHGwW3uFJcaBb5rrOGIcdk8U3VCWt+OGIjBvxyKjyeAlvybl5MdAI N/BhMphSxyszRrLr/05kTs+KObd+TMUWBFs5/yvcMOvG7QaqbPlYmJ3yZ4A4mg/5xEYEFyC8Ddk +W18iMP1ynciR3q0oUN6Lv8yHjuF34WHbW X-Received: by 2002:a05:6000:1cc7:b0:45e:8547:f21e with SMTP id ffacd0b85a97d-46adb39b74emr1278261f8f.36.1782199509785; Tue, 23 Jun 2026 00:25:09 -0700 (PDT) Received: from yocto.rz.uni-frankfurt.de ([141.2.113.173]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46666c57afasm34278743f8f.29.2026.06.23.00.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 00:25:09 -0700 (PDT) From: Abd-Alrhman Masalkhi To: song@kernel.org, yukuai@fygo.io, magiclinan@didiglobal.com, xiao@kernel.org, axboe@kernel.dk, john.g.garry@oracle.com, martin.petersen@oracle.com, abd.masalkhi@gmail.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] md/raid10: replace wait loop with wait_event_idle() Date: Tue, 23 Jun 2026 07:24:54 +0000 Message-ID: <20260623072456.333437-6-abd.masalkhi@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260623072456.333437-1-abd.masalkhi@gmail.com> References: <20260623072456.333437-1-abd.masalkhi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The wait loop is equivalent to wait_event_idle() and can be simplified by usaing it for improving readability. Signed-off-by: Abd-Alrhman Masalkhi --- drivers/md/raid10.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 4bc1d5553ec7..7085fd97b98a 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1368,22 +1368,17 @@ static bool raid10_write_request(struct mddev *mddev, struct bio *bio, mddev->cluster_ops->area_resyncing(mddev, WRITE, bio->bi_iter.bi_sector, bio_end_sector(bio)))) { - DEFINE_WAIT(w); /* Bail out if REQ_NOWAIT is set for the bio */ if (bio->bi_opf & REQ_NOWAIT) { bio_wouldblock_error(bio); free_r10bio(r10_bio); return false; } - for (;;) { - prepare_to_wait(&conf->wait_barrier, - &w, TASK_IDLE); - if (!mddev->cluster_ops->area_resyncing(mddev, WRITE, - bio->bi_iter.bi_sector, bio_end_sector(bio))) - break; - schedule(); - } - finish_wait(&conf->wait_barrier, &w); + + wait_event_idle(conf->wait_barrier, + !mddev->cluster_ops->area_resyncing(mddev, WRITE, + bio->bi_iter.bi_sector, + bio_end_sector(bio))); } sectors = r10_bio->sectors; -- 2.43.0