From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B8903603C3 for ; Tue, 23 Jun 2026 09:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207078; cv=none; b=rLRLWzB5Ebsai+bhubIX35zc4KmqfFA450TzzmRNOier4JnISuGkMSHErErEoT2ORnJSdB6+8IQ2WY0IUhegFB+kmomkCcvl5Ku9RuA+wv1+TvrFjL87iUW3QlqUDc+nuaS0sc/Nbn6PN3QRqOnmvzY5766S1Mk2hQkaBAdjMPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207078; c=relaxed/simple; bh=ioEL6a/MNP5hnz2FBcRKFQK4t3vMvou2digi3PAWQwo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sdHns+M2OoT1Po5y7Hu/QO7hkb17Qfwe2vgitUSBiRPTpvkSmlRjFXMbwzng4vU4TEZxUGbMXC3N5nMGKLsWtQouH4RCrw5R8Aeryth4J8QoqtT12pbtSwRmbbOfkWprjqZ/ymXJhtFyueN5uDZhsLoTvqVlOgYKVPlL61tnnag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d9oh37ht; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d9oh37ht" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2c6afcc99a5so3801825ad.0 for ; Tue, 23 Jun 2026 02:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782207077; x=1782811877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3h8QUd25AxJzBzM8TijEcxYosMBFZhDsa0PXbVO34Gk=; b=d9oh37ht18CaFDkD0bRERFgamlzsWW1EQyxj7xbsjdJEYONv8EXlHfoWyKWFIcq6lz LI0PVuxbVY2RT5hAUrsDL6N+1Fd4I0ZgCL/6irL6P8uthK+XRQCa6lE4hDyM1Ig7vdAk xNIk2yTOFAdwfNvE8coyP9IIzBI+vbbMMfHpGwpqkSGzChwcY3orPybQGm8jBGy/EzvL nQkb2PFb6imoJ6RBvlzBNgMU2zq3BW656YobUXeuvLouR4dMAkve6ZVja8p3sMWjWJ3D TvV5HsufnAcXTIIiEeq2VfDjJak+6dvARCL7kWHWLXrKlryg6gnq+i5gfFWKqe8t0sZ1 72CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782207077; x=1782811877; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3h8QUd25AxJzBzM8TijEcxYosMBFZhDsa0PXbVO34Gk=; b=D3Q0NwTWl6i/H5HU8G6027J/jth4Q7NsMMWiW2tDNs+9uDzXnzyWO7zoa9j96PUgMm pGM2i4W6GIqGfe2tKqRBP0zRplpLY2WV1ZF+NX7fIZf0+0SWjEDCtfC194OQtps+oa/v i5pepRatmP5aGXFSEtmOZoZQtyB/+pVMqFuNnyCyN6J4IRqk5itLUktEI3Hzew5AtdRI j3elgac55amZgEiMxlTAsOnch7r3YdGV8GPFAwmqX4N+a9nhn3vQeyYBSnw1iWlz/hKO 9npaiyitcsJjqHf4k3mllsXQGQk+ddAgNaVZTWb/EFfrGenMsJwb9BzTcrA+QprIP+8+ yzzw== X-Forwarded-Encrypted: i=1; AHgh+RrtAzY6EXAkENHyEOt+uTG45lnspMdYpSkHVTCHJa8D+H/pxHkumrBjihR3fBeaY3D4VYG7bNjlO8llCiE=@vger.kernel.org X-Gm-Message-State: AOJu0YzqovhF3ywjE4hicB76axVr0DJJANjSIpkgOlMJQWqSmQ8kBAaY qoMn5zgJZOpbrbbuSRLuXui0wTteHvNkeSWpoB46kyXARv2xxOVP9Vg= X-Gm-Gg: AfdE7cks+P/7kIiajwVZttZLfXsExPTm61IHnK994zuDKs2qabxd3hsvSdb8J4IrHx6 6WnGZ/opchtPJFkcEP81adlZxsWc3c00yhnjab6DcjSF7eCJDSTCKrpHq34kWSBA857spv4Kvyd 2JM42gXYBaDrbk6n0TOAyfWFFtSYjYAQ6/VgBhWGErJ5bsku16Q7+PlaxRDOT/UCbJWymJ+6ABE ou5MwJmA61l2dpLzTdDfL7NiYSTcq3QDGU0Q1QYUsnVC4IC1DScGtSL2K9BY3o0O22loE3qHXUY i+u30Jb0tsDhCj2E5GjQzlHlwQiUcQMk5gDLPD2TkSvBRYfIYaGTeB8iG++/MQ9cv8YHuFtmFPX vd3/n/ytGX2CfZI0xHXAUsiv6Nf9tjjk6cKNfEa+pePdUtV/IjbUbEZSP3rDntYTkFnVIHJnkya eW6uruQ7H47NZyN1Bea41bUQtHrn+ghp79MAwXvm12umj15prBfbXxbsPKcT9afikj X-Received: by 2002:a17:902:d547:b0:2c6:6425:b343 with SMTP id d9443c01a7336-2c7c3d6b276mr24713785ad.6.1782207076718; Tue, 23 Jun 2026 02:31:16 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7436d6c16sm104856865ad.23.2026.06.23.02.31.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 02:31:15 -0700 (PDT) From: Myeonghun Pak To: Alex Helms , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] clk: versaclock7: Fix APLL clock leak on probe failure Date: Tue, 23 Jun 2026 18:29:49 +0900 Message-ID: <20260623093110.78312-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vc7_probe() registers the APLL with clk_register_fixed_rate(), which is not devm-managed and must be explicitly unregistered on probe failure. Most later errors already unwind through err_clk, but a failure from vc7_get_bank_clk() in the output registration loop returned directly. That skipped clk_unregister_fixed_rate() and leaked the APLL clock. Route that error through the existing err_clk label so the fixed-rate clock is released consistently with the other probe failure paths. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 028ef9c96e96 ("Linux 7.0") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/clk/clk-versaclock7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-versaclock7.c b/drivers/clk/clk-versaclock7.c index adcc603e32..e3a36dcd98 100644 --- a/drivers/clk/clk-versaclock7.c +++ b/drivers/clk/clk-versaclock7.c @@ -1197,7 +1197,7 @@ static int vc7_probe(struct i2c_client *client) if (ret) { dev_err_probe(&client->dev, ret, "unable to register output %d\n", i); - return ret; + goto err_clk; } switch (bank_src_map.type) { -- 2.47.1