From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE1A364049 for ; Tue, 23 Jun 2026 09:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207631; cv=none; b=pR/nvsSiw5TW0n+vaDmGD2N3mLERHjnnTuNJGhKYJC8+Tk7TNbwTeuOGz4xvL/z/Qi8ohCLUzNuCGVmxv5j4QagXPOfTd/YyXrYiK5GiqsMR/kH6sc02HJ85wQvrhGrkTN5etC1HR3l5ppCqPgxmcrMocbh+EGXw1ejlEFw/JdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207631; c=relaxed/simple; bh=SnIDHBtDfjRngMeLKz6BX1PBRaDqF1HB0vtqyNU5yb8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=L0ZFpbCLpda3h4GfBBsIgMZdjHhwVS0ABXAQd3XPK1+Kh3YazrKmzUdxwC4PYV1xwayMOTMLvkb3roGWe4kNXXN8wd6nGX17sJVD6GLGTrZbtLndkN3Y0Oon8kPAmhDOhOhmUOpbvJmkFHzzFHHBNSNmTwIiKN8oDPELTlSjhs8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b3SqdXaG; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b3SqdXaG" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84237c55ef9so3207666b3a.0 for ; Tue, 23 Jun 2026 02:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782207630; x=1782812430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gnsa5FQ5jZSvFZuYEysM3sNVcO0NPhCred8y/3Y4jCM=; b=b3SqdXaGgFN2Mg/foq/iaUHjmZj4/NGBLRqQ3cKlGyKLlYoTwQC7rurWRHn7iSXi6n w+761bWwneSifDarKwYmPgUhHItb6wcYSd6KKAlXpeX8+eJU931bkxGxtCKfwkjtMG+8 hunAz1UxkyU/jd27ggYXmQ/2hdRU0T2zPmZ6oCQMVg3tN8uwFhmI0BFlRw9cnt0gFaTE bt+8SBybTJbvNEIubeKRPGgENXrEmX6Zq4q+7XHGh3089fNx7RmRY89KLWQWrg6tsEC/ jQZbwd+Ww4Skz8Br+xINz0o52NJ1DFLmutejim1BilHjKEcgkLTHPerDTsY2AKHRoXv3 Enww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782207630; x=1782812430; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gnsa5FQ5jZSvFZuYEysM3sNVcO0NPhCred8y/3Y4jCM=; b=AdJQOaI1vdYxTuqFD1tMuKdY0WxYJ9+aXZFg/+anSYlY3y1yWj0WEdLDAApilW5e6B zS1krLXgioAsub1GGE3Cf+nHRoSGN5tRTXWZPM3ZGJ7bnB1wNcGlJnOi8C/M0e8okoss vu19FcreS6CjJVDZ6hgPCPUBSVylfeVdZ7nCnpAVJyep6jLIk2JDZIVhC+C2rM32zwne SSXrx1cQH3SHUXUS/Jti5gGzpVWRsETZiR11336axsJwQ1AsvA7dBtyJQcW5GqAIk8SF NyVD2lphE6wp5DRTCI4LgsRGCRlGAWX2Jyp67KY8dmLv7WO85IYFZPbhoWTSiLqbRUiS i+nw== X-Forwarded-Encrypted: i=1; AFNElJ/Fqo7qetTdN0CpQxtvKx3QwtWhLwJP1E/wXDw38iB/sbLygnWvzHEDegOQfaqB6RySIvCEjzZKb82w9lc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyi8gRh75yaLIhtDFbUIhAyhgTue29uNhQEZEFoOG0Izgn5jlS9 6Z4NfH0OpVPAL4UuXmlKAeD5hdLlnKjX7ay9W+JH/TjHmzga89D9w1I= X-Gm-Gg: AfdE7cl8+VjuXG9tr6HRmds8iXfLa3df0C7D0Pe/hzKWCo6p0R6mo/ERwhs7kXpP70Y dE2/AIrMPKth0pH6/9IQJEKj1AL0GvNPboZRAyLaev1vRqg/z1LTlWF+lT+J+vFPkC9Q+9H6zGL oOlCJG39AdT6E1B0pJZYzxAl2FMlhGIEL+yZP3O792IHpyoWaiZ11+AhdcZ81UhcE4iG4FDLP8e zFBVM26/26dilUPl/+znWm8kRI4J23FFYK1sXwoyM7BW2Ne2Bdyf+Ed3fIG4MOGWREvBEKY82xc GiHCuZd9qOppz1qg39gRGxW2ksh8HHRxlu2VmbjfivReymEkJHr2OfLoQatbbERVB9euIzkFdJE d0Y5bQZH0hOhQEx2UKfYhafYqv39qu8DCK/tOAQhCNm+m9As8dbuwH+b20Pabz7QOXcHaPdM2LR rbIMGuFR1zAEEy//18s2oGKvnXf0jMDoKQfAK9T8kRa7PLRIUT104dfoPxxrUhuJAK X-Received: by 2002:a05:6a00:909d:b0:845:344f:ef1a with SMTP id d2e1a72fcca58-845952728a2mr2554331b3a.15.1782207629998; Tue, 23 Jun 2026 02:40:29 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564ebcf45sm9507635b3a.48.2026.06.23.02.40.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 02:40:29 -0700 (PDT) From: Myeonghun Pak To: Alex Helms , Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH v2] clk: versaclock7: Fix APLL clock leak on probe failure Date: Tue, 23 Jun 2026 18:40:18 +0900 Message-ID: <20260623094023.94231-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit vc7_probe() registers the APLL with clk_register_fixed_rate(), which is not devm-managed and must be explicitly unregistered on probe failure. Most later errors already unwind through err_clk, but a failure from vc7_get_bank_clk() in the output registration loop returned directly. That skipped clk_unregister_fixed_rate() and leaked the APLL clock. Route that error through the existing err_clk label so the fixed-rate clock is released consistently with the other probe failure paths. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 48c5e98fedd9 ("clk: Renesas versaclock7 ccf device driver") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- Changes in v2: - Correct the Fixes tag to reference the commit that introduced the VersaClock7 driver. drivers/clk/clk-versaclock7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-versaclock7.c b/drivers/clk/clk-versaclock7.c index adcc603e32..e3a36dcd98 100644 --- a/drivers/clk/clk-versaclock7.c +++ b/drivers/clk/clk-versaclock7.c @@ -1197,7 +1197,7 @@ static int vc7_probe(struct i2c_client *client) if (ret) { dev_err_probe(&client->dev, ret, "unable to register output %d\n", i); - return ret; + goto err_clk; } switch (bank_src_map.type) { -- 2.47.1