From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547033D4107 for ; Tue, 23 Jun 2026 11:25:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782213940; cv=none; b=RiqcuwGx8RPx2JvMIYDfaHDGnwlPQ2PRCOMmveLFYL7OuDdu4pnRo5Nwhd1dgkgaCVjeU9Q2Vt7mwbVZ4KfV4wj7gw87y0zqFZGKNH315hXoWFCEE2WjR7NJCEjod1I/KPwz5mHMTkW+buUr/lzh85GezaOU+cX7FhqsscBNKAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782213940; c=relaxed/simple; bh=5E6ao1mwvzTElxdrsxeoZAlZX2VKkXweTmp6NC9SHS4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=a9XvIXdJH9oB2MElv2+hOCFDenUwCjNubA18Epm+8Jy25M1ROeIYPUzvHVC3/Z3NosNvOHGT/U/fRJ+C5JM4oYvhyaC1t8VWnDlRlXcX8f2ddLRV5qsuLR1ociTCkcXu1fsJzwQ6wQvOwIPYgDjHMq9IU2cKR/amGvoTwRm1FUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RfQUf0Uu; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RfQUf0Uu" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2c6d31bfc8aso37071405ad.2 for ; Tue, 23 Jun 2026 04:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782213938; x=1782818738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=M29e8Ql7IjJywoNGR4bcqNAVaB1wcoGs5n53l5aPyvg=; b=RfQUf0Uu2QpKDutgjnMXFD6C1PVkMMW3MWpWcOqxVFg1Yqunelo+Jun5us3olB8LwM u/Ygzktqq4bfMf+coywzWPsi+y7gpHkZNPrpqTrz1Sd9nqnkCcXiEuVWjm778gcSKy6r QGsbQyc1fL5K7bLNQt1QHzbSjxI+jRImm2Gz8wo4sXigqIMt8Sn9DOCiPUy1wtPECHuy OIzY+rDZrBuApFvcQ4/ja+OlKveHC3cr5HdqhxmPT6H1JsgMvW9LoWEGECqZok7/kJwC E33vV9d8+nilMnbmHJqWndewi03Nzx4l9JWA7YfzLkXQQPef+0pchEXY1GjUb1faGY5x OYGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782213938; x=1782818738; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M29e8Ql7IjJywoNGR4bcqNAVaB1wcoGs5n53l5aPyvg=; b=nbdI7Gom8G+24UYmykU1JQAulMFIT68uGkvgkmYObVWE3LDBP+/zRe628c74CLC1LG BV5aVP608cKsQOXGKC4ZbHy6xGNxBDF8gF3BTRcuufeXlO6eFvTSav6qC2UT107L8cFn YZLkNnSwXukAqK5Ea4s+kp+9UiNNLxMD+S6HCr7Bu9m9leubb/0OZ3xs5RNSsFEa0BrP bNGQ/UY05/M4ZOWiDhgEv8QKbOuZXi5dJA7HBQ8BePOKUJ74y4xDUc36p+lVD/aibThL AGa6FJ9hr7zhs9s97yTcjmkpnh4/9FgqVhrzyExZn5fhdZPCHemu2wI7Sui3Omggssdh hysg== X-Forwarded-Encrypted: i=1; AHgh+RoOqTqLCXX82XfLRhAUqCe6lmD0pd5C9jNtDzbOpTPvrlYL5ZPRx5brK1KGrlsAoYRSl1ImwbnBRL2mXlg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4ysXgf9/cdRs7G8OYoz4/ntPppAYu4bgp0ZeKPzc1i/yJAox5 nQrfHV8rCVAOiVtNIQP7nfeAvbIvlj3CAljrWiB5A+ynVY+CVnMehEfX X-Gm-Gg: AfdE7cnxlceSFPQi2TlWb+Se8LsPDbQMNSRiVWrAuh/karAIGhyw0SaXU3JhXZGc8Xa KC6DvhrLj6kpwUvRlwqeWuG1FgEaXZUkbflGpOnHMlux0pdhgZEV2NHT93oKTD10j8XQbPiz057 QT3Av0U242xTPIs+wAxjBJIXoWVEykKm9pIgS75qGCpPMFsJYVMIRvp0kAqQwktBben7fYwnEdE fCDrnNiBmPSm0bcMEz1aLBcv687SXuMiGnjvQGONCbIbrU0u4bzPB+WnIU7ok+Oq/3yAl2kHm2l kQIxm7IkE3mbTdI4t+4f2nRr4KiX87YP6dSFgKHyIvyDYwDgCJ6IpMyPzgEFoixPMRGnOaNjOMT IJrQiYbIaHGQIJT/dJp/J+jnEqJuBwwRpzEx8UCgTpZQEYayI/8GXRLW0t3s8JPYzz/gqnoAeRW g/nLfswMHxZPdWmGyelPHa1Mq17ARJr9RYEwEQ7nA= X-Received: by 2002:a17:903:19cb:b0:2c6:b40a:d0c7 with SMTP id d9443c01a7336-2c7c99435b2mr19905315ad.7.1782213938504; Tue, 23 Jun 2026 04:25:38 -0700 (PDT) Received: from gmail.com (42-200-231-193.static.imsbiz.com. [42.200.231.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c743bfe8aasm100035825ad.68.2026.06.23.04.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 04:25:38 -0700 (PDT) From: Hanlin Song To: guoren@kernel.org Cc: linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, Hanlin Song Subject: [PATCH] csky: Fix ABIv2 memcmp() s1 alignment check Date: Tue, 23 Jun 2026 19:24:38 +0800 Message-Id: <20260623112438.33022-1-pgeorge8929@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit memcmp() saves the original s1 pointer in r3 and then clears r0 for the return value. The following alignment check tests r0 instead of r3: mov r3, r0 movi r0, 0 ... andi r13, r0, 3 As a result, the path for an unaligned s1 address is never taken, and memcmp() may issue word loads from an unaligned s1 address. Test r3 instead, which still holds the original s1 pointer. Signed-off-by: Hanlin Song --- arch/csky/abiv2/memcmp.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/csky/abiv2/memcmp.S b/arch/csky/abiv2/memcmp.S index bf0d809f0..1c6ced74d 100644 --- a/arch/csky/abiv2/memcmp.S +++ b/arch/csky/abiv2/memcmp.S @@ -12,7 +12,7 @@ ENTRY(memcmp) cmplti r2, 4 bt .L_compare_by_byte - andi r13, r0, 3 + andi r13, r3, 3 movi r19, 4 /* Test if s1 is not 4 bytes aligned. */ -- 2.25.1