From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF753D45CF for ; Tue, 23 Jun 2026 12:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782217266; cv=none; b=AQrmjqxF8gFoDpWC7hKbfHtkPOXplv79MkOfZ9t5htP+IJSz//b1C6Qubkzx2gKTpuK+YHz+5D+LRCQ8VlZj3D3pjnWNPOOeoiVcohlGSeswOojZei26q4LIqxYqBcYGf8LH/zYZbBKO1SDraw48aORjZul1EQ8jOIjphgToWPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782217266; c=relaxed/simple; bh=94jfzRBV157ACaB1PXeahfMYSo7DdtPYJEQZlADRXcA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Y6rtyEPgf5BY++sIfV7yqdJ9hmxIHK7znUHeDi3F9ryEUEmkQjTN7S1Y4KumDy7xQ/k96K0GmAvyAdZpKmdRPhUdf51GNS5vwFp9640hnEU0pfeSs7im46XRqHyJLIgMpMaCSKvlnl//7tAKbgrGgMZJbn8PBPQioGaM23CvQ8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F6m/yzxY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MNzgp2Ch; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F6m/yzxY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MNzgp2Ch" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXcKS1155240 for ; Tue, 23 Jun 2026 12:21:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1v/ynnXiKbGlgjlxO+YjIk/mxVwZxy5oog6I7VHwP2E=; b=F6m/yzxYQAhVEdPX K0AGg49/6psv5sZDCQlGnknWglUmWHw4CbQ8TXmzKKKbRvPyMOFsVWF6mrBBY6/d R3GonF9jFoa53XKMe660gYN8KfuT/Q50oltNwzBClRuQrZZkJKDl/EDOP1Cz52Jl GKD0RCTgkUgLxDwKKCYiT+A1+Y4qv6+IEbd9k+hPfsYOpNf0t9n7JjqJ0lvm+6cR M34lnTevTc3K6fjlfobSCtM81Mwz6IOCGe2gxPhy7WhENsCMmu+JnAOTLTCF8TKc Wyx1ctLGT38NrTmFPo0RsICNSQ6xrJ1v6IoRMwUe7fbjUmguEP+lax1sYf3btG0Q VnxXHw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr28rfpt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 12:21:04 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84531eaf8a8so8116639b3a.1 for ; Tue, 23 Jun 2026 05:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782217264; x=1782822064; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1v/ynnXiKbGlgjlxO+YjIk/mxVwZxy5oog6I7VHwP2E=; b=MNzgp2ChBOSfApf930MZZnJ0YzYVQQqr95nUS7dfqOUkh+WhcfOADm5xD9AmXHkc33 juowr/dh4/wv8qlkNKjlSi9xORdcWSAI5m5idk3utvqL9lT3X6DYYEXMWKs+YQYk+YST RMm+v4HWsIci0Gt/pfKPLWiqsxvXg+DSe6rgWTxhSHjbwvBUX5ldCCJ3XmNQnBpat+ZC JJVt/mDgwcJVDM8Esm0Ph/SAIXvJ1QTrLPZZeWcGSXvQ7HDJyw0BJadKgTbEH7Lj2JPT qor6McefX6I0qPPyAeqGpV+zwbt8QJ9/4rcvB7CuHB12fsuha067Jxz7QEFxAbTa8vGm 1PKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782217264; x=1782822064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1v/ynnXiKbGlgjlxO+YjIk/mxVwZxy5oog6I7VHwP2E=; b=hudxyIrxWgY9TzgXaY9WzlnAu6d+1dGwQP0E1XIPLvVsokEjhLT0I0x5S3pEy1Avyf lwOzQmnHejzsIukl5JPrJZjMPzeNKXiV1t7QI5yEPrsIgkXP2O4Jpkif1Lc60xPimh3H D4IB6yYVVgtsl/tld/SYhybi/HcNSdoPlXQUc7ExTmPHkT3Jsyz0AXNVW/zGTlWjRw7s l9a/CH8M11WRJMpbAPMeGwcSWbslE5CajVcjONUC44D93c/4cbgiI77eQk5qUbwUuBQh prNKFgYMy6JLq34jaXKObh9nhVIyiSZlqB9ItPHXxEYFfAY6ecKvokJnEpJgUS1bmude qGHA== X-Forwarded-Encrypted: i=1; AFNElJ/0yTXZxziLeG6Us3DzAZwEBk1C61Y0JRyEdXLjeSReV37efsuCCBSW/cuSscuiCdAVIt4POi7QG4szQm4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6uE747dfm0fFyOSnfyDqzLmck2c7F7T30fCe7iFO36jKLK9b9 sc7a641zDpFLCfQvfP7Jz2gwSBQzb6VqlYbHFDc8NkYVDQlw17xGS0HgfgCljRavtitffhW+6kV rahU4r627dG9XKVJwTavTFMQ0K+YmOzNws//+p3ciHIPHC2tiG/nqh4DDqq6j6rbjWj0= X-Gm-Gg: AfdE7cmBpSAhSDwX5dWtKqrFVphZGFlb7wWeYUzEeA86xT2+FyMnCNyOAifE7l/Pm4P iN/OuTJ/HNjHGuqkPNYgZJEEoPzPXEcPQIbhkorPNx1IKipgxhk4Pn+UexOvoq7SEfWo8hS/pVL ABCf4BDLVGdFSKuwnFA6aFbztEmZpfx6K9h2eG2lYi8Bw7Vh0kxArRQU89FZUbIvvlj0FZQ37Gf pbTp5jT9DY48fquGrrM/Fy2NJFsjfnLdFeulqdX4RQryQVqCB/KDYiFkvyTKZDQNZ0iHNmSiR9R kLqMI5EHJrFNstbqu+yje00UYPeltqc+1HyLFFpHbcniQG+w0ra/e14K+M13T06XEO4ja44a+6c fA33psyx2oo22nLF3BXSEiFk2Psu8kIy+wRtJmQ== X-Received: by 2002:a05:6a00:c8b:b0:842:5da3:9b8c with SMTP id d2e1a72fcca58-845970e08d1mr2741596b3a.36.1782217263412; Tue, 23 Jun 2026 05:21:03 -0700 (PDT) X-Received: by 2002:a05:6a00:c8b:b0:842:5da3:9b8c with SMTP id d2e1a72fcca58-845970e08d1mr2741555b3a.36.1782217262806; Tue, 23 Jun 2026 05:21:02 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564e74646sm10171856b3a.29.2026.06.23.05.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 05:21:02 -0700 (PDT) From: Mukesh Ojha To: Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH 1/8] iommu/qcom: Fix inverted fault report check in qcom_iommu_fault() Date: Tue, 23 Jun 2026 17:50:27 +0530 Message-ID: <20260623122034.1166295-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEwMSBTYWx0ZWRfX6NtTm/JbviUu XTLciAPAhY3gKR4XvzqU7iMJfTQO8wTPBXuQ28KBe8TP1kgQ3CDv+ecYeisZ9B9mAmot/9tzsLM iJ4zQCtPtaXupR1TikiUJ1iIrnlvLgk= X-Authority-Analysis: v=2.4 cv=b4KCJNGx c=1 sm=1 tr=0 ts=6a3a7a30 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=xmDQi4VeJV1Yj6r8B4kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: Y325KsKxIaa9XFrSjDVP7xnT9umbMdtF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEwMSBTYWx0ZWRfX90ImYLmBNb1+ PtXl//cHvQ6cRZb5hf/kgb6QABOmMEOsd+QypEPilZmeOpQCUCLe32wvyZ7Pfssemir76Sp7jBu N/9GRbXP/ZU+bZy8CzVxSXli2Fcnhy2rNJU4OVg/bmY5/MhNjvP2J825YiMoHZ+N210q5+zDlLT xzeNWaIv54OUzSxkXSTeztizapgkSlNq4So0EviY3dDKPRP7cbehT67Pa83q6gPRNnUYq0jaLRH qctkqUehWHVxPWp7nfE5g8b9k62FW3LPXBci/MBNJgu/NYptys1ZGHqwFP1AM0+LJZMS/mG1+4a tBS7NBmnJMdZvmK3sSuDjvCWP9IXAukbji1LIWVDiqyKAQgEEJROJSnH/wi/GJAghTk0mnqCsjR R+35p6gf9F4oasuZSdlFkJf0MjmMFAdAVAt1fl6QnQwgIhWL1mhUvsLaOqmyeeAUsyeCDD52CdU +1/DkIChVgZiM2yVhKA== X-Proofpoint-ORIG-GUID: Y325KsKxIaa9XFrSjDVP7xnT9umbMdtF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230101 report_iommu_fault() returns 0 when a fault handler successfully handles the fault, and -ENOSYS when no handler is installed. The condition '!report_iommu_fault()' evaluates to true (printing "Unhandled context fault") precisely when the fault *was* handled, and stays silent when no handler is present — the opposite of what is intended. Remove the '!' so the driver logs unhandled faults correctly. Signed-off-by: Mukesh Ojha --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 32efef69e72d..09f2ee6be988 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -200,7 +200,7 @@ static irqreturn_t qcom_iommu_fault(int irq, void *dev) fsynr = iommu_readl(ctx, ARM_SMMU_CB_FSYNR0); iova = iommu_readq(ctx, ARM_SMMU_CB_FAR); - if (!report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { + if (report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { dev_err_ratelimited(ctx->dev, "Unhandled context fault: fsr=0x%x, " "iova=0x%016llx, fsynr=0x%x, cb=%d\n", -- 2.53.0