From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A1523D5673 for ; Tue, 23 Jun 2026 12:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782217269; cv=none; b=SyL3GJJU+ckh9pTGNSId6VEkkCj1H96hhooh1MZpJm3nQ0uZ8fFUmYenQ9i8IXwbL62aD8CNO0bMAlqKrqaATzlHKg8rCHCTJmenYibzV/aYaevQpqB7QQpHqQ+kDKJA5r/auwt5/mOS/5WoYNW+X2nFy5/gpJJExRyCTJHMsaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782217269; c=relaxed/simple; bh=loQz1tJcYMIGFw11KS+gtAGNdvAMNzaMxWhHX4ioyWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ueZM/2H+5+Tqd89ft7OuS1Yk272xEpSGW7Gszm6yRu4FKZEMMrvRihjNGnMgVaygIy4tmiuIVM2DYIm0KnPlincbx+maqa3jfJdtEJkaZVdetNZBSmdfMSKIDAjTTlbbdyPfdSUJ/MCXKvWJTHjz4GYqp0aaHdr61fgTFlUHFOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EQTbTof3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZMA6CV5j; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EQTbTof3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZMA6CV5j" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXg7k3753493 for ; Tue, 23 Jun 2026 12:21:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=MfokqFYIIsc fSWuyK7hBpD3TjL2GPJaI85B2LM0b6Mg=; b=EQTbTof3FJoBbonQtk7mKD/la1P r9xxtDLeOePXM6R+o/pWuJkCB1CUiQIHKtd/LpabVN27DFNcrpCneq5IycM3U+4w j3J0N1Pv5ik1v0GY3rj0VvVDXxyzgrObgrlURkughRqd+6n2eX1+p8blA78w68++ Hry+AOfqPFgN1m6HRAloAAHLO19LM9e0Z0WQgpZumFZLdqyjyWahWWecPjXqOQSJ GdJupjb4SXNBG0eI8b7HszdRbbsh1VQP5ZT2gCcFEXnuNr03tsE6RRTFZ6Nu1GxL sbvlawWtv/BZr8tZxn4aOQUBqKDW0Oe/7y1M2znNn3cqZxmYhlvGON7CiiA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyp29h2w1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 12:21:07 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84540c1fff4so7954351b3a.1 for ; Tue, 23 Jun 2026 05:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782217267; x=1782822067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MfokqFYIIscfSWuyK7hBpD3TjL2GPJaI85B2LM0b6Mg=; b=ZMA6CV5jFDJd5wpZ5ep7E88fuxygEfLrlilIQf6S2moXx5rAZ6Ko4eT7ZmT4OYmlDX 1Q0XfUBLI7Y36WEiEmdOfJ1t3nMn4AbIOMn3urOQOVGI9TMRrqw1zAgrb2acaL693Uow TqxXcuMEbj0I2kz+gLkGhl+cMCpEQZl9BKgC0gLwq2YMLs+X3DcncG6qrTringfwrBDm Al6A8v4+53RpebXWYS8hbtbwBKFjloMsONMSdpiHysQHgPReAC+Su1LX0VWnLPIQ2HiW tzSO5ANfX7uqDqAtTLRnRkLxl2y1N7u9gNkeby7D90bTFqLXLTcmfLE23HcdE7JCjAsc ekeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782217267; x=1782822067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MfokqFYIIscfSWuyK7hBpD3TjL2GPJaI85B2LM0b6Mg=; b=YEUjUHCE5X3tHzcURfRJBL0/VwP15nAo6vthDREKz41jCUpTOTGajy0zQc3+br9xNQ IYu7bXqIFIxCf0LF/rqeSy2ma/XNnuts10+MsFOHq3xVGuKRs5yAuqlXRpmRbYVB/b0q La7VsPK/j9ej+/HOwF+DVOOwQZdqCILVkLuaDd7dvx0AM2exLcn/11eULrmnlxQUeXyb +PHqcCCddZkLefXfGMYxzCtI5K6XGAVYuCTHwRz0o1MxYUCZHOOWvR9BYZ6Ysrx8Wy+9 4UXcAIF45FJvCGm/MApg8eEWRYeXmhdmaxgZrrtp4XSoLznjrxduc7ju5CGkMlpVOOw4 di4Q== X-Forwarded-Encrypted: i=1; AFNElJ+QWRo6LXSmLWVU6Uzql56tDvi30LEZvXzUiMeXyJw+Lp2MDRG3PHNS/YFfjHZD76aiRJzItSB6ZpiAJf0=@vger.kernel.org X-Gm-Message-State: AOJu0YwobRRy3Z8ci5yHtX1P3eWMifoNNZB5eBRShMfp8FXS6ZS3X5WN MjwArlo0XU8HXNXrdAnQSvQlWySZvVd8iimny+AtbTtCqBPT9XV+PKig+nqc1vFHY38KrowDLHV W25uhYu/yjfaP9ng9dOAHbZzaK2T3f9We5LNUE6ldV+1Vv4R9byq/l8YTI6a6nckitn8= X-Gm-Gg: AfdE7cnm2NmHQEIntMo7uN5T4oR9vyl6IwjVOboWM2vtVlwAAF4vn1by3jItvxT7Tcq nEvp8spVllRDApW4KijdDyIgB7/8h387xKskS451lzM7XMAu9i1oK9CGQYEa/mEyxuk+IgJsB6z PHm3Pi02Jn53PShVWac/OVYi/YGWnv7Z2BtqCQWMng+2jllCPyAMwqHxSEqd2ZmtTHk9onPqPUW do9Fnyfm+P4EIX3+1Bbw2SmzdpItvVoIndebm4fTjC53wX1dstfQRLJE82NkIXMjXkpz06oVZQl 7dQdwPo4Mu4LrzX7YVIQmmVdF6dR+VzbcNIJ6XVDno14mhId1EFfyv+FqUOBlbEHYyYasiT2zcC fvVPSEl4MpJdMOgGk2EZdC3CgILnGM0ox4FWwjg== X-Received: by 2002:a05:6a00:2e22:b0:842:6c02:2fa4 with SMTP id d2e1a72fcca58-845952354fdmr3159957b3a.14.1782217266741; Tue, 23 Jun 2026 05:21:06 -0700 (PDT) X-Received: by 2002:a05:6a00:2e22:b0:842:6c02:2fa4 with SMTP id d2e1a72fcca58-845952354fdmr3159923b3a.14.1782217266179; Tue, 23 Jun 2026 05:21:06 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564e74646sm10171856b3a.29.2026.06.23.05.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 05:21:05 -0700 (PDT) From: Mukesh Ojha To: Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH 2/8] iommu/qcom: Fix missing pm_runtime_disable() in qcom_iommu_device_remove() Date: Tue, 23 Jun 2026 17:50:28 +0530 Message-ID: <20260623122034.1166295-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=LdAMLDfi c=1 sm=1 tr=0 ts=6a3a7a33 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=NButBYuML4y5tsQ1waEA:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: 708pP_CZas_7IVEqXv_Wn3oOnwMDT32l X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEwMSBTYWx0ZWRfX1Z3BZ7FgpMQG /IpjRU8FK8qpRx8ObLGDCGY6MtZFKlHUpBwdUb32Ql/O5z4+gInI2PYpHN/4Dy1mf2YHL4JaRA7 urxJU+5F/hnmbIjcNmWdDAfHMSPStfo= X-Proofpoint-ORIG-GUID: 708pP_CZas_7IVEqXv_Wn3oOnwMDT32l X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEwMSBTYWx0ZWRfX7RYNJBYub+HS uR3UPz+j8zrnr7cFuZ6TfsAd2aiVKh67AaoNyCsYVg7AoqUrKUhJsW6xwB2AXapHdcJu/qey2sb vO3srvH0QmRPRnA4ze0+RHl/d/2hipanRdP9zpvGPesdACX0lUGsYbW+6rugw4Do8K0Yco8dJWQ P8itOuFJ+UobHdtND3mjY1CJZ9Qnl+GNbnONm7Ie6ds2gVRYZJS7erWuOHkM45fZLWrc2VwKh3+ 5kp6zFrvuSLdu2UMB6sE4do2gXmVkTWduNRThja15IMbQCtlNV7KXfrt3gLrb72fxw50qX5kh6v 37xsPaKb0WZkYUK1B/l78FoEYacvsUbSi39jzoJO5tdEiRyNhTfdLrpjEsgHPk4hckm1cLrOyRC rZFBI9utmvs2t4OEdJzlxjnB/TZlR98NMY/mNBYofEpmqjijZ4b8XXLellcFHIVOUUZoOhBLVM7 J1s0neiRsNR+hZTR7ZQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230101 qcom_iommu_device_probe() calls pm_runtime_enable() but qcom_iommu_device_remove() only calls pm_runtime_force_suspend() without a matching pm_runtime_disable(). This leaves runtime PM enabled after the driver unbinds, which can cause issues on rebind or if any code races to resume the device after removal. Add pm_runtime_disable() in the remove path to balance the enable in probe. Signed-off-by: Mukesh Ojha --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 09f2ee6be988..cb43276f4a39 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -878,6 +878,7 @@ static void qcom_iommu_device_remove(struct platform_device *pdev) struct qcom_iommu_dev *qcom_iommu = platform_get_drvdata(pdev); pm_runtime_force_suspend(&pdev->dev); + pm_runtime_disable(&pdev->dev); platform_set_drvdata(pdev, NULL); iommu_device_sysfs_remove(&qcom_iommu->iommu); iommu_device_unregister(&qcom_iommu->iommu); -- 2.53.0