From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A70203D6463 for ; Tue, 23 Jun 2026 12:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782217282; cv=none; b=CZ8BH+lZuAnuBwYiSQgsOo/B3bFtUvcrxNBRR2sPqmgsDsiQzQ458uOG3noGL/r+XcbYI3yD7JosmQKQZ9S27oD6FG9dpxH8F8y2kJGWQ5oUob+G9ODcDSphMH/t+jtR9W97OKak7DWYqBY6SplL0GuDnE8Tm/BZeGQGw9nBveE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782217282; c=relaxed/simple; bh=0a6sGTnW/ivApoSTTdCDBkct/L9ipegiSq3EoaQIfLQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EJgULwvwEAaleE8LJJQVL4IKJ2elnKdy6Pxahuwq8BtJKbwF3GfqVm1aX2Ds4muAjp/1tgWpCjNrcZdcw5qmhEJnvE2nQSQ6A8bSFtd69hjFyFJ2zy+FC5c1T/iQBkGz4cHFtBRKUzFRbKVG42/VN97u0TINlFUPNXPjNywt4S8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hN+2ckoR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MhuYyVTs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hN+2ckoR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MhuYyVTs" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXbki1155214 for ; Tue, 23 Jun 2026 12:21:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=o9QcSJ5f45T 1iVf+TdgPgzAQzuE+vW43HSQ7Okp/gZ8=; b=hN+2ckoRJn2Kj2ng85HOhbwW+Nz N9o5FvUgYGk8RJSpx3jDan7nvRF2hkJ4cmM1q2B3X74EbQK4mL7teRb4lPVCYQV2 nm3iVtAirug4ZGRodY3fqPcuMWkt1QrKLdbhddPs4ApqdvbZ/bHEvyDyGTkepyay FMyWOQZtLMP2cnp/mvUEf9EPRO+kpmziENzl55970PvxtVwlN8kiIhQuI2wm/3Bw lwa9+ayuJXWvc12K7Lc/z8YM+tsFQ7fZ7s/GxV0t5JQCU9g4BGFWW+EZsPR54ggQ vcluBN4dKGwWq2CE5FSfEZywmB+LzK/wdaiDNvigU107RCAeL4kHjhJ9qnQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr28rfqv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 12:21:20 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8428419982eso5219025b3a.3 for ; Tue, 23 Jun 2026 05:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782217280; x=1782822080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o9QcSJ5f45T1iVf+TdgPgzAQzuE+vW43HSQ7Okp/gZ8=; b=MhuYyVTshg95Sx7qcU5hBzbHrHXYRh8jL+JC3uXmCslXOtPei0/Rn9CG9QGYnoSE1g r7eVmWGRnpmbq851NT7a3fSvbiw9VcVVM/b/jZyL/zGcEIYz12Rla7Bv5KV0jyCQi1YL q79EF1yd//3v3cNfacN9WRwxXtT2Ewn6Rd8XwH9ja/WSgs//Mwxqj1jQlFpW8n1AMhES LbF51P56dNjzXfSaF1fBJhcv9zPQPeofQgOCe8P6qK3uzUGrfUYB/LdSRTKe2IayRQ/K ZF0FYrhRDzmURDudo0hDj2K8gL+7MCd7NO965e2dzzUner6UUD5yHRIHWWlhHRDmfHJk 8ozA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782217280; x=1782822080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o9QcSJ5f45T1iVf+TdgPgzAQzuE+vW43HSQ7Okp/gZ8=; b=OhvWPNwBnVpiyPMZg1avM7E0nw0yg1WpnKfnT6DyYo+Jq5rhk5w1erXrcbA2RdWay9 Y/DdsQreeiYZKEFPsc0jLxqTfNngZjEgFBhGU063HLGL9o9c8jqtlfW0fP/bqRSxpXVK T0E9gg8ajn8VU64lVXo+T9eaF9BAX5MaHXMKch5HTBzeVwn7mCaCEkdo0GXbBXv7i4nD H+e5QizPRGbVmjcIQ5oVvMdjejjNLwJNyYBHU6XCb3AXp/Pvmd9z/eyEiQuFbPOiCJGe xq/Lk5dMC6OO7Y4AvdU1TmGyYPJ1qNMWEVKosH2j6t35jHS5NOR1db9Pvjy+XLg/HQps t9bQ== X-Forwarded-Encrypted: i=1; AFNElJ8Z72T+89Q7WG5eQiPssXUVRgOX+rKhzpHrCc/8jfAZUUgdk7rLTdeakLEoTBkqOkeI9EtaGA7QlSjfrM4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6lNWk/Y7RSBUJcoRAJL9CLDyYwUpMXC+Jbww1BBXzOEDaOutm ay9V6u99ZmCrRxnz9kviZQ82UlNz+Z+E4JdUuJOACRfwvCyZjBKI+i9bigyT1yXOMryt5jrZr8h gJzsTNbHuzg9RF49T2bKku9QrdAID0A/FpE6m8jt2fx42Ath4nAgZpf0m8PGA48ul+bM= X-Gm-Gg: AfdE7cnoOeWC00kXTnR9AZhzblqXbbfNxunhVDkjNI0vNkr3g/SFtK0dEud8Zv7a+2M omdSZKxcCTNSMtNHtyt1CeW3uaYFI9gcELdQ4OVIquUPc5q99Ah8oH4VDrsXAkxtF009PS8LoEM aWLndE8TWeBVGtipQn+7YMXoWIsvdhI83OfhgYI44DRip1xNd7HaEXy/8rrWdwYtJfOVKp2BIV3 O2HuX/5zLG+wpJYlCOBheGQLsn5oept5WcGecH/fR98JHcDGB8KmPUxMypwDHLODNh9dL0rDe3O bZ2gvvUQrOw92KEA8ltkt/25WNMVwW5SIFbaRvrRKH3YzKcxwuju4Guwo3G5aBNn7F2FrOoDjBf ME9EPaRFV0tuo0zi2y8Bee64uIWPFPHSuNQFgdw== X-Received: by 2002:a05:6a00:2e8f:b0:842:5634:3c1d with SMTP id d2e1a72fcca58-845970aff20mr2692023b3a.19.1782217280062; Tue, 23 Jun 2026 05:21:20 -0700 (PDT) X-Received: by 2002:a05:6a00:2e8f:b0:842:5634:3c1d with SMTP id d2e1a72fcca58-845970aff20mr2691983b3a.19.1782217279518; Tue, 23 Jun 2026 05:21:19 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564e74646sm10171856b3a.29.2026.06.23.05.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 05:21:19 -0700 (PDT) From: Mukesh Ojha To: Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mukesh Ojha Subject: [PATCH 6/8] iommu/qcom: Add NULL ctx check in TLB invalidation paths Date: Tue, 23 Jun 2026 17:50:32 +0530 Message-ID: <20260623122034.1166295-7-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEwMSBTYWx0ZWRfXzybpc938V/VN zoUUQz3nG/C56LbaPpH4e60C/+0UsiBUBDTAdWxSPSg1n7/ZSvix4Gdm/JiuBv0RVC+OvjdH/w7 81kzK48H/SXxc711uvkuVRK9RGcBXh8= X-Authority-Analysis: v=2.4 cv=b4KCJNGx c=1 sm=1 tr=0 ts=6a3a7a40 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=9AnWiAp10G-6W0uwed0A:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: lmbUPa83deZ7jdSCjicpKBMIGXnY1o-F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEwMSBTYWx0ZWRfX4X10tD7uoR9v 4+Dys6bj0mf3rxXY0QDNdCf+jE7OrMn8+JN9pgDId0w6nx6dtY79O3JCp9UjZX5aNOMQXOII+Ve Anm4aToWLjDmKeAjoas/hhim0pS0sxeNqZ4LDS9UL/K0NuFrZ6o5Ih2PPrX8GnuMDw4rzaF9KHw L4E8rKqrTRKnrzYFV2p7FuNSf9cM0febwRRVfJ2K1/+H3Ra+0O7LXfzyUzZZRPxWSxhXVvyrJfQ CMRleSTFm8sR1FlG4qNnwkQ7yEbYBITvhd+xnLrLPyzxXroqTG6AAO9IIHOpJLkhK28kUlGpYWG pstbij4i5F1NNsFrtNFxURzfqrrOWjRAsfLgg5wKXDEkUHHcK3OLb54Y+hPNIxMHR01usAxUboW icwM6L1oNEwzKp0Ns55pvmiP/WOc4MhW2A33FiHpUgoCIlb8l9EMJWz47I3SSTYaTgaB5u2T5sv W/rwDCHTub1sEYGlM6g== X-Proofpoint-ORIG-GUID: lmbUPa83deZ7jdSCjicpKBMIGXnY1o-F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230101 to_ctx() returns qcom_iommu->ctxs[asid], which can be NULL if the corresponding context bank failed to probe or was already removed. qcom_iommu_tlb_sync(), qcom_iommu_tlb_inv_context(), and qcom_iommu_tlb_inv_range_nosync() all dereference the returned pointer directly, risking a NULL pointer dereference. Add WARN_ON(!ctx) guards with continue so TLB operations skip broken context banks without crashing. Signed-off-by: Mukesh Ojha --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 40fb0408dc07..51b60b296bb8 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -121,6 +121,9 @@ static void qcom_iommu_tlb_sync(void *cookie) struct qcom_iommu_ctx *ctx = to_ctx(qcom_domain, fwspec->ids[i]); unsigned int val, ret; + if (WARN_ON(!ctx)) + continue; + iommu_writel(ctx, ARM_SMMU_CB_TLBSYNC, 0); ret = readl_poll_timeout(ctx->base + ARM_SMMU_CB_TLBSTATUS, val, @@ -138,6 +141,10 @@ static void qcom_iommu_tlb_inv_context(void *cookie) for (i = 0; i < fwspec->num_ids; i++) { struct qcom_iommu_ctx *ctx = to_ctx(qcom_domain, fwspec->ids[i]); + + if (WARN_ON(!ctx)) + continue; + iommu_writel(ctx, ARM_SMMU_CB_S1_TLBIASID, ctx->asid); } @@ -157,6 +164,9 @@ static void qcom_iommu_tlb_inv_range_nosync(unsigned long iova, size_t size, struct qcom_iommu_ctx *ctx = to_ctx(qcom_domain, fwspec->ids[i]); size_t s = size; + if (WARN_ON(!ctx)) + continue; + iova = (iova >> 12) << 12; iova |= ctx->asid; do { -- 2.53.0