From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFD2E3D5666 for ; Tue, 23 Jun 2026 12:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782218569; cv=none; b=mORTy6R6d/2IT83iuTafhDXBhHRcXob/ZkjKuDNxowbKGlOTaOAAGTiYrB0sy3dLUAey2l0qqNb5/tkROWq8v4iIZxqkYiPHCy0IMEGityLM+8jfw44QJchKPyGLCMh/sQbOeTaKK3GTG4kYv3EG1WuDkLexr+A2OOAy6HR674M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782218569; c=relaxed/simple; bh=sDJry3n4p/h3WsgZ61X8aEjtmt2RR1HpHy4XmVa+SIM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VxZN7iNVE3sCi8UTF2pKfHuanrkoeKOzLan39EZIQGR5/lq7JQcAMXEW6erqcrvug0vUSLE9RLK03BJv7X6lmJeRiovrlcqo5gbiptU+p5fJkZXOWrlC+801Cxko4OuIa5139YfvDR2vtrdDHmD0N4QcjEgpaXO9QOjUT/E+ebI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gc/58bA9; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gc/58bA9" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-490aaeabdb4so33072085e9.1 for ; Tue, 23 Jun 2026 05:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782218566; x=1782823366; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lI+Gx/YaJOSug/FAWLtqvkYw1/aKXn9WswwE0XjvIHk=; b=Gc/58bA9/1prbprogrgk9L/qyHFbiZxuqBUEsJyUeNCNs0XewzA950tTxB5Zz1Lif7 ktGr5yIcCvFQhVqxJCK2qdraYHyW5tv119dCuxYYszBIdRKez9nYIoup5GVXWbKLwLDZ 0wGDQ8SsDjEFYgzcocXWA0j5cjkW555wl3IAXGbpOrTcHzAflYEo7h5PrfbS7SKLYkPL y0ova8nDP//zoisDpB56KlEztbdd7AZwjeP5/QxgoMfh7nwuX/VJaWUxWoqYu7blb/Zj bo5nIHYJS+v280ni6QI9q4tUG6pNNxBKECY6SOMH16PlFm/har7fJoknOguT8EV74d3i 08Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782218566; x=1782823366; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lI+Gx/YaJOSug/FAWLtqvkYw1/aKXn9WswwE0XjvIHk=; b=Zqh0C4+00lKsK3TsD/IcXbjxgUVycJSkyfGpNFs8m3SRk2BXe6y5/MUWpr4blXJgmo ZiwFvIQCw/0WiMxDPqvxI6u60mylEv7YdPQ2l9/W+bXidcQbu8Wp3NYm1KnVjW/jx1lv RjpqAusOcSXlOtcfEOmKs5YXj6vCrzOeSa9nl1aQ5nzNbxmtv9WaOnz3Y7Bed6pB43EB 2+Y5ZAy2IN8DBY7OWD4EBsTK2b/BDLY3S3ylNh9LN/n76q29rBW7LWbAzi4HzQV2e82K jc8T9LGyssAhS6vTuyGC0TDqYX7B5AvYWNpWWQBBWLmigEZEIAW6430UIO85E+iu9B1J Lydg== X-Forwarded-Encrypted: i=1; AFNElJ9qLbOSQoZ2xEX1TVwLDvMLKpo1AFr1WHceiGYRbd2lXuMR51oIjyDBxj878MlhT76G1f1jBAFWpP8t8RQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzN5bbeIOPlvRkxpdfmjwcqYk7gXioR8p8asJQK1rTgmqpMlXP+ y/5N+Zk20A9/SeJZNzedxjMI8FJJ15pgaF8tQ7Soqn/77asIej6Njv66pDegIO47 X-Gm-Gg: AfdE7cnPRe2QlQQtz6SEkyLznL5xO4jszzDy+IKSEvsmSwRmczXTU6NiWJhfuoeSsY6 xiEK15SnSIdFvDkCJXj1aBY2hgE1gMnpnK0Ij/IqRxM5zrHlJdh4sCd0g562/IHQIRfUtSNnn6e iFgSVK9G2BcbuIECMz2dLG/6pljrLO86bEEB46DDVf3fteZCHR8BQP06M2Ggzq5NKl/hJ+QjYAC sxbedWdLwWzZ0MDPjV2auNC1xndcnIILoccJd81crL7nlTicokKiTlzLfo70iXIJEHufDBaxu6/ eleBsoXSFMWqZr7l9BDVYuOHmk/csdgLY5KBcDgl1PPnZ7z1kB6y2wrYMYQhZQZuy0DuHw8i0Pf /oxURbUlQ3dx1thQ9ROmmAmuXzn5GfgfK2hQD3+c4uNM7l+92l6z1Eqmrs0D3Bq784Kn4qZivAU Kayc2DDYjlgqV6rRWIR2yvrML5SWXC/9jfH11/vTv66EIxXxXEgZENcBpF X-Received: by 2002:a05:600d:640f:20b0:492:408b:d267 with SMTP id 5b1f17b1804b1-4925b394574mr29681745e9.13.1782218565934; Tue, 23 Jun 2026 05:42:45 -0700 (PDT) Received: from legion.localdomain ([31.223.63.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd30078sm373897765e9.7.2026.06.23.05.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 05:42:45 -0700 (PDT) From: Batu Ada Tutkun To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Batu Ada Tutkun Subject: [PATCH] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions Date: Tue, 23 Jun 2026 15:42:43 +0300 Message-ID: <20260623124243.1245-1-batuadatutkun@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of dev_err() followed by return PTR_ERR() when devm_clk_get() fails. fsl_mx6_enable() in the same file was already converted to use dev_err_probe() by a previous cleanup series. Convert the remaining two functions for consistency. devm_clk_get() can return -EPROBE_DEFER, so dev_err_probe() is appropriate here: it suppresses the log message at error level when the failure is a deferred probe, avoiding misleading output during normal boot. Signed-off-by: Batu Ada Tutkun --- drivers/staging/most/dim2/dim2.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 7953d4626..56f856d6d 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -974,10 +974,9 @@ static int rcar_gen2_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { @@ -1019,10 +1018,9 @@ static int rcar_gen3_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { -- 2.53.0