From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 052E93451C8 for ; Tue, 23 Jun 2026 19:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782242553; cv=none; b=jiofRVuu6s3fCqt8lN4PHew8iw1337h6ng+565mG5kZe/3+29UbmibGh75rt3ltwmmrPthsX0Ufg9SgRJ8gq6de9YGly2hsYMiqQ86YsbhDACUN9M90b4nyoWxVb7sOsohud91JGj56MhqokfzN45EGoornYGSIp1t4WTz+f3eM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782242553; c=relaxed/simple; bh=gjgrsDd/ebzWh6tkakuHrLUHkTjwUYhdEmKlxZWsS1E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SXZX11yyFa8mNYH7bBNGM5+dqba0lO7zLF2snaU8n/lXwnOqSA/G2ZGmGt7qEAX6xMfq1iUxfKaG3Z8EDvR7LRnNX7iqFNy+LHtSD7rOR2PrTdmMBmhMSzWeNSX2aslWqQwU0CICuyyuWRb2cCbubpsroo8QH0ALTpI840FR+3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EqtwPlXP; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EqtwPlXP" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490cf3000f0so2211825e9.1 for ; Tue, 23 Jun 2026 12:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782242550; x=1782847350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9qRZ8hq7NweVMrKwvoIG6kF3ia46DL3ufdBurnwbak0=; b=EqtwPlXPZKtr5HCE+LS7ehOYqgFfuQmx68ZTv0iWX00f/f9sCPjj7oKEGSNnA/ZlNT zOGCjFC/Q2TKB8GC2tlYMKEii1LaAI7v048PrtSLC3pgzYsk82kh5//rj9PkYN1To8BT KsSJLTVOs019MPmgGkhlsdSRj6Ftva+x04VpH9pHZ375umR9z3yEYtcG213mrABKXhJg xn20p4ikZgerZPV1dz/ZjuGgXTKKziscB34OxZm9XJ/WO9MbSD4OZaabkE3pBW5o0QbV 3JYlcmzAZtdzthd/3LeDfkLczhkKy7rATRVVV1eWKvCLiOJKXkXIj+bFCs73o9zV6Xgl YTog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782242550; x=1782847350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9qRZ8hq7NweVMrKwvoIG6kF3ia46DL3ufdBurnwbak0=; b=S1tw13jfiC4lamt1P4vbYZeKXOCfuCu8BC+vDb3QqMnQ5fN2GDYI3dI+dDdsyyiJYR BmP/Vxk9ptS0ElYY7CfaJne79yhW0cR/MvxRF+7we1AO9annaBVXhb4FjDqWd3h46UiS p7VON3mJHvb5FJf8MShlaACs1iJ539TU4xBsBO5ybymYPTaRN6VzasB4bXDxMzxx84iY jSgaLiNtBUujM/swc5pnNybP5mDleT1aCGWPTP1C8Mxu+FcPBgioxfEpUbE2fS0shHHc xz3WGIMHGz0Fs/AnVIQeq1230iAw2FBKK7a/dOvV18aqOzqTpO3FWz5VAj8E4lR/tRNF qDQw== X-Forwarded-Encrypted: i=1; AFNElJ/oZdr4IBYyroW7gT2xczPvuc0b6lXiiFxwuY3zWsIenNPQyGxX5ifrpN0hx0/1ktd34uzeEoZw5vMcQMs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9EIp/NkazazryU/0WsaDOc0P5FRFrxSDEOLX1kDxnvLbIna90 u5W3F51q6/84k+tFBeTAl5auw96Gj6OO7SeYql/OqInQMRdgkWnCg+x4 X-Gm-Gg: AfdE7cmVPZVZCpWfX3O0MKgrgpS34f8E2xW1IVomgjT3UlQ/zSD7hnWXUYSnl//actx GbOYSBEWYBNB8k3DPDF1b9CZA1JkqMA/wVMmQIy0Grwfut0oG6wnZAUrwxU/p+skFAYyn/ee1Cv n6GIg81zH60HQoTtWtolWwoM297CfYsdLwmwzTa/RNBqjW8XYiPVGBQ6FRanlq5gZSwu5vwybqs /9LTMZgc2ZQTZl5c0WJHhXctg7xQ20ramgZLtoUfG+VJJEv5uAPBMSZNulVULtCVvaT6yLZFFvh QUQEE0dlxeHfNhn4GP0D0F88CGbTvenzlxC/Hv1w4j3uqDDkJEQ+n4DcMYxOHM0X02CeB0cB1Zi sUHzdBzuDVfBBq09/sFg2HBIhRKi33fsSsYHq0jNhyPdT9Mjzjqd5vTBPTnMIroi5sFvJByrpo+ pB4uf6lHMG6OyGn/sly8XnzqJntYVZBRT9tW5QK2pC2+hplcw8CRckXMyNMgIIeGrLYiQEM832 X-Received: by 2002:a05:600c:6812:b0:490:5466:8591 with SMTP id 5b1f17b1804b1-4925b353633mr62488105e9.12.1782242550328; Tue, 23 Jun 2026 12:22:30 -0700 (PDT) Received: from flaviu-Aspire-E5-572G.. ([5.15.86.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49249238bfbsm335967985e9.5.2026.06.23.12.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 12:22:29 -0700 (PDT) From: Flaviu Nistor To: Guenter Roeck Cc: Javier Carrasco , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Flaviu Nistor , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re:[PATCH 1/2] dt-bindings: hwmon: chipcap2: Add label property Date: Tue, 23 Jun 2026 22:22:17 +0300 Message-ID: <20260623192217.4804-1-flaviu.nistor@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On 6/23/26 9:58 PM CET, Guenter Roeck wrote: >On 6/23/26 11:16, Flaviu Nistor wrote: >> On Mon Jun 22, 2026 at 7:29 PM CEST, Javier Carrasco wrote: >>> On Mon Jun 22, 2026 at 2:21 PM CEST, Flaviu Nistor wrote: >>>> Add support for an optional label property similar to other hwmon devices >>>> This allows, in case of boards with multiple CHIPCAP2 sensors, to assign >>>> distinct names to each instance. >>>> >>>> Signed-off-by: Flaviu Nistor >>>> --- >>>> .../devicetree/bindings/hwmon/amphenol,chipcap2.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.ya= >>> ml b/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.yaml >>>> index 17351fdbefce..f00b5a4b14dd 100644 >>>> --- a/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.yaml >>>> +++ b/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.yaml >>>> @@ -33,6 +33,10 @@ properties: >>>> reg: >>>> maxItems: 1 >>>> >>>> + label: >>>> + description: >>>> + A descriptive name for this channel, like "ambient" or "psu". >>>> + >>>> interrupts: >>>> items: >>>> - description: measurement ready indicator >>>> @@ -72,6 +76,7 @@ examples: >>>> <5 IRQ_TYPE_EDGE_RISING>, >>>> <6 IRQ_TYPE_EDGE_RISING>; >>>> interrupt-names =3D "ready", "low", "high"; >>>> + label =3D "somelabel"; >>>> vdd-supply =3D <®_vdd>; >>>> }; >>> }; >>> >>> Hello Falviu, thank you for your patch. >>> >> >> Hello Javier, thanks for your reply. >> >>> Should we not add a reference to hwmon-common.yaml (with >>> unevelautedProperties instead of additionalProperties), as label is >>> defined there? I believe that Krzysztof Kozlowski did something similar >>> for the shunt-resistor-micro-ohms property. Could we follow suit here? >>> >> >> This is a good question and I am happy you asked. I also thought a lot >> about this and the reason I decided to go for this approach is that by using >> $ref: hwmon-common.yaml#, I would have to change additionalProperties: false >> to unevaluatedProperties: false, which will evaluate in case it is used, also >> shunt-resistor-micro-ohms property which does not apply to this sensor. At >> least this is my understanding, but of course I can be wrong (I see lm75 binding >> also uses $ref: hwmon-common.yaml# but shunt-resistor-micro-ohms does not apply). >> > >Where does the idea come from that shunt-resistor-micro-ohms would be mandatory ? >That would make hwmon-common.yaml unusable for most chips. I think this is a misunderstanding since I never had the intention to imply that shunt-resistor-micro-ohms would be mandatory, but rather I observed that if I used $ref: hwmon-common.yaml#, property shunt-resistor-micro-ohms can be added (no need to, but still possible) in the example section and the dt_binding_check will pass. Since hwmon-common.yaml is already there I will change the binding in a v2 and use it. Best regards, Flaviu