From: Jason Andryuk <jason.andryuk@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Penny Zheng <penny.zheng@amd.com>,
Jason Andryuk <jason.andryuk@amd.com>, <stable@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: Avoid divide by 0 in amd_smn_init()
Date: Tue, 23 Jun 2026 17:19:03 -0400 [thread overview]
Message-ID: <20260623211904.3674-1-jason.andryuk@amd.com> (raw)
Xen synthesizes the CPU topology, so the num_nodes and num_roots values
may be surprising for amd_smn_init(). Specifically:
roots_per_node = num_roots / num_nodes;
may results in roots_per_node == 0 which leads to divide by zero in
count % roots_per_node
As an example, I have a system with a Xen PVH dom0 that reports:
Found 1 AMD root devices
Found 2 AMD nodes
Ensure roots_per_node is at least 1 to avoid the divide by zero errors.
num_nodes are allocated for amd_roots, so roots_per_node = 1 will
populate all the entries.
Also add a pr_debug() for the number of nodes.
Cc: stable@vger.kernel.org
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
This is an alternative to
https://lore.kernel.org/xen-devel/20260506055528.476493-2-penny.zheng@amd.com/
but it leaves smn available for dom0.
---
arch/x86/kernel/amd_node.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/kernel/amd_node.c b/arch/x86/kernel/amd_node.c
index 0be01725a2a4..f335c5f1ae1d 100644
--- a/arch/x86/kernel/amd_node.c
+++ b/arch/x86/kernel/amd_node.c
@@ -282,11 +282,14 @@ static int __init amd_smn_init(void)
return -ENODEV;
num_nodes = amd_num_nodes();
+ pr_debug("Found %d AMD nodes\n", num_nodes);
amd_roots = kzalloc_objs(*amd_roots, num_nodes);
if (!amd_roots)
return -ENOMEM;
roots_per_node = num_roots / num_nodes;
+ if (roots_per_node == 0)
+ roots_per_node = 1;
count = 0;
node = 0;
--
2.34.1
next reply other threads:[~2026-06-23 21:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 21:19 Jason Andryuk [this message]
2026-06-23 21:35 ` Borislav Petkov
2026-06-24 15:41 ` Jason Andryuk
2026-06-24 15:59 ` Borislav Petkov
2026-06-24 16:41 ` Jason Andryuk
2026-06-24 17:15 ` Borislav Petkov
2026-06-24 19:08 ` Jason Andryuk
2026-06-24 19:25 ` Borislav Petkov
2026-06-24 9:21 ` Ingo Molnar
2026-06-24 14:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260623211904.3674-1-jason.andryuk@amd.com \
--to=jason.andryuk@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=penny.zheng@amd.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®