From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87D0638AC92 for ; Tue, 23 Jun 2026 21:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782250517; cv=none; b=kM9ZX3M6JdPzIIbJTM+n3NgLbGq4SrUAPg5nOjC4W81AEb4V1tvNyJitx6d5miTlNRtkIfWw91seTf8Yg6SzMkYPp+8XkUflOhMHh8+xgwAuVysZf4oFnMTC9yUs1k4zypfaJvD4HyRLrKsP1JSXHn9Z3W3j/0Gbop7YqKQdD7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782250517; c=relaxed/simple; bh=aUOlwUMmvUxeWUajWHyxa6VY5afRmReJOBvfaFefO1s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SRBK+6QSHufIvxqFZJXlJU/EwhZ+vAlQspTR7Jgj/4tVV2XfFGPLwmsNdpq0LAFQx9Gn/JOL2Yqny07p8KFq83QLYRbZT38OhphyTFunc78go3j0chn3/h5b6NbgR+UU7+MPd7Ojlenfl51Vev2yNwvbF86hwLltD7RLe+wux9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kxXQe4kh; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxXQe4kh" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-490a76757e5so2156105e9.2 for ; Tue, 23 Jun 2026 14:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782250515; x=1782855315; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=npX1zE3oC8B9i4AqwB/UnRyXW+2tBx9spPlY9cjsius=; b=kxXQe4khNHhsZuZYLfHoNMuyD8he9Pm5qCSWmoJ37d2BOJ32e71EOoxMNQuH47+LDC P4lRRdy3QI4G1GaR4tAB0D0nDqjEjbibO1byHCiVUKUeHTnESuoWwQMdjd5/TGfq90qn 0AV85RuUi2n1S6BxmjzeKuFkaiXnOOBzos5QGY5NDhTxzQmC5pS943OvZCliAnbExjlF 2fru3vIAsOIMKXeE1luxuISphiWOerwU0mkhZ+7e2Drcbow7eEN/I9BIxk5I7cunfBex lfDvESZ0ZX1NfPozqDPQLIfrkzK1pjPdE1rXiIVP74K4XKyAk6oyMBYUEdsmuwG3x4FV geOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782250515; x=1782855315; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=npX1zE3oC8B9i4AqwB/UnRyXW+2tBx9spPlY9cjsius=; b=qvwGKOG/zA970zPy80QVQSCWvBaPXWUFxxHCV0VMDqEtlsfTWhyKneVhlR9j/Bk/Q3 HhLzFq1xA1z1IfGH9OcnxmQMGgpk6V2kFRzDfhW3ASq5y0w7CuUFA2uWM3HZrhN60qEF lKbEpV89ZKrCkLNKRD4TvHS+T42JulzCP/QRVGSJoYRIhcAXG1oekrFSrP+ttzotNsFP xccnZP+ARAI8wYod9jvWdKjQObaEKsXr6aOCiaie7siIZmI2qO77HExPEeGjhDCJ1vNl UY67Jy5Fdq3ZV+l3mGraQ6VS/d2wJcSBZlxsDsOvHT/BplWv16pEjFKAeCfGmQmzjoKb xePw== X-Forwarded-Encrypted: i=1; AFNElJ9YqXOFidvVMryuODnbSOZ5a+vbgRqlvDEBCiaEkBVP0CoKML7+Zzd4ksy3k5iy09OW3LtlN8tnyuJTGQg=@vger.kernel.org X-Gm-Message-State: AOJu0YxVAezSR4fDNdGjJmJZLYuPocyk2R/OfEgio6pdSnwDm2/OvNUD TLe9sIKIvK6F/7H0GyglI05HoBIRFqmDgaNrhBexcaU8RkIpqvitcOHX X-Gm-Gg: AfdE7cnDXi5zY9oz6Nf0hvWiWcvU2rpD76pvIvkPq7p5E0Ebz6ZBDG8zZWyYN6RiIoI Cg07xhkXcZWvcz+UfSR+lx+H5IxGIdI4YL7+zUU0/VG66WiSCuVFGVVYslrXu7624S8YkyFV4Ck lcRr8uWBiq0561ruC+l4tresr+845y1j9x2EHgMaURqKVFcrGaQbJ8K+/O1J1ia2SIXSw0pKW/V gQn799MvrIC+YhLN2ljHGAe/kvlM3Xh7e8VjR1ijuDBNKauCWGZ+BCLrmfGeJ72Ud/zXH3EWqfY R5Kx0rAgit9AVAwqkti98wurbNWDY5o9eKiJUwi/kaiXNE83aBwuGm1mPHl4w2znn+fA9+Zw0wk BiWRRmHKtPMP5nQxzPmVYRo5oA1sbqK/kKyk6eCS0Y39pjXF6FALU7+H7n9VW0H2JMEGAKcIBQP 50dVM5VKxtUFDWMylnVd1Ink3CUmEzPUVfJ5+75w== X-Received: by 2002:a05:600d:10b:b0:490:b642:ce31 with SMTP id 5b1f17b1804b1-49260840c5amr3352535e9.2.1782250514831; Tue, 23 Jun 2026 14:35:14 -0700 (PDT) Received: from anthony.local ([2a06:c701:49b2:4c00:12ff:e0ff:fea5:3d2e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c221d93d8sm1059435f8f.23.2026.06.23.14.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 14:35:13 -0700 (PDT) From: Amit Barzilai To: markus.elfring@web.de Cc: airlied@gmail.com, amit.barzilai22@gmail.com, andy@kernel.org, azuddinadam@gmail.com, chintanlike@gmail.com, conor+dt@kernel.org, deller@gmx.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, javierm@redhat.com, krzk+dt@kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robh@kernel.org, simona@ffwll.ch, tzimmermann@suse.de Subject: Re: [PATCH v2 3/4] drm/ssd130x: Add SSD135X_FAMILY and SSD1351 support Date: Wed, 24 Jun 2026 00:34:47 +0300 Message-ID: <20260623213447.30196-1-amit.barzilai22@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <16a86f3d-caf0-46d0-97a4-c9585bdaa06c@web.de> References: <16a86f3d-caf0-46d0-97a4-c9585bdaa06c@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Markus Elfring writes: >> +++ b/drivers/gpu/drm/solomon/ssd130x.c >> @@ -146,6 +146,33 @@ >> #define SSD133X_COLOR_DEPTH_256 0x0 >> #define SSD133X_COLOR_DEPTH_65K 0x1 >> >> +/* ssd135x commands */ >> +#define SSD135X_SET_COL_RANGE 0x15 >> +#define SSD135X_WRITE_RAM 0x5c >> +#define SSD135X_SET_ROW_RANGE 0x75 > [...] > > How do you think about to use an enumeration for such data? > https://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages Thank you for the suggestion. I used #define to stay consistent with the rest of ssd130x.c, where the command constants for the other families are all defined the same way. In my opinion an enum could be a readable solution for these values, but I don't think the switch should be included in this series. -- Thanks, Amit