From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD50739C01E for ; Wed, 24 Jun 2026 07:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782285761; cv=none; b=qnf85M4JovU+LCmTDsxj1AMnfWdY0DW/8H3G+BIAmKLYa2GOXZv/RSh3v9JWwV/Non1fUat9Yaco/T5Xhaqw1HXyDopHmUrIP47oqLX39wMDdjgpU+YaSv37k+/0x1KFk11MlMzdybhqbkKF/a/OS3okVCuqN0EKZr+giU/u2+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782285761; c=relaxed/simple; bh=nwChGcCuC+vu8JXPjj6FLvyF7C+SFBi04eIJ2mILbPQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pagHfsqQ1iVGCBywe77DwY0eek0urlcjc+IMH1TckbAZjmHvyGrASygqLC8KUjA6r+dV+sSdInFuxbKZIdGnJcpgOI5alOvWqbWqa9n1fY9qCadpCKwxQaE8t4IwEdn74193lJulGw1LCtaOccBxTeLXi171b+ZR9NCMMiVF62g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mx08zGk9; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mx08zGk9" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-37d70036426so413917a91.3 for ; Wed, 24 Jun 2026 00:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782285758; x=1782890558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZV8Zh7yj1iuS4i7Rrs7iwcE2rMMQ2V1yWPR7/wiPumM=; b=mx08zGk9DnbWxP57HbX5Ac2dluH3E0+/d/rNnq/j74nmdf5OlPCWxu5Gro1zWCGOsS n9wN6kIZBP3Wi/FwDJbA+Zy32qSgr3RpxBwP8Wvfn4XaiZ2g2GeAeguFGc5XU4J40rAl N5bFkG924c6OB0HJmDgnTbWmZ+P0+3IJHTFxY/IvIlYOCfjt7apUmKMkHM1QdDDdrfZK 08sF3gLMKNwZbtyLtYajlgMj8MEriqG80XYIwkqaVKne4pJa3n++83qPeER0711Uk+wi IdEGWvrT8h5s7Uf9t9dxb/TPMm+2WH7mzXoPM+JvMrxGvqQOibkaexggXogWO2EyoZS+ RXnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782285758; x=1782890558; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZV8Zh7yj1iuS4i7Rrs7iwcE2rMMQ2V1yWPR7/wiPumM=; b=FngeMijLPazWaY7sEDw0AD2D44H3+bEMRQRaeJeXzRnwI8f/oz6FfLATqr9LkhEz93 rve8ti+DKEoxO3l4/vSZM4ZKxjxYRom24sE42X2Sczp+toor5VqR2SjMhXXzXLhlq0g5 E64SfQvNGLhWdUpCiG5FMjqyOD4FPCEYKRjm3Joy3A9k87YqAoRsks07PsFFuHu9WN06 TrQh5PU9P10/Lv2lWv4QeVJ2N0uS12MIDTGM8fPwf+Jt08ZIAVlivGoRD1dQ4r47LzWm 3F1CP1tsVnhysbwWotJBfSTe4/naldWhJZubTEVmWsUzDLNsEq7x1y4bu+NyW7zm8Spq DNOg== X-Forwarded-Encrypted: i=1; AHgh+RoEh9dSdiGJnl8ljGesUt/8V905CItNLTAORPEDY1AH2Bx3Ue0+P7M7wW9bYgmz0QN/RQDi84pN98g8GP4=@vger.kernel.org X-Gm-Message-State: AOJu0YxYvn6nsgCpjaBv00zjb6I5WeDlNAdjxQVo/IKnhJRBkK5AkRIo LZkier1iW0MC3vN6XjiWDBStLsvitMvBa8hyU7nN2ysL2rGjQL6+9P4= X-Gm-Gg: AfdE7cl7VBqy+++8nwXR+0iX95m9p5BUi0vxNY9/mQUk7ZTBO9QR7TN/hpl8v7xxZHm Sr01QdmlzoqHsXUxfHkWdizUkdB0kL8xib0d0sMrVRz7Dxg+4Gra28QhP1zL1VCopmgSI2DaGal UgVqn83/V5hCFBPrfrL4SqIh9SbRijgrEAOD1i5tok581q2QsW70D5ru49No045gwscBK6C6M4z Cyi7goU0oj9NM0zfXXT8NzIGlpLKVE6aD8Z9uP5K07ZfkNXpjwbQQzYbyu9QuqhPotgRbeWjpYV aQvf84FbgMB4ciq0hmkfqWhyC/NV6gtgi43xXNbOzITa7ujNDJS2PUCRntFRfttHd+8ESW/za6k Tcfb7aczSMfWsQbPn3EwCiLuCLTSc83ARdXyPexI9aFIXCzgRwqnUKg2ACQpQn+3LZYjU6o4nXq 7ZILM3yLf9S7R+cVmtmMxRlpLx7qeqksvXcKA31LNS9jrZMQ7f22R+hukgyVxtW3r4 X-Received: by 2002:a17:90b:586c:b0:368:6998:b49d with SMTP id 98e67ed59e1d1-37de4219724mr2189115a91.10.1782285757623; Wed, 24 Jun 2026 00:22:37 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37de3bbc38asm1477842a91.0.2026.06.24.00.22.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 24 Jun 2026 00:22:36 -0700 (PDT) From: Myeonghun Pak To: Daniele Alessandrelli , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] crypto: keembay: Fix AEAD unregister count in error path Date: Wed, 24 Jun 2026 16:15:49 +0900 Message-ID: <20260624072230.26742-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit register_aes_algs() registers the AEAD algorithms before registering the skcipher algorithms. If skcipher registration fails, the function unwinds the earlier AEAD registration with crypto_engine_unregister_aeads(), but it passes ARRAY_SIZE(algs), which is the skcipher table size. Use ARRAY_SIZE(algs_aead) for the AEAD unwind path so the unregister helper iterates over the same table that was registered. Also clarify the nearby comment: the crypto registration helpers clean up algorithms registered within the same call, while this function must still unwind earlier successful registration steps. Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/crypto/intel/keembay/keembay-ocs-aes-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c b/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c index 8a8f6c81e0..0e42402422 100644 --- a/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c +++ b/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c @@ -1541,7 +1541,7 @@ static int register_aes_algs(struct ocs_aes_dev *aes_dev) /* * If any algorithm fails to register, all preceding algorithms that - * were successfully registered will be automatically unregistered. + * were registered in the same call are automatically unregistered. */ ret = crypto_engine_register_aeads(algs_aead, ARRAY_SIZE(algs_aead)); if (ret) @@ -1549,7 +1549,7 @@ static int register_aes_algs(struct ocs_aes_dev *aes_dev) ret = crypto_engine_register_skciphers(algs, ARRAY_SIZE(algs)); if (ret) - crypto_engine_unregister_aeads(algs_aead, ARRAY_SIZE(algs)); + crypto_engine_unregister_aeads(algs_aead, ARRAY_SIZE(algs_aead)); return ret; } -- 2.47.1