From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24D0621CFEF for ; Wed, 24 Jun 2026 12:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782304437; cv=none; b=t/B5cQ0hG7k6aAkQifs4P0hEcFEKmFXsWnSviKBVOkDXU3wN9A6/l5gsGTcI5w2au4j5/zzNZXfyInwgRSyOuu2Kgsf2sFNk00P5G41SRuvqIRtuqiroPcKiDhzWCN8WmdvK5Tq7awyQ7iPKKUZMguZDBoLH1C9w5JTb/wNwtkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782304437; c=relaxed/simple; bh=dIFG1n+3/16AhEcRlNvp0X7yhVDfpnM1O8cJjx3l3d4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oWEVAXCxVgmrszU1BGnex8SRFm/aw4k+DWFyzgr4pwzpscps/ObIayMuJMH+M5vjsyTWr7ZxRPy+un6BGQWI3Rs3wTz9DSPWuBT1fu92+c466aKADZEew91oANoctsrL1nSaYLNcykoB9UEyQmmkdEnpHtrTtSREk9jVCHFsXR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CbHnUMok; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CbHnUMok" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-808cdfc2d34so6003247b3.3 for ; Wed, 24 Jun 2026 05:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782304435; x=1782909235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nie2uXZDLsECqcE16zh+qbcPIxzXLy0OAqUyY42Dbg0=; b=CbHnUMokvk7ZZOrQv6SdiUr5UawiIzlxwu809mRNoxmgPcZuetUrlW96TktXi+j8Ya XdyLg9GTSJ9XXwljqlE/9UQphlLw1a0U6H7xFAxXEUFDTYnhv82xt8o79AMsgswO0Cvt /e6YHI61iScEmuzB5hMlctQsqr1AHE67YsmUsn2f/RCoSsrwh723LIaJRMr0wrTvqaYP jY51Iqnqr3pYQYsAGlSqAZikK8rxgzW39EoxowmiFBLlOOPlKCO65cIIgL/Gky1Hy1NZ AnUfdiiAETzSC+EBDgMVzgb1uQEmJqxrGwqBZ64XI2mbtNGeMHtwzV3376mdKI+q3X9E Y+dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782304435; x=1782909235; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nie2uXZDLsECqcE16zh+qbcPIxzXLy0OAqUyY42Dbg0=; b=VYvjnoXTcaWxJiyXXTOpRc1Jecih/dMOdHW+8WNRrt2GyjWN7WR0zLHiFjT+F266cl AFsgKpRLF5x/H/y4Mg1f0j4aHGGXFQr0K8X18Tytqr7xS1hE0yZdud5RA7J4b1X09X4p mEgtExiQiSflWV34JenANBt2gE3KFMSCPQzerKbAlMA5MaF4M0Lj+bf2mV95vBR4WbTq dszb0uAdIozRmNiLRcWUeGUb0ScjDRtTbYPc+IGXvyinb6oTzgp7Feu5pjcUWF1rrOYP 9x8KPuujNODhkmnvdVbp9Nq5Qkslae3fl2+kVHj6nm/pDt+HtSqID0TXw+vaLJ+Hf0yT Z5RA== X-Forwarded-Encrypted: i=1; AHgh+RrNBlQ2BEufirgkV1U+mpjd19k/FVkRZUpM+/W5+mAy1gtRYg3JRH8adjMNiMmqGScf2X2IxRQ82j3yB80=@vger.kernel.org X-Gm-Message-State: AOJu0YxUyCig3FfKJdYFuv5FNKIiLuk4vC2AnMSltKm3awfPoOcRNLdB SymmGxGHq84VJm65nUqu9wnG6aXrAA/pVhZXJByosx3UrtCz01assP/C X-Gm-Gg: AfdE7cl1joi/gZnBST7ZrlQwItx3CcMZst5RcJGi4sr6lHbs4MiLZ4uV+cEL/xqGoIh A81/gJp+qyioDCHYyvmc4iDsnxBTAAqeaxe1PfO5R5XAjfXUph88jYjn/pvF87Mo8N21iUpHf1D Rh7dHWSkyWzYlbMrfaIeQQ4j2RSyxGjjfLgnV2RAFzu7FZh8lZbUoeIoogmBmB5qsVDZhilKrqy TCBgWMye/V9mScjEWdUY8CML7NuP7zNdYv2E86u3TqMRxd2UMkTXeaXv5pFttC93yx7l5xP9liO 7XpY1EB/0EuWmCnX2z08MOhG77GbS9W8Yf6TqKG0P0Seut89khfYz3KlT8OA29QvFcpnebSwoOw bGSy+1gHKkoCbajBl+tL89r3dsZ+z0w2M58Cxz8QDjnPzYZHBsBLMe+Abc5Bvyqo5yJq1SGVto4 +A1u/YTcN3NV7qSIKRt/MQijHf5w== X-Received: by 2002:a05:690c:3502:b0:7ff:8c8d:162a with SMTP id 00721157ae682-80266843e74mr205029467b3.39.1782304435275; Wed, 24 Jun 2026 05:33:55 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 00721157ae682-80519668bacsm35445737b3.26.2026.06.24.05.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 05:33:54 -0700 (PDT) From: Yousef Alhouseen To: tj@kernel.org Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] tools/workqueue: parse help before importing drgn Date: Wed, 24 Jun 2026 14:33:36 +0200 Message-ID: <20260624123336.7547-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit wq_monitor.py and wq_dump.py import drgn before argparse can handle "-h". That makes help fail on systems where drgn is not installed, even though the scripts do not need drgn to print usage text. Parse arguments before importing drgn so the help path works without the runtime debugging dependency. Normal execution still imports drgn before reading kernel state. Signed-off-by: Yousef Alhouseen --- tools/workqueue/wq_dump.py | 10 +++++----- tools/workqueue/wq_monitor.py | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/workqueue/wq_dump.py b/tools/workqueue/wq_dump.py index ce4161f52..a0c722375 100644 --- a/tools/workqueue/wq_dump.py +++ b/tools/workqueue/wq_dump.py @@ -46,6 +46,11 @@ each workqueue: import sys +import argparse +parser = argparse.ArgumentParser(description=desc, + formatter_class=argparse.RawTextHelpFormatter) +args = parser.parse_args() + import drgn from drgn.helpers.linux.list import list_for_each_entry,list_empty from drgn.helpers.linux.percpu import per_cpu_ptr @@ -53,11 +58,6 @@ from drgn.helpers.linux.cpumask import for_each_cpu,for_each_possible_cpu from drgn.helpers.linux.nodemask import for_each_node from drgn.helpers.linux.idr import idr_for_each -import argparse -parser = argparse.ArgumentParser(description=desc, - formatter_class=argparse.RawTextHelpFormatter) -args = parser.parse_args() - def err(s): print(s, file=sys.stderr, flush=True) sys.exit(1) diff --git a/tools/workqueue/wq_monitor.py b/tools/workqueue/wq_monitor.py index 9e964c5be..7f47fa398 100644 --- a/tools/workqueue/wq_monitor.py +++ b/tools/workqueue/wq_monitor.py @@ -37,9 +37,6 @@ import re import time import json -import drgn -from drgn.helpers.linux.list import list_for_each_entry - import argparse parser = argparse.ArgumentParser(description=desc, formatter_class=argparse.RawTextHelpFormatter) @@ -51,6 +48,9 @@ parser.add_argument('-j', '--json', action='store_true', help='Output in json') args = parser.parse_args() +import drgn +from drgn.helpers.linux.list import list_for_each_entry + workqueues = prog['workqueues'] WQ_UNBOUND = prog['WQ_UNBOUND'] -- 2.54.0