From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 477713A1DB for ; Wed, 24 Jun 2026 20:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782332100; cv=none; b=MJPYnohA+jaf4Wud2yhhSMAhrAsqhDkDmLaSDg4g5XdEG6iRizUoMXPZHwkEuTgw0Ip0A7BL918ZorF7KhZ/p7U5L0vES79VMwq90qb+z29jn7OyF6snvZvr/s25g3+hCT4InTRAdG9FwmOpTEcj90xHc01p2gKmUcb2Yl5Zuto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782332100; c=relaxed/simple; bh=IxMWDi6Q+Xg5MztMhHW72MWZx3+2qLWHv5Uks9W4fzk=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=EBb4wk0Q8aBCLdglWL+rGfCgA4WnxMyzMfxtqgoaRFk7fJ2uhIKXp1S3CGGFYiH8DR01FdeS4JsPEOqPyt6R5OSmoh02XKnR8C25yquh0MZQedZf7VWYwSrHOZ2guIpR4103N7AFkssrttGTlvjbL+wC+M9J9jNAzeaL6G1l0MQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=m/31r4lU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="m/31r4lU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CF311F000E9; Wed, 24 Jun 2026 20:14:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1782332098; bh=YF1E9A9j95RYF32v6gA/V22KvXKXCKGMa1Pt37MWNeg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=m/31r4lUWdbeEfzdyGYpyGj8SbO06MuTV7Q1+9m+BqdEt1g+/oFlfFdJXa6o8by84 776pwrVBnSkVMfCnuWeKYOol0K28OPkgR72Nr8/QhwIQ5HTFnzN0j3q0pT85gt31Mx Z8D8Uqs/5LAiR/SqyxV8GguVfm9rOFUemekpn14U= Date: Wed, 24 Jun 2026 13:14:57 -0700 From: Andrew Morton To: Wei Yang Cc: david@kernel.org, ljs@kernel.org, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lance.yang@linux.dev Subject: Re: [PATCH] mm/page_vma_mapped: guard check_pmd() with CONFIG_TRANSPARENT_HUGEPAGE Message-Id: <20260624131457.ac81fbac373f78aa80a516e3@linux-foundation.org> In-Reply-To: <20260624082359.2869-1-richard.weiyang@gmail.com> References: <20260624082359.2869-1-richard.weiyang@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Jun 2026 08:23:59 +0000 Wei Yang wrote: > The kernel test robot reported a build failure on the parisc architecture > when expanding HPAGE_PMD_NR in check_pmd(). > > mm/page_vma_mapped.c:142:13: note: in expansion of macro 'HPAGE_PMD_NR' > if ((pfn + HPAGE_PMD_NR - 1) < pvmw->pfn) > ^~~~~~~~~~~~ > > The config [1] in report link shows neither TRANSPARENT_HUGEPAGE nor > HUGETLB_PAGE is defined. Then trigger the BUILD_BUG. > > Fix it by define check_pmd() under CONFIG_TRANSPARENT_HUGEPAGE. hm, #ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES #define HPAGE_PMD_SHIFT PMD_SHIFT #define HPAGE_PUD_SHIFT PUD_SHIFT #else #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) #define HPAGE_PUD_SHIFT ({ BUILD_BUG(); 0; }) #endif > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > /* Returns true if the two ranges overlap. Careful to not overflow. */ > static bool check_pmd(unsigned long pfn, struct page_vma_mapped_walk *pvmw) > { > @@ -145,6 +146,12 @@ static bool check_pmd(unsigned long pfn, struct page_vma_mapped_walk *pvmw) > return false; > return true; > } > +#else > +static bool check_pmd(unsigned long pfn, struct page_vma_mapped_walk *pvmw) > +{ > + return false; > +} > +#endif I'll leave it to others to decide if this is the most appropriate fix. Sashiko had an off-topic complaint about the surrounding code: https://lore.kernel.org/oe-kbuild-all/202606240042.ffPsEXVc-lkp@intel.com/