From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A49E36A372 for ; Wed, 24 Jun 2026 17:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782321671; cv=none; b=jMuhBeSHgAbqlE/rNedDWQWLhS1yce9HwOqFI8oHrnqDb6ibbqBFzhUq8aCfaMJ90S38Ew7If03wwg2eqUl1Vi6pXszmXPKpcJk2KPsShWPpWMeFOkQnm4o+Ix+KXO22Zh3A5KJzv0B8d+4IklHLntb0mCRn/Es6mXzcW8iNroQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782321671; c=relaxed/simple; bh=LKqCXWaTfjHPv6NE2JoBFTtrGOe+HG9PCNEW4hyYksg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hw5BisPLd3W5LXr2Rdrc9dAm41KHFsdUNgWz/JLu/+ZrpA/1sBcw7lvkOnqT4vrbPNC569n9bt/4XTl+gH+VbRElh70P8MINY652G2gHwtI1H89TL0X9vgCnZ9Qz8HC1LQwNKPg0ccEqNXmraS9ILnF6ot+MnGx7WT92jiOi4v4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a5E6mf4F; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a5E6mf4F" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so9685515e9.0 for ; Wed, 24 Jun 2026 10:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782321669; x=1782926469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TbgHCjopHlS/2Xfh1jkQjyRfQ4ZwvIFloenkAWi04I4=; b=a5E6mf4FEOukQ/p5BfvsTPzCKp+eUPRNoOk68Xo2P8hHkwP0uVEyrVmqiP8hfRa3dk 8sDMG7zn2ZQXjp92GlNid2t5SmIdLrOZysXeqYB+kZAziruHmjRyyrBHAa9T+KQBgv5u su8rd00gB6Hm3NQTfF6W54obTAtYidox3j1Y8r5UBoTDAZFkNY+eY7MDNnqEICxE2P/4 j3wUSboWTfiBXhyF3SCQLwvVoiMr7+nZ0MKsmIhGSZdxXbxDPFGyDNqd9pNE21PcGZW8 CCBTm+ovU5/X2OKdtRNcolqyxSaEUwSrGqmB6bLzkZZZ2de22aavozI4Ei/HP1HAT6RR pj5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782321669; x=1782926469; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TbgHCjopHlS/2Xfh1jkQjyRfQ4ZwvIFloenkAWi04I4=; b=ObG2cmMpt4fquhi+DYG5ZixL9t8UxHfbrT+6DO+og0qAXOfKKILinaggKFUdAtkDLX UDK8WnAKqb5sZKlWl9Bm2PrDjwRw2p+yW3KttAUxXuDLWJAG5mI6QF5e5cnAAkOqkYen YoA7btjsptaMrkPg2NlVxkdce4roadCplNyLm6q6DdxrfsdFFzzvxgCb68FEDs3h3D2D t3U47j51H/Klg8z2nJSrGJfeoPHwKEarlY2km5MpLB/aPVsN0UVivceptIDwUl/Yu4F1 oX6BQyIOGvt9GWuvtwipN+3L9Ic/BlP2v0RzZ4jH8+PD9Wr1/8cFIXlIW3YyxKRJqPsp d55w== X-Forwarded-Encrypted: i=1; AFNElJ877o/zsZoGOSx/pJ5MOTUzphY77YQZdODYJ2wKMU+5SYFRZTjF41b6aYgb8F127mz2iuFm3B0nQFNYXdY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm/8qiILb5Y4ky1xxSy4gCY7dRvk92z9jvBvAKhHxyYNaP5Evg Lwx2yI0P+LZsBpDJBBilO+ERYjruqzju8twUt9pSH8abfTz6bnMmOWmh X-Gm-Gg: AfdE7cm6mIMLUELdLy13BpKx6f8otuPlcmHk2/7+HFBkpUWUcFECTjxMW7ruhA6DvwH k20+apWKvgdFZFXiZi51VKavX5I91p3j2B1T+SZnngvZRbJxPCzZCh1P71gF4AmDAFhHVgJG6yR dnWwaNeF3BHUr0iv1mSLPdsMSBUncP55jSTqJ/rXPmDLutnKaV6vhCJrJ9/wahktBeRR2+CO+FA UU8ULH019++1HEAonUsZD/vObTZJQX8SWgchRAzLZ16RspzjxXAmLwAWjtmDcSZUgVKGnedoy57 50o8CNqLv+Zg6iRHDoGqoueKFYFhb1AtplsisaynjKW/kYYszYssw6Ibh0VnWunVjNzgI0DuLAo AVPr+VbXWI5xKhMVlscko7jdOuExT/xYuuDNSgVEaAwk4xWOyuRGHGeYrqpfcq5QCYVaePwhqIR fFGhyXV0xIIVi5PZm7PVIFdmi0/A== X-Received: by 2002:a05:600c:6290:b0:492:463c:48b7 with SMTP id 5b1f17b1804b1-4925b379813mr131866485e9.22.1782321668471; Wed, 24 Jun 2026 10:21:08 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49264021121sm10826125e9.4.2026.06.24.10.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 10:21:07 -0700 (PDT) From: Yousef Alhouseen To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: David Airlie , Simona Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] drm/amdgpu: reject mapping info for unmapped BOs Date: Wed, 24 Jun 2026 19:20:29 +0200 Message-ID: <20260624172029.2508-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit AMDGPU_GEM_OP_GET_MAPPING_INFO looks up the BO's VM mapping and then iterates the valid and invalid mapping lists unconditionally. A GEM BO can be queried before it has been mapped into the file VM, in which case amdgpu_vm_bo_find() returns NULL and the list walk dereferences it. Return -ENOENT for an unmapped BO, matching the VA operation path that already rejects missing BO-VA state before touching the mapping lists. Signed-off-by: Yousef Alhouseen --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c index 212c14d99..4b2699931 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c @@ -1087,6 +1087,12 @@ int amdgpu_gem_op_ioctl(struct drm_device *dev, void *data, struct drm_amdgpu_gem_vm_entry *vm_entries; struct amdgpu_bo_va_mapping *mapping; int num_mappings = 0; + + if (!bo_va) { + r = -ENOENT; + goto out_exec; + } + /* * num_entries is set as an input to the size of the user-allocated array of * drm_amdgpu_gem_vm_entry stored at args->value. -- 2.54.0