From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1096934846A for ; Wed, 24 Jun 2026 17:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782322648; cv=none; b=MMLV3TufQ7MeldLWcC/88H6OvBbEwr0pN6wOTdMc9xBnxm/YBki1kqg4lOQZSqnr636gxdh0tQXFEDzVZXaz2FiDIqxBzDHj0yJq+dBLUaRKv1PHpdwVfZ7zC7C6swbckm0rc6K4nGV7FcfqX1fhLeYo4RV1G8oOAespzuQPjk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782322648; c=relaxed/simple; bh=TKGje4ydhTDywAf3dZWe1jxC8rLp16NGldB8VQGRD2w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IJkd/f4R2jTjHb+uYQou58fBs2LbE23bzdnmGQqL5gjLptWSUUlma5BBV04E2rUaUP63ZI+kIH94Jes6oxmAMTLRTXdzYZVY9zAiaBq5elBENmoZbx1esB20MzRgiJovbZGq8eCkGOvGb0B23RpR7kL1U6YKJj3sCXF581vKjsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hjFtlX0T; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hjFtlX0T" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7ff05e5d009so12384327b3.1 for ; Wed, 24 Jun 2026 10:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782322646; x=1782927446; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gbLBOFkwaSWmvDwNKHtl/D5jUvTCk24NxaxAKlNrUbE=; b=hjFtlX0T2N/eBo1o+J8Ovp2pQ+U7OSkEnIjFsDW+kZMrKu6ou/XLbcqf7eoyW0S6VP HC0Y3Kh45Gk32ZQP/cH2bgseIPw7J56DbDvQAjt57TJb3aGKuGlm2Kfd+z1RlSvjZPXh ComqAlZJsbf4mjP6KRGnBAgpjGLAn8LFm/+fgJC4dxYsCe62kl6YIIIZNj+DfKfkjQOg BZ9hPckfrYNENcoK+6UuGSUzYDyElL4kQaO77LGqFQ3QnAOoQwiXGf+Li0d8MTt+SETx WmiYSZNFWV+a8xeSM26QBU5yZTH6tsMrAbbDG6WZmHqhZJ/IJWwqTOmXr6av3SEB3pIX KYXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782322646; x=1782927446; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gbLBOFkwaSWmvDwNKHtl/D5jUvTCk24NxaxAKlNrUbE=; b=j2IONfN4NQ7CFVOeSLaiGMi1PAXeGNQB/F/1aHnuZN0EEkrQSsAtCDCh1JUBicgkpX PQRDfFdOON5ZPrrdfm4vuEmVL69cPHZvNjPFfRxm1DLnyJSLlCnbZDPx6qNf8cw67Yei X50QAR2tkoJmLour3UJks4H91JyfUHr05D+j7syQ1dkOA6Y17VZcfXc5XRjWvLY+/HPr y1kX1gDAnVeMvF27eXV0JT/uKzZLUNl4t4HPp324YnzfCfXyujkfmSZeLt+6DWvReiky sZtXrr1wZeTXc2uTZtpmalsOtfJI2BTsw6r7tQAwjl5qixAPYGj/WHdWBE7kUU316h7s 3vgA== X-Forwarded-Encrypted: i=1; AHgh+RozPeA4oN4sYew4keJZ3fjQDcCrfFqG1XHDS2anFuOP7w4Px5gKhnrJI2V/dvT28wwHK/hTEKOSx4hN03U=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2VUAMMVB7SsWVG+s6mHiVMBx3lUBu1RoZG3IIx8E43rLNEmsi EFoyKsDmnzXjkGuidMsEMC+L7tLVEDzyiMUyVsiItI+4gmKB5Qtrg60k8uwHBQJFimnCiw== X-Gm-Gg: AfdE7ck7mlCWMm6RbKo3jDbjOxJyyUz4C+ywRe/iffBsN7DcpFDLuaueg4b4KUuXUXd sr8HmkxeYr3Ar0M/GdqRSe4Gs8DKYi8aF0OtYBsmT0VFg/Hc00Pim22yeWtDzktYROdN/ND6yvJ Wi1HjhG28FARsCVIeEyH2+6VO+BGVdtP/UOXUL4N8W1zxCUndQJsoiWoc70QOmcgJRXKFOhP1r4 fROPlTC7Z/vC29LLqTNmsOodc84uxgqJLMyxAn/Vjtu+eHbV2BNCr6gxXmXkVybEbZ9a11IKhpi AjNcqE/xu9LZxUl1p9q4ZgEMpSdF5t4jVURdphuJEsPi8585vsYzL6XUwNxHZp4ZK8u1u3o7VNA ZCOkaKVCDonaSDeJt3Xi47yReiZWcTfUPnGpqVY8GXGWhQfwEH9rFLBsgBSyMHF4V5/9XERJD5I llbF52TPaUkiOgy2J5HqczHU7zMO2aiqXyQvwf X-Received: by 2002:a05:690c:c525:b0:7fd:fba1:154d with SMTP id 00721157ae682-806c3a1a9e8mr84030957b3.30.1782322646048; Wed, 24 Jun 2026 10:37:26 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 00721157ae682-80704f79685sm21922987b3.35.2026.06.24.10.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 10:37:25 -0700 (PDT) From: Yousef Alhouseen To: Alexander Graf Cc: The AWS Nitro Enclaves Team , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] virtio: nsm: require CAP_SYS_ADMIN for raw messages Date: Wed, 24 Jun 2026 19:36:41 +0200 Message-ID: <20260624173641.4529-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit NSM_IOCTL_RAW is documented as CAP_SYS_ADMIN-only. /dev/nsm is mode 0666, but the ioctl handler did not check that capability. Reject unprivileged raw messages before sending them to the device. Signed-off-by: Yousef Alhouseen --- drivers/misc/nsm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/nsm.c b/drivers/misc/nsm.c index e39ff0071..8153edff3 100644 --- a/drivers/misc/nsm.c +++ b/drivers/misc/nsm.c @@ -9,6 +9,7 @@ * space can use to issue these commands. */ +#include #include #include #include @@ -361,6 +362,9 @@ static long nsm_dev_ioctl(struct file *file, unsigned int cmd, if (cmd != NSM_IOCTL_RAW) return -EINVAL; + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + if (_IOC_SIZE(cmd) != sizeof(raw)) return -EINVAL; -- 2.54.0