From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F423DD849 for ; Wed, 24 Jun 2026 17:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782323677; cv=none; b=kDLEMswWz1X5vbl9Ob0u/YMqk8LqL1I1RVCIRD/EOnZnlpOqhMw19NquyGH+cdxRl9rynINfkq13swoj2jHGRg0rtf5JvB0sVIF1UsKB25iNdlJW0HCXFBGupCZRzpcfW4+/E5/7smaPYFkPEU7B1825XlJonPvuSZKAmWbRCUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782323677; c=relaxed/simple; bh=G/yey2DjTXK5cUM0cGAmKk2ITSyiSAKh/RldE4P/dlk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Zq53jabo0+DIIfh70AOYm98fRIFUd/GmYiUOOiZ/jkbe/CmH5AuiqbWV5/qNhfLtOPw2fjpqlvECe6I2oT2mkaBKJ4tb1h7Bf2miGxcPgR7H11sWYpjxUe4DqWFKRJAcO15Fdos7MOj1xVfyOSCSrejiL4s0WiOCSVNnsqmOC/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=De+8V9Ga; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="De+8V9Ga" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49241a577d8so8376395e9.3 for ; Wed, 24 Jun 2026 10:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782323675; x=1782928475; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yCZEX2R6bEaNN/h2EUsAowUugoqXu39Vr1FkL1z6cW4=; b=De+8V9GaKiy4eJgVwiu5cnladzuF1WbeBQlh0YFXHhZaP6C4eZXPRUqJSNEEthlGb4 HjXD6urGxWBZETKx7pI9JDKvZ40/1coy6PGFBeAS5PqMFYSy+Nyy2X+SMfo5BFNKIc5J bHKvYcvIDtlTU+7xaoUEVjFMS7KD7Sx6sO4UQ16hDnMSvMHwbFCpXxmrOe6qnemEpfdd DUvu5v68t55caTl9h3TrtBKY8CRWRvBt0doN4/+ZYae2jSLLGqLS4+TA+FOudKOV/G0m krSi1ycVJtTjFm8QdUTwoaxyYhaDg1iV+Wrne/9Mw3uhz785sDydlDG97QkJWdeQd/cW 7OgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782323675; x=1782928475; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yCZEX2R6bEaNN/h2EUsAowUugoqXu39Vr1FkL1z6cW4=; b=JIr95cF4U5Vo8U22N2HvIDmAzsmX9OFmKSQ8M7RmjOyWJYklvy3mp11top4ZyIw8FP BIQ38KSqNxGojXH5k2Ukk/fUqfAOeXv6wIiaH2ddrQTplQ9aX/vjTwV2luGpzxT6Jbf9 amT22OxJvCmThdgCsPAb08191rl45ay3VZsvBzG22RKf1CIWEaYETIKEESs9Vy/9Lwvc pV5Ho5aKLszdr/df2s5IBWvl0xlXGEd0KQ5Z1i8urNyB6WT+UhdaKyy5wsnqxlNRKZ+F ffRSwc+snDjtxSJGAyvn5bxrsEaGY9JJzLtX/1V3hPxoVx6O7HfJgBfwxylEoBVGEx0T 7o0g== X-Forwarded-Encrypted: i=1; AFNElJ/7ULP/gDNp7S3Wg2TQBu9bavNt+LkC4DcKJpDzq8k7HXDHrPeKjpM6RsCxEkFSOwMPRxHvgq+RTusOYIA=@vger.kernel.org X-Gm-Message-State: AOJu0YxE5NE/cz0xNlBb0GpWesDZmkwGnz1QGKFeFWCcnaKlHMle3DXC Lv90vabCd1xwOf7swLBvO3SQPs/FeQBEzZ6DEfcsDv94CJZMhf0RRUwT X-Gm-Gg: AfdE7cm8s1M8VyuydKpZxmd7+h3DO7mMigvIJzWadKAt3GoKrid2BYxlwm+6XG5KCH4 TLt7S40slJKoavU2vfNnzPXynPmVbSZGmh1trbtfIwzvXjOwfrO1Q+Lv8GXiYO4M0f6dT8zyRIY c8UIlU4UL8ntXdWpbUGf2MutYaQ2TtNBC1TLPfPsUiDpjrX5UMjIXAyN89N+WY/J6F22N3dPvlq N3wM7kh2VKuNWNwXRwEjP8oo16TKGz03yXZyxrMBN9bI9ByCuD04Hq9qHMo6HDYneqi6Pb68xZC L6NDPeeayZnVF9PUCuAXo8GgntGO813LzE8HI435OfYWMrAQiS+t1MLtQTFOT4AWLjIxzedmU6Q PxWD6fdORULsXcDat679Q7z8FRyuhBIUUaipYBH5xzDksVUWtAHrH04akodWzuYyKEU/5H+ww/r BFFiaTS7/DHzqpO0uZelruanaOSA== X-Received: by 2002:a05:600c:a010:b0:492:3754:15f2 with SMTP id 5b1f17b1804b1-492608794b0mr57788945e9.32.1782323674462; Wed, 24 Jun 2026 10:54:34 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49264011e9asm10731845e9.3.2026.06.24.10.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 10:54:34 -0700 (PDT) From: Yousef Alhouseen To: Corey Minyard Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] ipmi: ipmb: validate write message length Date: Wed, 24 Jun 2026 19:53:53 +0200 Message-ID: <20260624175353.8592-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipmb_write() read message fields before validating the length byte. A zero or short write can read uninitialized stack bytes. A length smaller than the SMBus header underflows the block write length. Require a non-empty buffer and the minimum IPMB request length. Also require the length byte plus payload before parsing the message. Signed-off-by: Yousef Alhouseen --- drivers/char/ipmi/ipmb_dev_int.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c index 2fe1d205c..dd750392c 100644 --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi/ipmb_dev_int.c @@ -141,13 +141,14 @@ static ssize_t ipmb_write(struct file *file, const char __user *buf, u8 msg[MAX_MSG_LEN]; ssize_t ret; - if (count > sizeof(msg)) + if (!count || count > sizeof(msg)) return -EINVAL; if (copy_from_user(&msg, buf, count)) return -EFAULT; - if (count < msg[0]) + if (msg[IPMB_MSG_LEN_IDX] < IPMB_REQUEST_LEN_MIN || + count < (size_t)msg[IPMB_MSG_LEN_IDX] + 1) return -EINVAL; rq_sa = GET_7BIT_ADDR(msg[RQ_SA_8BIT_IDX]); -- 2.54.0