From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CED62F7AC1 for ; Wed, 24 Jun 2026 19:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782328139; cv=none; b=dYE3uwkZ9qhgW0JX8naHQ1CaI5Dd8yPhvfc1QSNHYCW1YpWGuayqFYz/ybHJbAvCMBqj+hIMdcwfWgR+ojSzwNOm0BjQTXoBpXegOyxdeIfI91syBB5bml2jDbwoJqnz4EyG+/ZDOCW682n0+LdfV6wdZr9QXK3Wf5BbPzcwNWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782328139; c=relaxed/simple; bh=07WDKA0OdoOqxTpe+k+VziHT+HpeKDFAeOlyfNRgqpw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qBF31B41DWvSiF9T/OA2vSx2IHIzlVXWh7M+mcwPe4RQh7gYlmJR+LvFk9g7j0cCPCRkY4AEPlrphY30V2eI7bcQZCio4xa5ly9xrg2tcZ2RTgMnXzXfhFkZL3xoi4vRDCsBS0hMDyesBTNECzj/AW7P0kz0P0WpyFbxXjDjJPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IUEPbcBD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cRUlz6Tw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IUEPbcBD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cRUlz6Tw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OHiuLY4057304 for ; Wed, 24 Jun 2026 19:08:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=T81WvvV1onC oDTK7QcIKnL89AdcLmXT+NQJ9Gf5Oqjc=; b=IUEPbcBD/Dz7Cr151OoBwPjK8j9 fmMSIEk4nvNENUeQ42Eerx0cSU6ZS1H/rrBzcegnXTlOxRZ6FYVqctHXCwdzBz2A A3geQczUVM+GG6wngvlcZ7seHvduYbapWjugrc3DCFL3ulFY5gHELnmN3QMiswyl MHuacsLPodnzjJDv3ma0PNimt4ip3JkTejXOo6DlBJHBuI0WjWsvd804ZhfMXUqC id+RYZ0HqAynBW9oaTPUiKc1vE0VLZdqfmKucZyKKJAottMxanKmQTxsn/cSKEQB b3zzuu7Mi3P9WHJxP0ckQayi+LuuepYEppZxLq/E5wIJKwUiETG8pLU/v7A== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0d5g25nn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 19:08:57 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-845319bb97bso1119269b3a.0 for ; Wed, 24 Jun 2026 12:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782328136; x=1782932936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T81WvvV1onCoDTK7QcIKnL89AdcLmXT+NQJ9Gf5Oqjc=; b=cRUlz6TwmLwAcV3Wic7l2hlG/1sZzIULzC1DNg2IpY6h2XjUmK3cNXUGQQpfcbRD5V 5sK+clA3RT68TknRwJQM6R1fgxr8Z4yJUcrw+6jr3B3+4xqjg0+4O062JrekB4USgHH+ zM3TpEQJ/ff6auI08XnsBbuutWOiKt9qxdFCly7pI5ky3o8/ZAJN1HB6K02lRZ05ri90 9XU87796BucXtD9jnT4Meyh69qMpa9ScJZ3xTXzE4yUOe9WxmWUreSfEJObLcOg89e9x mogoDgpVuVFhOTgHeQKcSoLvT1tDs9lM14KGJq9pLmsfcnHf1ZDFaj6J7lQI4/b3VitW 7V6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782328136; x=1782932936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T81WvvV1onCoDTK7QcIKnL89AdcLmXT+NQJ9Gf5Oqjc=; b=LKq2nuDYiewmDgDPzfpsTyBRYNZS71Uhvjqi+8DUu5433N1QKF8fSMnSjIURo0B7DK RmIArQSvaNKHSXn287T5dvTl/yztC+pTnDhCj249pqN9Ie5ua1bcmMLHLo8mpBtlxPQO 0kILLf0AuEDmlzdmfu7CkXpODhYwHGkRc1Z8c7u2Ii2jEmOXIJe17eWjbP8q8Srvvbni oLiVwTMh4s/AkKoUtR5q8f3r4hDgEOz3JU9UjZvLc8AKw0c+crS/0ulcSmlB/t6vLOnr yU1DS1HKpFkP18oGsoWDelYZQOMEEr9LUpbPm4t6nYvig9tdHgwvvBIRFpl/IErR5oFp kpEw== X-Forwarded-Encrypted: i=1; AHgh+Rro8AsIAP8gzNWZ/FSkZcTOUjaIU0aWw7aJiBH65NJit/h3Ct/2MftI796JDZpNZELGNJQNZc2iMIPtCFg=@vger.kernel.org X-Gm-Message-State: AOJu0YzX+mxnfEqN5b1Nm6g+J55/iaTzfZWaaiVYWmGhx/Ax5gCtl8Yx JPK4myaXc/0GigAI9dChBwStq8j9Qe7TAynROFPNqTJxsHPKXD7XPgPFHnDXdqRaTGf+BrVp4gy YikHGemyCSABYEOR5+xHdi6YoO+l6WYcFCnsWVnzCVOgaL0uyq+MmtALL4g61ZFo0G3w= X-Gm-Gg: AfdE7cn7fcWN/HkBuBxwDpF4+M7zLp0Hw4R8BMEN0tZQMdo++AclfckC/Bo5uuoovJw jhLmk3TykbRTwwhBhmBH2kusKlIam3bsCTyMjXRC6rz0Q0nv5YhgV/UC9QlQL5Wg1iHtqTbCbL6 lx3q87mWBFlBOK1RKiOpe0aCp2CwxqN+epk4rLyvSFVql4RC/l0/VJ7/4r5C6JCPfRinWzqEWR6 7d/lstOnoj5ZaZESnAZQ5AQ3vIyr+vS5MfBHwpvl/T0MK3/05JuiV9XwVhUX6ZgcBdJWVIN8JqI Nrm2qVZpfcr1QNn+mdavdReA47sTgePTlnm1O05fZoki5AvyQSJIhyBZOb+9Sf10Pz1N0T0MQDt CExERbK3KJDLQrZvQfT0gz6v1ZpZTlONcK11uLw== X-Received: by 2002:a05:6a00:801b:b0:845:45b5:9825 with SMTP id d2e1a72fcca58-845a2c7e050mr6230941b3a.37.1782328135993; Wed, 24 Jun 2026 12:08:55 -0700 (PDT) X-Received: by 2002:a05:6a00:801b:b0:845:45b5:9825 with SMTP id d2e1a72fcca58-845a2c7e050mr6230889b3a.37.1782328135381; Wed, 24 Jun 2026 12:08:55 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a412e5e9sm2932120b3a.54.2026.06.24.12.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 12:08:55 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio , Dmitry Baryshkov Subject: [PATCH v4 04/19] firmware: qcom: scm: use dev_err_probe() for dload address failure Date: Thu, 25 Jun 2026 00:38:15 +0530 Message-ID: <20260624190830.3131112-5-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260624190830.3131112-1-mukesh.ojha@oss.qualcomm.com> References: <20260624190830.3131112-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=LdMMLDfi c=1 sm=1 tr=0 ts=6a3c2b49 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=GEQWD5Nhug1BhVu3dP8A:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: AvZLW3pnj1pqGLnhn7-XVpzQU-ZPf2y_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDE2MCBTYWx0ZWRfXyUL3kEd+UMLF eeoOwMJerlvf2r7UoxM94oTNdkuCf1k8K7x07tQDdTyl5G6ACTdBpc4ZYuRrqir2+bFTzOp/HeP j+TiVDc4JU67aR+lbrM0EGXqcGE7uelrj9+iTDAMVmLPSJWz759rNvhyR4qDu6gry8mHMqFkUKA ForvJI0XNjnwLbGCtXdASEXtXO+wPhvJ/dlqUSQ5NmDCGscNbYEFstdmhJUdV8hTICYNHVV0lk7 nWON91NdtS4zBP6/IowBOZC2OPFNj267/Uvw6nSoBhX5P4t53pUa+DRKfd0jWDm1+39oGsNBZIW FZw+xVSuNutXby/1buSleiv37iticFeZ63+C7CNW7m2NEfgaJzQR5WJ4JcgaOi93sFiHNRVSXpg Sa7w7ejGlgMaIgSr9u7H/R66pdOBNCzsyOzF6cA2MWAViz43F0HrHoctuz0ADsoX5nKwZqeKBdc RPS1WbVoSuoWlVYkCxg== X-Proofpoint-GUID: AvZLW3pnj1pqGLnhn7-XVpzQU-ZPf2y_ X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDE2MCBTYWx0ZWRfX+Dpfu1OR0s/s 2R17StK9qtEhUguEWTLDAHHfrP7AaIlOVjZyzlxYF2I3emvfc6+Q9NtzbFSPhppVVt5MsZQ6qSK CM/8ysOPr/RuMT0V+INlvwVV9/PxGhQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240160 Replace the bare `return ret` after qcom_scm_find_dload_address() with dev_err_probe() to produce a consistent, deferred-probe-aware error message when the download-mode address cannot be resolved. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index b78da40a4d60..83e4810f1c53 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -2751,7 +2751,8 @@ static int qcom_scm_probe(struct platform_device *pdev) scm->dev = &pdev->dev; ret = qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr); if (ret < 0) - return ret; + return dev_err_probe(&pdev->dev, ret, + "Failed to get download mode address\n"); mutex_init(&scm->scm_bw_lock); -- 2.53.0