From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 531C3383990 for ; Wed, 24 Jun 2026 19:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782329271; cv=none; b=ar0i6kbMqG3m32uDJqNzVaLeV/vcpKu8o3c+H4cTph72lp5E25vdLMG2vf9TKtJHFkJtDTf80e79cqNPud+qtrxT/bDG5y4/O8tKj8pF9Zp4NPp2knzvpJQziR0GXWXkGq0nqYlovNzbdrDxo+hJXTAdHGwt2cXeSmS/dQx2nds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782329271; c=relaxed/simple; bh=4G3Vq2EmQSdqmBgSPGmHBBAmA2KZFztTi3V66UMmoN4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FnuhpbtISp+/raXaEXi+b8gqIN/+FQyRDNDebsEmu7PYxksbk1y6C6tkQY0tu+cmHtfzds0WDXXf1532tT99y2LqmX3O/sYryCrBU47u6RZWfFoD+xVKTwBR2kTQDMsOREdJYOnSdGvU+C2eSP9XqF9cw8uh2PS8SupUQ6/HSWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CKphm4A6; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CKphm4A6" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-662b76dabfcso1675696d50.1 for ; Wed, 24 Jun 2026 12:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782329268; x=1782934068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+BitzJFDbUPVda/ZhCxrpv+F0X4dQ/6HuYsKwRcXpws=; b=CKphm4A6XTMkPkkFy23Y5yF2MDNLwEiU0kl+P6aV65kZHt8yB1dwrB8CKBCR1nbVHN G80ix4xFv/CPdUZ5N0PnfNTDLI/ZTexMjQzXpdwIaG4xAWKgG9TehyFSIqu087sJt5Iw uRTlFTx78jayQKY4sJo6+zAiOl0TG4kD6Oyzr/yNWhHANWew29J5BTQgMJ6T9n3RJvO7 58z5osc0ij9hS01kwsgadHVVDAFTGjPAiliWnReZ2ljqQzveB1JpXA4szp+eMI4zf4ev bHIesMg9ScB/+k0j/bL8WKSi/fzEMqsfbPUxwTJWLMD5rPxOs6HZNA/X5zSI8Bh3UjDR cRgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782329268; x=1782934068; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+BitzJFDbUPVda/ZhCxrpv+F0X4dQ/6HuYsKwRcXpws=; b=ZpVsoxL3L8/gGVb6RqXzhMTiW0dgUANC/wavB/GpXYvqm/LS+k/yFIplA1KJRQJC9a 3yZwtfzSdDvWLXs7mTq0z1csAD/WvLMJA3YaipYaKcDo15Jkq1A3MsqSNIL93EElI7Nb tk3+3hzavQSN6aaqzK1euz9H/wVpw5gtLHv2HtQmeuAGMyv1sCb64tiApRb6sE8WL1fN iBBCRfgI6xa+C7XCgnh3VvJD8uR4dCcW3KUb7nFLlzjF9ckhDRREEwksCpwHHq5sUI4b /mK7elpJC7kOj25SYLAb82F0y2ZKlDkCMffaAmIT5mRoi3VBObnM1VzfYVMdpfautHjN luSg== X-Forwarded-Encrypted: i=1; AHgh+Rqx/NZ2MtVdjY3eej0d1qUgpiNs5y1StB+XznkZ7lRI2YF9MWkfDRUgfqvHWfstNf9/T610lPfLvWBcCXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzK479BQNAhXJNOj4dNJjIbf+uY8IN7dmTsn2OuGcETP/+DIaKx 826N3w6aJ0xZH7YGo+5Rr/1u/KdAG868lh+28WnNr44SzGUTEE6LFU1e X-Gm-Gg: AfdE7cnd/+5O9ig5F5gjGgYorHztqmjVPUXGjfsUuOxuj6I3p2mMZ/G+dtuUoGhmciu A+y8D5g0AD164cX4URGcP6H1kllr23ICjzDK73vECp8yQwWmWuv0UeSKxDnzCfVA4rEAbbN8lBe k/05HMPMeM7b0oE6IeynyE6UKevLGcQ5OKmmw10r3C3rczZK+UFozCLiRUWTxXumFywYVv+ef8a GmAJPX6PeezipV61WM6sg1SMbIFIPS6ltBWsoXMBG7lm3SdVQl25eG1pMS71/Zw3tt004unZRav HGm4bz929fOXC9+ZZNpiCx93diIzrGp/OFpyGVLmZN1h11DbT7f7KYCsJH4sS6pV7vaMzAGur11 5Twgp3pEP/EB/cykkB8//3+/l11i2eQaE236x2zsD2ZpeEGr5h6Zl6nvo8EK9cPr/kAJycF5pU8 4rnFoLXo48+ERMRE/otXsAMp9Paw== X-Received: by 2002:a05:690e:13cf:b0:65e:a838:e9d1 with SMTP id 956f58d0204a3-6636e6711d4mr4363227d50.59.1782329268360; Wed, 24 Jun 2026 12:27:48 -0700 (PDT) Received: from Dev-Null-MSI ([2a0d:3344:52ac:a808:98a4:4381:be45:536f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6647f926750sm329747d50.12.2026.06.24.12.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 12:27:48 -0700 (PDT) From: Yousef Alhouseen To: Srinivas Kandagatla , Amol Maheshwari Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yousef Alhouseen Subject: [PATCH] misc: fastrpc: release pending invoke refs on rpmsg removal Date: Wed, 24 Jun 2026 21:27:00 +0200 Message-ID: <20260624192700.5388-1-alhouseenyousef@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fastrpc_rpmsg_remove() wakes pending invoke waiters when the rpmsg device is removed, but it does not release the send references taken before each request was submitted. Those references normally disappear only when a DSP reply arrives, which cannot be relied on after endpoint removal. Walk the channel IDR during removal, mark in-flight contexts completed, and schedule the send-reference put while waking waiters with -EPIPE. This prevents disconnected channels from pinning invoke contexts indefinitely. Signed-off-by: Yousef Alhouseen --- drivers/misc/fastrpc.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 90281859a..bfdf8ab6a 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2580,30 +2580,31 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) return err; } -static void fastrpc_notify_users(struct fastrpc_user *user) +static int fastrpc_notify_context(int id, void *ptr, void *data) { - struct fastrpc_invoke_ctx *ctx; + struct fastrpc_invoke_ctx *ctx = ptr; - spin_lock(&user->lock); - list_for_each_entry(ctx, &user->pending, node) { - ctx->retval = -EPIPE; - complete(&ctx->work); + if (ctx->sent && !ctx->completed) { + ctx->completed = true; + schedule_work(&ctx->put_work); } - spin_unlock(&user->lock); + + ctx->retval = -EPIPE; + complete(&ctx->work); + + return 0; } static void fastrpc_rpmsg_remove(struct rpmsg_device *rpdev) { struct fastrpc_channel_ctx *cctx = dev_get_drvdata(&rpdev->dev); struct fastrpc_buf *buf, *b; - struct fastrpc_user *user; unsigned long flags; /* No invocations past this point */ spin_lock_irqsave(&cctx->lock, flags); cctx->rpdev = NULL; - list_for_each_entry(user, &cctx->users, user) - fastrpc_notify_users(user); + idr_for_each(&cctx->ctx_idr, fastrpc_notify_context, NULL); spin_unlock_irqrestore(&cctx->lock, flags); if (cctx->fdevice) -- 2.54.0