From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A43239DBE0 for ; Fri, 26 Jun 2026 05:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451205; cv=none; b=pOeIwdw1fXmWsbL5wElfyQuibwlIK8xH6TIsk0NI9d1+3jdx5CHN6C6qNNvZlZxBZlj2wUYUdyoMhHoly2xv2vc5lVQQR5mCUTcVappMQNNwWOm9JQxUUyNhX9JE7IX9F0kxlLZtTZY5J2Lj4kcjJCRt4kBdKKhvlGDsa6/OKLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451205; c=relaxed/simple; bh=UClJ5eXS2m0FRvLY29NXZUCpauTf4W4y2CWIGqUPbgs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S4GjA5PCs2flCjjtUQ+fHpAQ/HXlqJTV4nl1ritszSphoF2KplefZWjutm2G91NAnImbyY515PlOaWu5Tysa5eZzqoK3XOI12k+SGV/95BqtmxTXr6fDRiZWnKJL3UIn81hKYyMTILgam7H7DF+W8ZWZ1mXy8uZDFn+hRYJ7oxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=isBRxxXH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AWPJwt46; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="isBRxxXH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AWPJwt46" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65Q41Ubi3787604 for ; Fri, 26 Jun 2026 05:20:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MrKfNX4GSc054ZzYRhPbAU2c3Dx5iXaNm/R6/b5iQu0=; b=isBRxxXH58/W8qhG J4u/zr4fhvmFcltDOqqlKizZEaYC/431/E1U01FhrwLSjRTcgP8dzzGVAok8ODpR AjKC8hc04dHjtnMsCGI9nujGfy5af8G5HkwygVKVK3kiPHFcxPrMu9Gif6h7Izdo djEMTDIHueXx/H1ozzBHvNdRDbFCDPJb5pWCK3t3xwca5MTqgOalJAnDHuCMUt3J BffDupr8NpxThsPE4D/BR406z/JyFJHGQPRFUIGAD3/5rzMwOBZ+6fYFY5qXNi3c 9yyTRolfjczM7BnhjCblMnNPLF6oeDlZ349zz9FTrmBFmP4jNKcLUYoBcTCyyCfQ 8K8oNg== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f1j1nga8a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 26 Jun 2026 05:20:03 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-30c93c21752so54485eec.3 for ; Thu, 25 Jun 2026 22:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782451203; x=1783056003; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MrKfNX4GSc054ZzYRhPbAU2c3Dx5iXaNm/R6/b5iQu0=; b=AWPJwt46QFPJp07JQWmLrLGCT+dr7+zWeZR9WfYNciizi9NR1F3rV4uqQgL8kxKnxw 8IebQcYJaNOXeasrsHcKpdhWOwSZk+9uL05lVQp4gQ//doM8hjUjQZJT6pWGa3lNBeBR 0whgw5jrdtTyVRrvh50UFs26tPfoo72kfmY1pDL4GUJI1X3Z5jXIemPh9rd1iMgWUTI8 dusANjNwm8jZkS6zVGERVOZNUrl5lwQwOc90apuvlpq8darwd/M2pL+Y5wzp2Zb70Kh1 619KbCD+4BmZ4olxaesoWHnoNaToqEni5fhyG054zd1NgXvUzrDGCpbEM7eGjI0eS+D/ PuNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782451203; x=1783056003; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MrKfNX4GSc054ZzYRhPbAU2c3Dx5iXaNm/R6/b5iQu0=; b=LcidfMXa008XLakQ1mZwSKp++CU17XWadQEc1wvPs7SpzJx6MQkdRAKM1QdgdZ6lDv W/UKEdEt71uyzox50do0hX21YTOfEggN/s0fTWRSzLadkfiqBri9AIHIv1KqFQxZMsCx cWdCYpXBe1QhVBY/WWsUtGYxop0Bwxqjd+RWp5XJomEtAaE4heKH89UDw9e9iUxkzTyt XwffnE6Mr8JXjxiu4l9RMY0TQkVJcvfFP5VlLtsDt7hZtlZvKASSnq59GEK9/uQ61rRH UZQK5t1g10CTVyyXFf9czpNvGMn8DxXJ5SKoL7otuMTNur/2ZfWu6HI+s9OJ+bRmbtZC OEzg== X-Forwarded-Encrypted: i=1; AHgh+Rq6ujJ75DY56GnmDkC89p6IbGIhlpIJcVOKQYINqrAyrvlW+WdrdvCQWaoev14Aw7RbKdVgCxE1XkjCQv8=@vger.kernel.org X-Gm-Message-State: AOJu0YyAN5OrJGbOAKXFC6U4mr3RQsvML2eLgBpN7bTaBWlTQRNXDdRr 3nJNwML12AU/IsdrVGOhlKc7DG+YBUGXkE0Tvv5Phbkfl1pKx0/2iDM+X3Tw99xgmvSuH7axD/I /pT5xClCq3UC/5LkQapnfxTGALdralKHVkozTq3UY59u6R+yvleApIuI5fJ7efx6FcxrFz5KiMv XKfw== X-Gm-Gg: AfdE7cmNLvmgr0W2NU+U8ZWvIzl+NnYPgoaC/QA+1Ma5Xz227Rh9F2d1XJR83gmNzsM FtQKmxwhhJvYgTzVtlYpVqE5YSFZPe4JouDjrirzuVPaQDQj2EcH+M9t8zWGbjGUIIchParb48+ /3ey0aZf2E0EmG/xoJ7eubKrOcyr488LgENNpPDki/USR5HeoXIYU3cwcsQIswCjT3cWetoAlQx 0gY34BU4xFZvw8mUBYNEpnkw3rPnoU7Afm1J96ySIkI2aW2W2FFfiugAHKBuL3WO2VozXaqGXF7 EbDxjRCjuICKgLve3vgj3GGwCfxq+MuQ/LFc0f9bHOVzXjuNPOuBuK7pB21SYsQgSWhAUkxl4lu XdnQASbLeOacWmeVtJ5o8VJzBPyrlMs6lQcEKpeeaE7GG+EZQIIlP2/rm9w== X-Received: by 2002:a05:7300:6144:b0:30b:c021:5045 with SMTP id 5a478bee46e88-30c84ce60f7mr2112621eec.5.1782451202851; Thu, 25 Jun 2026 22:20:02 -0700 (PDT) X-Received: by 2002:a05:7300:6144:b0:30b:c021:5045 with SMTP id 5a478bee46e88-30c84ce60f7mr2112610eec.5.1782451202274; Thu, 25 Jun 2026 22:20:02 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c4ca240sm14345291eec.4.2026.06.25.22.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 22:20:01 -0700 (PDT) From: Zijun Hu Date: Thu, 25 Jun 2026 22:19:55 -0700 Subject: [PATCH v2 10/12] Bluetooth: hci_event: Log error for HCI reset status error in hci_cc_reset() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260625-bt_bugfix-v2-10-93396a6f7d5e@oss.qualcomm.com> References: <20260625-bt_bugfix-v2-0-93396a6f7d5e@oss.qualcomm.com> In-Reply-To: <20260625-bt_bugfix-v2-0-93396a6f7d5e@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Rocky Liao , Bartosz Golaszewski , Ben Young Tae Kim , Balakrishna Godavarthi , Matthias Kaehlcke , Tim Jiang Cc: Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.3 X-Proofpoint-GUID: H8hPBvMoaMGXgObgN0548XouiIWLlWJv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI2MDA0MCBTYWx0ZWRfXxC437CvdZr31 EI+IV1PHPCBVsh60HXtDc6csgT+bt6pDozxPF7RDkpoTY6kqF3pOs4rKF/Pn8blyyYyYki6WCnj mGvsaLpd1bl14PBPT7UUBvMNDqplmrg33NZgBz2wt2UetY83dCyTNqZKg0Nn/DI5ECFcoPaYecc vnQmKVKfH+Z1HSv72TMofy55TY08VVI3aNmgk+xHF9iAdCKDJ+bz9wToi+1lgSDY3pYCwem2o5f 3vgI/4A4+cRlJEtJO6wQTXfLDEja6bQZ0Kb4XeC6d+EFU9AEnQWAwokH2BQ5fxn/VtnHAyAFQQ3 J1ciBeCX5iNpOpYS31i/9pEpPaHbCZITsX6dIRyU+cWaBlzdkEWMnCFb4n/m0gTnbeYOGdqNxGZ U0iDFH9u+c+xuD9UHM6+7FmFH2zpzxDhGlXVgcn48U5uGVHiMbo42ahrrGX6LFlyAaoFPgouseh 6JVn7snFmUuVn2IqsdA== X-Authority-Analysis: v=2.4 cv=W+cIkxWk c=1 sm=1 tr=0 ts=6a3e0c03 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=_kdk9pxaj2Ve_5tGLFAA:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI2MDA0MCBTYWx0ZWRfX1f7m5YWJWsnh Zog0PVsrA1kbI15Q0dJxtEq3UJ0xHVUx+y+V+dWJN+WusGuPo5cScoDcKqEPdhMuYHPPnJRJPSm Ksm03FI3dBBaEMYFW7GWtHDZiVXo6YQ= X-Proofpoint-ORIG-GUID: H8hPBvMoaMGXgObgN0548XouiIWLlWJv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-26_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606260040 HCI_Reset is a critical command, but hci_cc_reset() uses bt_dev_dbg() to log it, so a non-zero error status response may not be noticed. Fix by using bt_dev_err() when a status error occurs. Signed-off-by: Zijun Hu --- net/bluetooth/hci_event.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index b6d963ce26d0..a90d2c6a6e59 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -269,7 +269,10 @@ static u8 hci_cc_reset(struct hci_dev *hdev, void *data, struct sk_buff *skb) { struct hci_ev_status *rp = data; - bt_dev_dbg(hdev, "status 0x%2.2x", rp->status); + if (rp->status) + bt_dev_err(hdev, "HCI reset failed (status 0x%2.2x)", rp->status); + else + bt_dev_dbg(hdev, "HCI reset succeeded"); clear_bit(HCI_RESET, &hdev->flags); -- 2.34.1