From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 482523E317C for ; Thu, 25 Jun 2026 12:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391235; cv=none; b=SBSsEViDpdmZmL7vqcw14azv/PxwWVPyGmBuT0/Maw9mvJG+Dd6b2zrqxKSEPg+L4vjib1ZVhZlk67NQxFvexJ3dkwoCQVof/ZWNIJM95TgkvDUP2nj1HiiQri7UHbvlz0eaPFfkxj1UHSHsEpxyY5uww0lyPO5VM7elXCM2Fbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391235; c=relaxed/simple; bh=yx9hawI83xM0bKBVn9h6tWl1wS9JbU7rfhE200y+lzk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RaIWyU63pXbSdr5oW3br51O34KAvWRz9BFfCQucXBGpKP1xV19P2rXYgLbp4jyv7zg7KH/0sFHLjVp7zkPBkjGY6Q5JU8xALKopjhrEdIwOODE7e1nLoPwPhk72tHQsLSMA635xWv4VdvvIk4uhgzrqIGWI8Lh153B9dVGigzKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=QuO6NzsJ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="QuO6NzsJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1782391232; bh=yx9hawI83xM0bKBVn9h6tWl1wS9JbU7rfhE200y+lzk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QuO6NzsJg0Ri8GrHWp9e4CpYdoCxMdEeArdOGpyuTP3UDN3u8o7syn7QPMjEhCELO DSDrdfgpoZqxqs/ub2Qhg+0ksbz67mH/fvP9v0SFtCkwWCJ/0E6LcguqjdwVwQazZD /JRvR69WQmFCD5AzwrzgJiQwCvBPKwO+auOqJ97GmchZ/VFDoq16PAV0HiULOyHRwm m5e43MqUnPKJPn8Q+rqaPCwvwZDNaqOgsV1ctwfTJRVg9txzNvRLj/b5vBhz83DDLN +S1BtkoijFGLo5XPKmhf547iF9Xl2pu7xdFN0CPLbVWu0WGqw3GhVaKyrZuMu5pViv F6dA5i4TfCnlA== Received: from fedora-2.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 409F517E0F44; Thu, 25 Jun 2026 14:40:32 +0200 (CEST) From: Boris Brezillon Date: Thu, 25 Jun 2026 14:40:30 +0200 Subject: [PATCH 04/11] drm/panthor: Fix potential invalid pointer deref in group_process_tiler_oom() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260625-panthor-misc-fixes-v1-4-b67ed973fea6@collabora.com> References: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> In-Reply-To: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> To: Steven Price , Liviu Dudau Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Frattaroli , Chia-I Wu , Karunika Choo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Boris Brezillon , sashiko-bot@kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782391229; l=1197; i=boris.brezillon@collabora.com; s=20260429; h=from:subject:message-id; bh=yx9hawI83xM0bKBVn9h6tWl1wS9JbU7rfhE200y+lzk=; b=B9AVovW/1s9Oo6T9DGL+D5IUQ+HUDTytIJLf7HQnRTGXeOBMYzqhAn3m0FgJyNVhMFNXRMFuh p2GEwfQfuXyAKNzmFfvuFFyxasqD+6I44h1o6geeA8EmBBBFmvqfNv1 X-Developer-Key: i=boris.brezillon@collabora.com; a=ed25519; pk=eN+ORdOgQY7d5U+0kA8h5bf67XdD8bhKbjD/TCHexSY= If heaps is an ERR_PTR(), panthor_heap_pool_put() will deref an invalid pointer. Make sure we set it to NULL in that case. Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Reported-by: sashiko-bot@kernel.org Closes: https://sashiko.dev/#/patchset/20260625-panthor-signal-from-irq-v5-0-8836a74e0ef9@collabora.com?part=2 Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_sched.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c index e97f29469d28..8fd4d97b062e 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -1600,7 +1600,10 @@ static int group_process_tiler_oom(struct panthor_group *group, u32 cs_id) if (unlikely(csg_id < 0)) return 0; - if (IS_ERR(heaps) || frag_end > vt_end || vt_end >= vt_start) { + if (IS_ERR(heaps)) { + ret = -EINVAL; + heaps = NULL; + } else if (frag_end > vt_end || vt_end >= vt_start) { ret = -EINVAL; } else { /* We do the allocation without holding the scheduler lock to avoid -- 2.54.0