From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF7B3E44F4 for ; Thu, 25 Jun 2026 12:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391247; cv=none; b=HC2IM38IgcbuJmKES445iAgXELYJqGv85biHY34J+lyJ/2Tbl5MZJRkdldWt/rTYwpuGAWMmfoBLy0b4Pw5wUFG71bRJySaiOFSB8Yv+tNl5JhuS3eLRmJWbCbupjBajT6xUm5gV3NDOu5ttzf9QA280SDbINQOH/BU0C65K7yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391247; c=relaxed/simple; bh=3Ft9dGdmUtcV/N1tEFG7N6nAk5JOgANkCn64VS1VOCw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CLocufZ0a0bjyjHJvykrW6zfvCV5j8cJknbsMDa8hPrTqZ1wbKHVhg8zuF4ovES9L3Ko5CPsQXG6UQwFY0Dhaw/yVPAZqZul2G4609GKKNnGS8UrT0bVkd5giQ6RwDQgjPjM9hZ0v4e0XMwKX7Z/2dj+6LSBORdtxQEk0gGTOw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=STQ1hlJN; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="STQ1hlJN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1782391234; bh=3Ft9dGdmUtcV/N1tEFG7N6nAk5JOgANkCn64VS1VOCw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=STQ1hlJNv06ibMnr88XCND/m9AW9X0LXVfltBK2PGiPIPo84lPDCIKH/Jq1PnNMmv ig3FJUYOCrmfAevVVjbTCTVaAvJFSiSLQNNyFEiUjR3TZNkr6qz8oFuNgNoWCvMstb a3y5WEgiLkYCNKZv11v24cmxsZK9vJRUc3YXsQDG9XKCIryKLX1mf6WZNqfaOZMkMS NlgBKqZN+Qe55wcup80Zp7GQp44x5iofWM59n+uTXivZI8XKo3TRfBBSApbyAoOQq+ FyGxGgjmAJHyJZUQ8BneyQpdOISp9kxECOPYCeH6Dn2OEQD/kyFYi9W6plIAFWB64E 9RZcjmZXXZ6IQ== Received: from fedora-2.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3E5C017E120F; Thu, 25 Jun 2026 14:40:34 +0200 (CEST) From: Boris Brezillon Date: Thu, 25 Jun 2026 14:40:33 +0200 Subject: [PATCH 07/11] drm/panthor: Fix panthor_pwr_unplug() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260625-panthor-misc-fixes-v1-7-b67ed973fea6@collabora.com> References: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> In-Reply-To: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> To: Steven Price , Liviu Dudau Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Frattaroli , Chia-I Wu , Karunika Choo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Boris Brezillon X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782391229; l=1195; i=boris.brezillon@collabora.com; s=20260429; h=from:subject:message-id; bh=3Ft9dGdmUtcV/N1tEFG7N6nAk5JOgANkCn64VS1VOCw=; b=OAtnZpl2W0+4OUTW2Wy+7vM88OFOhC1COkQEm5zGdMsohjPYC9u85Zl1n4O1k5Jlv8+sklnEY ZY1yDDZ/FRSBMnucsJtsD9tVaEuD4foS2BlAIwQ3kIGItrlz7I89jty X-Developer-Key: i=boris.brezillon@collabora.com; a=ed25519; pk=eN+ORdOgQY7d5U+0kA8h5bf67XdD8bhKbjD/TCHexSY= We can't call panthor_pwr_irq_suspend() if the device is suspended, or this leads to a hang when the IOMEM region is accessed while the clks are disabled. Do what other sub-components do and conditionally call panthor_pwr_irq_suspend() if we know the PWR regbank block is accessible. Fixes: c27787f2b77f ("drm/panthor: Introduce panthor_pwr API and power control framework") Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_pwr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_pwr.c b/drivers/gpu/drm/panthor/panthor_pwr.c index 7c7f424a1436..090362bd700b 100644 --- a/drivers/gpu/drm/panthor/panthor_pwr.c +++ b/drivers/gpu/drm/panthor/panthor_pwr.c @@ -453,7 +453,8 @@ void panthor_pwr_unplug(struct panthor_device *ptdev) return; /* Make sure the IRQ handler is not running after that point. */ - panthor_pwr_irq_suspend(&ptdev->pwr->irq); + if (!IS_ENABLED(CONFIG_PM) || pm_runtime_active(ptdev->base.dev)) + panthor_pwr_irq_suspend(&ptdev->pwr->irq); /* Wake-up all waiters. */ spin_lock_irqsave(&ptdev->pwr->reqs_lock, flags); -- 2.54.0