From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0EE33955D6 for ; Thu, 25 Jun 2026 12:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391248; cv=none; b=fJlRUcJ03T/HZNvYI5JuLfF/6zkPGHwGSBryUg57QLQXzyiRitZ82wwSgL6LS0VafWv2Lo12KiCV73ZSufS0htzHopoIoASXnXmPrRGR0eR+K5a6SSSSGTnVgBxneuEZwap9yKoQrcYImUHT6SV1Kk0HQ3iE5kgWrvCQ9pwzDc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782391248; c=relaxed/simple; bh=ByXPHeUxTLvHTIsy8GQMZTZezTDoNQPmI6yOuDE2RoQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TBOIL6ioAHiLz0aH6YfQdqGjznR93x3y5225rbK6J3R9VRTWBcH/N0PierbQ77VqVPnIsBbNGC/ZZC9/A9MOogmy+KN5kcWr4NdhOUA5NG/FEM+rhL2ISGO0xLtCKEZSD5X0SWVWtkGMaa+/U+jkcMh5rm/X3IOkA9EDfrkjnQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=FpOWn3Kf; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="FpOWn3Kf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1782391235; bh=ByXPHeUxTLvHTIsy8GQMZTZezTDoNQPmI6yOuDE2RoQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FpOWn3KfrbGjxZbGWS2oGmL0NSno+rqDxWyAJE61i7Xd3F0jp8Tzl4ieNdqwTsKG6 s8M8Jmk7FNf437jN5OqN1UZw8ZEbAOHCwB52lNffF8twbG4y/fDRjRLVtX+2FDeAcm PLA9eSCmLiiuZzhFOnfUF4OdJeMkpzgO3H07uzES5WlBOCqN120QsojrgqefuicLoO x2Z4ebPDOeDzqy+RjQVdiRho7W/MrTox4klAqh94z5KyF3ABCrQxUP/moHlJRA1Ptc nzx/c3oV/++lhVghUSyh3Vi/Lpr6/ILLNcYxsK0Ab2jzoyoSCpc0XIeY8EUbpc7gbi r8KlJB7U5zfdQ== Received: from fedora-2.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id D714217E0C88; Thu, 25 Jun 2026 14:40:34 +0200 (CEST) From: Boris Brezillon Date: Thu, 25 Jun 2026 14:40:34 +0200 Subject: [PATCH 08/11] drm/panthor: Drop a needless check in panthor_fw_unplug() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260625-panthor-misc-fixes-v1-8-b67ed973fea6@collabora.com> References: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> In-Reply-To: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> To: Steven Price , Liviu Dudau Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Frattaroli , Chia-I Wu , Karunika Choo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Boris Brezillon X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782391229; l=921; i=boris.brezillon@collabora.com; s=20260429; h=from:subject:message-id; bh=ByXPHeUxTLvHTIsy8GQMZTZezTDoNQPmI6yOuDE2RoQ=; b=UWVnsI7K0mC9km3s9+c3xnOcLDs3gSmqkrcagWmkkCUQpQL5HGT3Z7z7YEB2lWTSI80Blhh1M Xwf/tx/Sg+UAahNgpwxWMtJp8ZdHPeRvJzAVtzZEywD2yr327746C3e X-Developer-Key: i=boris.brezillon@collabora.com; a=ed25519; pk=eN+ORdOgQY7d5U+0kA8h5bf67XdD8bhKbjD/TCHexSY= panthor_fw_unplug() is only called if we at least managed to initialize the IRQ, so it's safe to drop the "is IRQ initialized" check. Signed-off-by: Boris Brezillon --- drivers/gpu/drm/panthor/panthor_fw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c index 986151681b24..4fbddb9e18c8 100644 --- a/drivers/gpu/drm/panthor/panthor_fw.c +++ b/drivers/gpu/drm/panthor/panthor_fw.c @@ -1279,9 +1279,7 @@ void panthor_fw_unplug(struct panthor_device *ptdev) if (!IS_ENABLED(CONFIG_PM) || pm_runtime_active(ptdev->base.dev)) { /* Make sure the IRQ handler cannot be called after that point. */ - if (ptdev->fw->irq.irq) - panthor_job_irq_suspend(&ptdev->fw->irq); - + panthor_job_irq_suspend(&ptdev->fw->irq); panthor_fw_stop(ptdev); } -- 2.54.0