From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA8411D47AC; Thu, 25 Jun 2026 07:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372281; cv=none; b=Q7bLf0XuY7xjjcRKl/3nR7mHsMmL6aSaKwdi7UHD/ZZFHm3SU1fNhkHVibw4/hQZxDlF8SxQkVwe0EgYl41AsLGUDe9Qr73eH9GL6WtaOzNTwF51ax7561Rmgdc7q84XhSblDIvIN3dZhmVMzTdQaBr1afUnBwzBOD6NEmkxKIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782372281; c=relaxed/simple; bh=tgADfh0EdrTzy7lzOlJwRcq+VaeN/ikekakGmu4wCkU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r/2y8luSLzRzaCTKhUedWGT+bSsZObiTA1g55DjcuN9h0wWkzKpU/D6G/JvCXP7S01IpjFs+E7TIcxItm+mZ7UEbgtKtlg3eS25NWLZzt+BFyb9qk0YhIHNFZfTFXjESI3YwPYyCBjfXTcysUahWb4YgzbmMihLgQDpMWh0MC9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C4E3+3x0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C4E3+3x0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 500E91F000E9; Thu, 25 Jun 2026 07:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782372280; bh=szlf9WMEbP6Ff6qejR6ZQRZMLqe4N8GVxyJBVP9cdAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=C4E3+3x0VOSFH0dFkeBFT8LkX/oEbOZWh8QB6g2J+48cJA86FJuWUw/PeyuQdKB6l 5U3PhXyhJvCXBjIDYLF2FFD2C+RwMKtWXlRlqc5HhNFqDC9XugMnRhytbEfpAVxMp8 xTb0sAnGKkZM0TTrY2qRaK1Ug1stzt5Tn1+/o8j0v/afKTx7jQX9ZEG4xIHEnvk2FS jemzgjl/9q5d7vNnpS+7VZRkwlxVwLJWpFjPhbNJHj6L+r9oDyfWaupf6n34P2rXsG GJIZJqyhyBH/kOvsn7uXSsaExB/M/ejYuhEp09nLOVgZY3/vD46S2zB58Pjc2tPUDp YOfJdJjtfIruA== Date: Thu, 25 Jun 2026 09:24:36 +0200 From: Krzysztof Kozlowski To: Jie Gan Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: arm: qcom,coresight-tnoc: allow arm,primecell-periphid Message-ID: <20260625-strong-daft-pudu-21471f@quoll> References: <20260624-fix-tracenoc-probe-issue-v2-0-786520f62f21@oss.qualcomm.com> <20260624-fix-tracenoc-probe-issue-v2-1-786520f62f21@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260624-fix-tracenoc-probe-issue-v2-1-786520f62f21@oss.qualcomm.com> On Wed, Jun 24, 2026 at 05:49:25PM +0800, Jie Gan wrote: > The TNOC device is an AMBA primecell and may carry the standard > arm,primecell-periphid property, which is used to supply the > peripheral ID when it cannot be read from the device registers. > > Reference primecell.yaml and set additionalProperties to true so the > binding accepts arm,primecell-periphid along with the other common > primecell properties. > > Signed-off-by: Jie Gan > --- > Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml > index ef648a15b806..9624fc0adfdc 100644 > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml > @@ -32,6 +32,9 @@ select: > required: > - compatible > > +allOf: > + - $ref: /schemas/arm/primecell.yaml# > + > properties: > $nodename: > pattern: "^tn(@[0-9a-f]+)$" > @@ -78,7 +81,7 @@ required: > - in-ports > - out-ports > > -additionalProperties: false > +additionalProperties: true Nope, it is not allowed. Explicitly mentioned in writing bindings and all DT introductory talks by me. Best regards, Krzysztof