From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814383A05C2 for ; Thu, 25 Jun 2026 03:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782356661; cv=none; b=UzCU7x3tGX7sC1+XYGu3+VQ3/GZLpZQWlFz9lDlZwT3DAtzv5AaxHcT9AwZuJ8QafeRkO58r92yaUZCo/loNXpcJpw0xzp7tyqxG3i0FdY9JxM0Qh8d0K9yEb8RSFZHOaj8Io9iBAOEVEyrZGp15lfJ2aynoo2V7JI2BdEtKnH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782356661; c=relaxed/simple; bh=RTTzSBSmJ8UBlFSKsI2rAOSUlvIoiiZHAOajT3/x5yk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=na39ngEHqhCuGCYAK0N1XCJ9ATVKtUrp0MlM5BRU2FQmNDGiUXZygfFzRqzslTISSDEyagi3zHmzYdogXtcjASdwnOdEoJSHFJiARYU7Au4pbPLtVuorLZ0VPWRYCJNN6TZduLqhdx7C2PNLtM+HqTXQpiifTfw9nIhXjzVhKns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.140]) by APP-01 (Coremail) with SMTP id qwCowAC3Usukmjxq41EkAw--.38511S2; Thu, 25 Jun 2026 11:04:04 +0800 (CST) From: Pengpeng Hou To: Wolfram Sang , Tommaso Merciai , Alexandre Belloni Cc: Frank Li , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] i3c: master: renesas: reset xfer status before each wait Date: Thu, 25 Jun 2026 11:03:57 +0800 Message-ID: <20260625030357.87402-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:qwCowAC3Usukmjxq41EkAw--.38511S2 X-Coremail-Antispam: 1UD129KBjvJXoWxXFWrZr4fXFW7Ww48Wr4rKrg_yoW5XFWfpa 1UGr45tF48GF4vgF4UCr93Zas5A3W5KryIka1Sg3Z5Cryvvr1qkF1YvFWSyr13uFW8Jryj yFWjkw4UC34rAFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkK14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWx JwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUjMqcU UUUUU== X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ renesas_i3c_wait_xfer() reinitializes the completion before queuing a transfer, but it leaves xfer->ret unchanged. After one transfer completes successfully, a later timeout can therefore reuse the old zero status. Reset xfer->ret to -ETIMEDOUT before each wait, return the transfer status from the wait helper, and propagate it from DAA, CCC and private I3C transfers. Signed-off-by: Pengpeng Hou --- drivers/i3c/master/renesas-i3c.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c index f39c449922ca..7f123cd72cdf 100644 --- a/drivers/i3c/master/renesas-i3c.c +++ b/drivers/i3c/master/renesas-i3c.c @@ -433,15 +433,18 @@ static void renesas_i3c_enqueue_xfer(struct renesas_i3c *i3c, struct renesas_i3c } } -static void renesas_i3c_wait_xfer(struct renesas_i3c *i3c, struct renesas_i3c_xfer *xfer) +static int renesas_i3c_wait_xfer(struct renesas_i3c *i3c, struct renesas_i3c_xfer *xfer) { unsigned long time_left; + xfer->ret = -ETIMEDOUT; renesas_i3c_enqueue_xfer(i3c, xfer); time_left = wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000)); if (!time_left) renesas_i3c_dequeue_xfer(i3c, xfer); + + return xfer->ret; } static void renesas_i3c_set_prts(struct renesas_i3c *i3c, u32 val) @@ -687,7 +690,9 @@ static int renesas_i3c_daa(struct i3c_master_controller *m) NCMDQP_CMD(I3C_CCC_ENTDAA) | NCMDQP_DEV_INDEX(ret) | NCMDQP_DEV_COUNT(i3c->maxdevs - ret) | NCMDQP_TOC; - renesas_i3c_wait_xfer(i3c, xfer); + ret = renesas_i3c_wait_xfer(i3c, xfer); + if (ret) + return ret; newdevs = GENMASK(i3c->maxdevs - cmd->rx_count - 1, 0); newdevs &= ~olddevs; @@ -800,9 +805,7 @@ static int renesas_i3c_send_ccc_cmd(struct i3c_master_controller *m, } } - renesas_i3c_wait_xfer(i3c, xfer); - - ret = xfer->ret; + ret = renesas_i3c_wait_xfer(i3c, xfer); if (ret) ccc->err = I3C_ERROR_M2; @@ -815,7 +818,7 @@ static int renesas_i3c_i3c_xfers(struct i3c_dev_desc *dev, struct i3c_xfer *i3c_ struct i3c_master_controller *m = i3c_dev_get_master(dev); struct renesas_i3c *i3c = to_renesas_i3c(m); struct renesas_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); - int i; + int i, ret; /* Enable I3C bus. */ renesas_i3c_bus_enable(m, true); @@ -854,7 +857,9 @@ static int renesas_i3c_i3c_xfers(struct i3c_dev_desc *dev, struct i3c_xfer *i3c_ renesas_set_bit(i3c->regs, NTIE, NTIE_TDBEIE0); } - renesas_i3c_wait_xfer(i3c, xfer); + ret = renesas_i3c_wait_xfer(i3c, xfer); + if (ret) + return ret; } return 0; -- 2.50.1 (Apple Git-155)