From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD8071D8E01 for ; Thu, 25 Jun 2026 03:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782359195; cv=none; b=onPGGkhhfJNZdN5iMIPqAL9x3JT2e1tCujM6AtKBH5y0AB9/U2CkWmzzTuF25bHhWU3UWWg+zABydLbKWdDtnk2eH2/b6hGTUrjpEddd2r6ekC92ZjVJi5VNSIxCdbPSLth8KQSqCVgc728/VWX0YMLqKAqo3ANOmjQaqHxXwCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782359195; c=relaxed/simple; bh=bgLvYLS/8f1sWI4gGtc2yAahAEaNsKCXrycvVybMVlA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ANSU/BEqoOMSCWVeLpFLnT2vIPQvkcvJh2lKSPTILPSSnjR1fdrj+qFWTGBj54QniNpJ3GRvS++9OaiOl8jLVKJnoETiv/KxXdQH+ZKrq5qvUcv0apqFfaPN0Gmwe42MzsScq9gwVubBKgJB2PPug4rSfYc8/2GqfcN4wwRNR6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c2WgF07B; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c2WgF07B" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-c0840dc2859so223542366b.1 for ; Wed, 24 Jun 2026 20:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782359192; x=1782963992; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fdSm9PR81lhsu8o5UUFEaL/HA7IWicBe0MyvL3qf01Q=; b=c2WgF07BxJUyvZzqyPFELGq280ymsB3SvrLtGyurVngo/oacZ36AevNjBsh7nCDTHP LOnWHs/jmGUEHda2gBmJxFodTMqu3Japtfpoi5CsWi8f8gWGaxLysTF7Jv90fgQaRnrE xmKqaweMvozrvratGL/c2W26h1Gor+sgxQ3cx+9LJnOQOnRd2vNBXfcwVYS/Ua2N3Ppc hi4xB9iFQGRP2GmdyNufhwXtk5ftSRSgAEr0b5XjAIhfL4XeXHUwefgwCjvFO7usbIkM iv7dAZpI3lMetriIyryccInVBy94v2zx/FIOcpuul652RHlgmp1MA7yloYG5A29jHrzb ISNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782359192; x=1782963992; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fdSm9PR81lhsu8o5UUFEaL/HA7IWicBe0MyvL3qf01Q=; b=KL82sgO5bOA4HeNT9TV6TmwCBNrB/RGjq9WE9AqgDvPbpPB+9UTdEUaWGW1STaxmzD TPwcDdCeUlDZVbVK5/sgGA3K6mv8wmtssWbpwqtYnaEkEa8fDRmM1Vq6SgtKr3TXVuns aXPQkiT0auB1WZr8wjv8PRK0tyoAlVKdmQVtsUps/3wELjq9C626G7b5Pf1C3hQFCvZV z2XyCROgfWp5/1wD+oDFqRyR/gF5MVeGuSPWUYlgAXJIMRFzjZQP5aihTY3LMuxeDYGS AtJJztlAOKtcITmwHrZszCqAGgDK9hyOxix/D+JJM04EpBvOt9j3pv1CJ5HnPXM5Z/jv 8F2Q== X-Forwarded-Encrypted: i=1; AHgh+RpyD2ndR+yY84cKg5q7cnxOhE+iYmbxWnpEcbkvfoqFXmMcvU7Ywui0zmKzIxnW7s6pmhWjBCt8Y8L6vGg=@vger.kernel.org X-Gm-Message-State: AOJu0YwW/bVEV22ei7NtvH7bIxcyfftFJnpcvbS4vkMesE1a1X6pBdkE 3vzMk7LHVQWbMsOgkoCrRE7uT1s6vNepCcVRK3KqeuRwfxHLcSu3lxjQ X-Gm-Gg: AfdE7ck4ttdFCpdtVxvEyeWPsGpgXvTHJrIDx1Tpa0Sd/uDnk0HU5+Ec2/ktBdhjG4Z Zmk1yf4on0WSVX6sbTAoYNFj2BCwcwjvQt4bqq+AhIwZHLU/jJO7NGcGZAMVTfDxsDxwkWZjzki YfswPJbtCDvlDufkFSWYiG0yq4G7UPL3lGLOjWBpNZ4AiyicDMWrozaJWd73JpOOsRXkdXqgc+S 6GFQ4ersX+FeXsgRZQS4RaL9PJHZE2qg88KrioWvP6U460GxIF7FBcH2QzfxRZJANcCFfEzPH9O A2A7vbjMZdDS0Y1pqhuvcgn2iwonbWQ2BZsn220DC3spRXG3M4LPsUjYtip0v2eaG/8deCg3UZF 73FolVLuXnqBWv/PBiUb3spTixP0ZJqqC+jD7cjfSUTpg3r1AtdFWmIF+gy4MpLM6NbWzDkYi6n zwI07apUhK7Eg= X-Received: by 2002:a17:907:c8c4:b0:bef:90af:6ff1 with SMTP id a640c23a62f3a-c1205f67271mr25397366b.31.1782359191956; Wed, 24 Jun 2026 20:46:31 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbbe8125sm87909966b.19.2026.06.24.20.46.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jun 2026 20:46:30 -0700 (PDT) Date: Thu, 25 Jun 2026 03:46:29 +0000 From: Wei Yang To: Andrew Morton Cc: Wei Yang , david@kernel.org, ljs@kernel.org, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lance.yang@linux.dev Subject: Re: [PATCH] mm/page_vma_mapped: guard check_pmd() with CONFIG_TRANSPARENT_HUGEPAGE Message-ID: <20260625034629.nmgdwl2c4luwod77@master> Reply-To: Wei Yang References: <20260624082359.2869-1-richard.weiyang@gmail.com> <20260624131457.ac81fbac373f78aa80a516e3@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624131457.ac81fbac373f78aa80a516e3@linux-foundation.org> User-Agent: NeoMutt/20170113 (1.7.2) On Wed, Jun 24, 2026 at 01:14:57PM -0700, Andrew Morton wrote: >On Wed, 24 Jun 2026 08:23:59 +0000 Wei Yang wrote: > >> The kernel test robot reported a build failure on the parisc architecture >> when expanding HPAGE_PMD_NR in check_pmd(). >> >> mm/page_vma_mapped.c:142:13: note: in expansion of macro 'HPAGE_PMD_NR' >> if ((pfn + HPAGE_PMD_NR - 1) < pvmw->pfn) >> ^~~~~~~~~~~~ >> >> The config [1] in report link shows neither TRANSPARENT_HUGEPAGE nor >> HUGETLB_PAGE is defined. Then trigger the BUILD_BUG. >> >> Fix it by define check_pmd() under CONFIG_TRANSPARENT_HUGEPAGE. > >hm, > >#ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES >#define HPAGE_PMD_SHIFT PMD_SHIFT >#define HPAGE_PUD_SHIFT PUD_SHIFT >#else >#define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; }) >#define HPAGE_PUD_SHIFT ({ BUILD_BUG(); 0; }) >#endif > >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE >> /* Returns true if the two ranges overlap. Careful to not overflow. */ >> static bool check_pmd(unsigned long pfn, struct page_vma_mapped_walk *pvmw) >> { >> @@ -145,6 +146,12 @@ static bool check_pmd(unsigned long pfn, struct page_vma_mapped_walk *pvmw) >> return false; >> return true; >> } >> +#else >> +static bool check_pmd(unsigned long pfn, struct page_vma_mapped_walk *pvmw) >> +{ >> + return false; >> +} >> +#endif > >I'll leave it to others to decide if this is the most appropriate fix. > >Sashiko had an off-topic complaint about the surrounding code: > https://lore.kernel.org/oe-kbuild-all/202606240042.ffPsEXVc-lkp@intel.com/ I see this robot reply, but not see the Sashiko comment. How can I view Sashiko's commnet? -- Wei Yang Help you, Help me