From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D8543BD644 for ; Thu, 25 Jun 2026 06:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782369666; cv=none; b=oq+c/QY3blpThubtEeLOv+SqP5gn+LmFeb+wRJW/w5eSMvFEGB+wWFy3vy7T9/YdAMUtkBTmsWg+FWxTqHBTm56RI5GwjUYvvntXImIfAGoOjxyV2avawXvMHsjqaTRRW4tR1eFKX8GSMKg33+surGXBENZe0LvHONXHTO/rd5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782369666; c=relaxed/simple; bh=w7YTcafLdUex7IjMcLigB1eeMOPtF0U+FTdIlfyMc2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YaNVyrE2sXkrwX+DjQGuOEO1ITlis6j8VxHGIpXHfD0Fp/JV72P0adoJIFqcfS1xVtotqbFHJQO7kmRO2dT8/ofbX5I39vJO4LBilQMgiEwIhFoTce4/+GyMiKmvPablkLhf8lOsqqIWmbC0ZLfEEJX2SOuYck1vzV9hXXt0cIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BzGvQc2/; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BzGvQc2/" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-bebb72b845aso401443766b.3 for ; Wed, 24 Jun 2026 23:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782369664; x=1782974464; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RoxZJjVOiXwcjZDwYFG+OwasLzMYbWC1yxc7WvB+JYQ=; b=BzGvQc2/zafBR0WaZOVwk654ZSvZbwR1K/1wDU6BgBcxSjDMSOnpqc0vAzGKsW6l6K uxdvwHb1TWXqU8QiS3HeDpaUBnGURRkucC268VOJvAQ2uuN9Ld65XwcxO2tkz15I8jQQ s9qrfKZDW0RLiyck7mIZ6dnzHGH+nmX7pUmo77pvqHlqb+LF8F3Q6kJAEoa3H40MVcJ9 5K/vZPKLRbw/l0D5IEOZIzmnLZZhX0040LDNeYQ5Zy7k8GhFFWhPzggUz2l5Vx1RrDtJ Tr6vdUIoyJ79dIDyeQJvzA9xgCbfgADk+zkbdgvqHsx0m11DGRvkSVaeWtpCLbVagvqy jd1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782369664; x=1782974464; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RoxZJjVOiXwcjZDwYFG+OwasLzMYbWC1yxc7WvB+JYQ=; b=q0NMNj35yGjuRXhR5yzW10guE+VidY3pz/06SfyoorZwWctSmeiq3Gij07aK+R1st3 MQ1/5VqvCRAaF2gPOacFu/PR9R8zsZ+MxleatzG0ZsprZHOVhDweaB3M0wA9k0TjHVQn Q4T8tsQoAeE359ZpW+qtZin9pdWvQvH7wczHRnFebtn/psQPwXA7aQiqR56zpjZKD3po rzcMO3EgETQNUPHPe/8vqUHd4aF8hIHUMrrqVT7c+rleHI9kOhzXFBmHQx0ZfT4xhF37 ui/YdzJlOJE634YLdNnhA2MTMd/iV6nUjnyS+yCxR/JQH/ZrTVPygBQcl0btSS/C+Xee kBow== X-Forwarded-Encrypted: i=1; AHgh+RqrkW6gJXLpwS2iUzXvu7bqP3mSfubK0PghXnKfp4GinEgV1IgOur85PyGDwUjJjq3QVU1KfL5rN55qpgc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1l7FZPITegtpylxgjIYqnBjnDnpnQWIlhENhggGHCArSDmKq1 2BQSbSUbrYbI80q97zV5szXtp4MT/nsGlW6BpOWgFFDqDLOHOyR+MnVkL8xZeQ== X-Gm-Gg: AfdE7clK19iBY9toouT9+hLuIY18MgD6LimjeyXwmZuySihJKnCAghXpeJmFtI0LBlu 33sYvaiOYJaFhd2lIgkVdx9WOm3m0/coGGsZD/rPdulPjc1ZxjMVrn48AC9wi0KZNv8MKzaKwre 2i9qTUDJSqsODaflE90/HmgyxYTSNWO+L6n85QVXnSwsDeCiTK44cy/5ZRf3MbBXmneCSrVQLfp 3daNq6uVmMQ05whQL/F1CZSZ1seGDbet15Eoa7gkjs4OWGFsqLMGjfTeV8cG3NjMBlLlQ/NDXRy QH6Qt9SGEiKeNfnf6t2tbI+xsC+gT2U2GpdyaNcndVzTRwtTUr6MB7GG5pEuHME8cs58h35oDuL 6Fs39OPh1KOyYSVCKUeI3oB+xcjVL0AXw12r9JOXmUOTwLPIHF0eQN15Os0j8V3O1xtURV/W9X0 zhuyTXsjYEDOU= X-Received: by 2002:a17:906:e10c:10b0:c08:695d:392a with SMTP id a640c23a62f3a-c1205eae8fdmr40097266b.24.1782369663747; Wed, 24 Jun 2026 23:41:03 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbe05c22sm111119666b.39.2026.06.24.23.41.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jun 2026 23:41:02 -0700 (PDT) Date: Thu, 25 Jun 2026 06:41:02 +0000 From: Wei Yang To: Andrew Morton Cc: Wei Yang , david@kernel.org, ljs@kernel.org, riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lance.yang@linux.dev, balbirs@nvidia.com Subject: Re: [PATCH] mm/page_vma_mapped: guard check_pmd() with CONFIG_TRANSPARENT_HUGEPAGE Message-ID: <20260625064102.tcmvrctcqibl54yr@master> Reply-To: Wei Yang References: <20260624082359.2869-1-richard.weiyang@gmail.com> <20260624131457.ac81fbac373f78aa80a516e3@linux-foundation.org> <20260625034629.nmgdwl2c4luwod77@master> <20260624215943.332f1bdcc99a3b85b7df0822@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260624215943.332f1bdcc99a3b85b7df0822@linux-foundation.org> User-Agent: NeoMutt/20170113 (1.7.2) +cc Balbir On Wed, Jun 24, 2026 at 09:59:43PM -0700, Andrew Morton wrote: >On Thu, 25 Jun 2026 03:46:29 +0000 Wei Yang wrote: > >> >Sashiko had an off-topic complaint about the surrounding code: >> > https://lore.kernel.org/oe-kbuild-all/202606240042.ffPsEXVc-lkp@intel.com/ >> >> I see this robot reply, but not see the Sashiko comment. >> >> How can I view Sashiko's commnet? > >oop sorry. > >You can go to https://sashiko.dev/ and search for the email subject. > >Or append your Message-ID to "https://sashiko.dev/#/patchset": > > https://sashiko.dev/#/patchset/20260624082359.2869-1-richard.weiyang@gmail.com > Got it, thansk This one mentioned two things: a. page_vma_mapped_walk() return without check b. whether __split_huge_pmd_locked() would split device-private pmd For a., it is being fixing at [1]. For b., to be honest I am not 100% for sure. If a device-private pmd could be file backed, then this looks like a bug. Balbir, Would you mind taking a look at the second comment raised by Sashiko? [1]: https://lore.kernel.org/linux-mm/20260624065353.1622-1-richard.weiyang@gmail.com/ -- Wei Yang Help you, Help me