From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C89C6386576 for ; Thu, 25 Jun 2026 08:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782377651; cv=none; b=efJxHX6X18I90SqaLtPYz9oKVFXPz8eGtMD472BVY5mILxNfcPTIMlAWXWV9b4eZ2C7jRGdojzPOAcBkFQG+KY5XRpFbJzFG55GMDIeEqv+dLQBFHvVjj3vHo/v93tEinJk2ZcZRABxjTerAWioNzNzGcCu49A0CJkeRUwCXq/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782377651; c=relaxed/simple; bh=07Gz4DVxSchKBz41aocKqPwLf5Q7wYxmqWLTrZ9H6nY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=U1y9TtBAICVvjHcaMOS9GPkuHi8r2kgpZ16Vure9cWj9jAsDxMqqk7N/s0vk84JOA0NdgHrpyEsizRG7Xr0qCVkKo3+1O5GvHOUqHOyGPGECcXeqvfyXfnJds0hhbOrYLCyjDXCa8NtB7LbcSTceu17UPEfyut88izhaQ9t5OIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TeZSIzER; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TeZSIzER" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-46e335379cbso44445f8f.0 for ; Thu, 25 Jun 2026 01:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782377648; x=1782982448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/jDoMmJJU0PpNgF+w3Xx9Gr+Xmtdk7u64RSrEr55CTg=; b=TeZSIzEROk+wXDUJ2H7J9qtITFj/majCzC4RRZwR633P94dRl4K2X4xiaAK7By7ze+ K7DEGTJXoevUXfACUrh94xn6QJW/a9k6IusZA+lUxNCYXYF8S42eYkontmM4rq0Na2aQ VAdzE3UF3hq9AN3CidWOXPvSKb8xj/JDx7dUSbkR9TK0a4z59WyHTnjeoB6VqCsbWJCd waHDjV9/lCOJFuenJhABaW6KNlKJAQTtgSEFSccoL/kpVwQ5UPfl1w/boO/W8vAonLkh N+SyAwoJJ5z6KfqBhkwIIquIKvHtokZto2zPXoQgTZiVHXJCs0z+izxUUJ24lECJRKpq ljPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782377648; x=1782982448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/jDoMmJJU0PpNgF+w3Xx9Gr+Xmtdk7u64RSrEr55CTg=; b=Ric5kIksVGrJ30QQkLQoBWEhPsItZ05z92UZP8nqU2sfaI32bEy5jjz7ghUNVaAhU5 xwsWGqDY68V82WMZhpAoQylyVjE6XzGPC703dXUBjExv1MMYOctEseEd0wuu+3wg2GDj 1pp/c7Ozi+xI5x5+AJAOhXMlvRO6cPw+CUaPrT9oKi5vWRr9U6O+wOYNxLhrqF4Hmy8O /toutEIx6WnRy53qfR8eh/1pfxEHsYNL+U6NLonRCy5c8+ZG+lH/RWNeLtAgYtuI5AhE 12HiG0b17Nbp5JT+dfc5nnjJ6X+fVDTYjlrzEnMl4s9VE6pRgurmNm+VfvkbyXzB4vxd nzcA== X-Forwarded-Encrypted: i=1; AHgh+RoEQClfclvt6a05dDxbLvJ6BNYaTvOiU7OPZaEFf4EvhpJoIL7XIGLgvn5hGgbnWN6Js1qM7IHuLBCyfQY=@vger.kernel.org X-Gm-Message-State: AOJu0YxzyE6f0lzHULb1wm3mvHuNirblFVg56EB1iQxmHXejiRgIJTih DuR5F6O2AC3mskIX06yT9mGh1/W+GXlVw6Qyx3X6c+LEZGFpcHIHwaj6 X-Gm-Gg: AfdE7clAChusUZuiV97UW41DJ2Ktqw+kDrbc37YY4dzH5FWNVDwiuepT7QbXcT+bpJQ OHpxzG51TqH8AmNevIXFqTjheaXefS6rWSvCpEZVyZwUl4dMEyAj6NuKvkULb/wyMss/5u2feWl kA1C1IE2hl/H0wbZ+s6DT6E3FXCyJJMnQllG8EjLL3QQUIs8iONv3LWcZAKOD+GSBnTZEWHkmaX N5V7uUGpx6DPfTiBRDuqOY0kn/IgGoop2HQZ96RA1qgbTpjBN0mpgMEVGGOewMs0UtCa+Tvsvjz DwqwnYxyhd8DS5cUDYu38Tyc6TUdc/YFaeutkLYfm6oLp8qHHg7YkVK4wai1dH/zWdweRkUmEIK CWJh0CL2wDsjsckyjsf5qKoMgy5MPCjfUMdvzrguGqf6q3hZECl2zAI/quWUQBvjGjIdJ2AmoyH sCOhiCfxZe X-Received: by 2002:a5d:64e4:0:b0:460:67b7:54f1 with SMTP id ffacd0b85a97d-46dc30e2c21mr2268492f8f.42.1782377648254; Thu, 25 Jun 2026 01:54:08 -0700 (PDT) Received: from localhost ([212.73.77.104]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-46c1ee018e8sm15530598f8f.11.2026.06.25.01.54.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 01:54:07 -0700 (PDT) From: Askar Safin To: avagin@gmail.com Cc: akpm@linux-foundation.org, alexander@mihalicyn.com, axboe@kernel.dk, bernd@bsbernd.com, brauner@kernel.org, criu@lists.linux.dev, david@kernel.org, dhowells@redhat.com, fuse-devel@lists.linux.dev, hch@infradead.org, jack@suse.cz, joannelkoong@gmail.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, miklos@szeredi.hu, netdev@vger.kernel.org, patches@lists.linux.dev, pfalcato@suse.de, rostedt@goodmis.org, safinaskar@gmail.com, torvalds@linux-foundation.org, val@packett.cool, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH 0/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2 Date: Thu, 25 Jun 2026 11:53:57 +0300 Message-ID: <20260625085401.3787887-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Andrei Vagin : > On Wed, Jun 24, 2026 at 12:12 AM Askar Safin wrote: > > Does CRIU actually rely on ability to do SPLICE_F_NONBLOCK vmsplice into > > named fifos? Or this is merely a test? > > Yes, it does. I. e. CRIU relies on that named fifo behavior? Okay, I just sent v2 version of my fixes. The patchset contains fix for named fifos. Please, test that this fixes that named fifo problem. > I already explained that this isn't just a perfomance degradation, it > actually breaks the pre-dump mechanism in CRIU. vmsplice is invoked from > our parasite code within the context of a user process, where execution > speed is critical. A heavy performance penalty completely invalidates > the pre-dump logic, making the feature useless. This is very unfortunate. But I still want to remove vmsplice. > At a minimum, we may need to consider a deprecation plan where vmsplice > with SPLICE_F_GIFT triggers a warning for a few releases before these > changes are applied. Alternatively, we could introduce the proposed > behavior alongside a sysctl to fall back to the old behavior and explicitly > state that this fallback path will be completely deprecated in a future kernel > version. My patches change not only SPLICE_F_GIFT behavior, but also vmsplice behavior in general. Let other developers decide what to do (i. e. do nothing, remove vmsplice now or implement some deprecation scheme). -- Askar Safin