From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D48D93AD513 for ; Thu, 25 Jun 2026 11:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782385372; cv=none; b=cWoBRjFzOFhDYcJItKhoHGvjt+5mdK5uTql+bljCjME/LnXe5nIKCpji2DXDi3iwDyJNSyzLYAQO4hZMJJjonOujFE8bhLVKpX8DJXFo5v3tEeOX2hBzalKqW9HlZ8n1PyqxbkGru4vZpFBmu4LF/lT8IM3zWKuzuCIT3YIgd0k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782385372; c=relaxed/simple; bh=NR4F+ieQeaovMU2nyAUcUaMtGH8xlJq5lhLjB9nQPQM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KLliEar2DHoiAkiWcg3QUfvFwVZo0uuB/1+bT9a1ah+kNY9AuezJTjqMqAMrdMuKB5jnTWsOZbbLZdV/nzzxQXwq6LWyyXd2wlFPo5Ob/UFmKGy0kTTcNsktvWwVjuFCdzPd6n+msrovq9d8NnP8y/rcLVMDhmrFK/EA3En60Ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AxL9MgvF; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AxL9MgvF" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-30b6dad2382so3777966eec.0 for ; Thu, 25 Jun 2026 04:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782385369; x=1782990169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dzVXIO2M/zZGRMQrA3as78zSud+6/fQ7nehrf8i6Zh4=; b=AxL9MgvFZxxMyng/kLtQZDESdOFV3GFWZXaxkSB6UYO5L6y5XcMM1ZxnD9/2vMUrxV jqsClJpTBPPkX3F+7pF6JEGkrf0HDdZ7y/6ARplIiNOmspHR/qGVlbvli1Ik5TZwJhU6 r+JLdE91628bzcZSJzdubtP60k1ng39afA1sj0rimiLs2kFDKOmGv64miiZMXqVJ7mem 60tKGD/5wMrQRAZErxeSnia4NpCnZ68xS6aUAXFh0rwiq3S8mzqRIgIXgqGccDyX3Oi+ TOuSvex9tZg3jcaNx159Av/ZwlIJ89APdLFRt74OSEDRAnRTjdimd9tH8Ihd6LQT/jEr sF+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782385369; x=1782990169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dzVXIO2M/zZGRMQrA3as78zSud+6/fQ7nehrf8i6Zh4=; b=CPC6p+Onk1RXJa/mWfkJvQTNZfG+BH+s7VuRmifjdlo8rgTHj4umOdfUn/EWCr/LoU KUwBE/98qze4I9LFn4aKrxiUQxmw0WZvNN0S1K4YFT2G5XxFf0sXqFZgdKyoAepgrHjt t+pBx0FwXMbj7mDYJRrG+peJ1RhT1B3ecS8tcnXzZvFIulWs9D9+tGxTWxgS2RjtxUyT JtprYFzcGMtkNAbhUf2OJNHHSK5jDSgZKom/jrYvRtDfiRtoMmR2+uQR9jSGMOy8PicW mKFkS9RLc7VBy1rcpNQ0HrwS+dYdvXoNDn103sCnQEkgRlBgmRkpQ3atCmtCRxNFJclN Saow== X-Forwarded-Encrypted: i=1; AHgh+RqVz9ZaA+XOFiMlHrzw/jaWIljEuKXD9THKNlBXLkAzKqIOVs7j6Ab2i4rm7zezdJlPyTysJFM1jeqhPkU=@vger.kernel.org X-Gm-Message-State: AOJu0YyKJR3EkhE1TwQSt9W5KE7gLhIBpm8fBPDh4BUZYMeY7uOtNWUc nhlugFNvTFIAqfY4lAow6PyjyNfo7aiI+C1pF+ws43OWLSax4d3UxFq/ X-Gm-Gg: AfdE7ck90Ys/5OBatIwF7FGJ+Rmb1EFq7Sx9oT9qLbQF5s3dBQOME/E5ooaZBS3ER5P oJghBRS3J+KPB3o+ckEJqqMAJTKC68Ki/h+KOy5FSTt9Cwfe6ixhtVmpbyndJsZzVEAl1XiX7GN 03ZnrJxilhd/NUWgZH9lci/gJ/VPLkyzVgSNyONvl3yK7JXs9WdGpH8dCfq60Sp/51Ync2x4dRr TFVjgrfzJqCf2/T0vvyveD4RC/DDAZuBrf2qG7xiNfZIEruYy3YUXvNjnMxmbOvG9PvEMONhmw6 aCYD7xttDTmg7RqeXCWpBYMj3J732XMNW8jqFXiNMLsPdMb9u7btrgyn1mrRSqw4zhXCBAb8VHG iKPfb5YqeYnmbHNRskueR5Z5ZfHcQS7ZAZSuGVnYOjsfNtYxQIz/9Z9TL/b/0pWywv1gYBbDw1A EPEXZZK7i8pyO9c2/Ttr446sgKDNKLBShmJMcMXMqEpOsW X-Received: by 2002:a05:7300:8606:b0:30c:5807:abc7 with SMTP id 5a478bee46e88-30c84cac264mr2452317eec.17.1782385368531; Thu, 25 Jun 2026 04:02:48 -0700 (PDT) Received: from 10-86-27-11.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7ca87caasm7229314eec.27.2026.06.25.04.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 04:02:48 -0700 (PDT) From: suryasaimadhu To: andy@kernel.org Cc: gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, suryasaimadhu Subject: [PATCH] staging: fbtft: fix unaligned vmem writes when txbuf is byte-offset Date: Thu, 25 Jun 2026 19:02:37 +0800 Message-ID: <20260625110237.304435-1-suryasaimadhu369@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260625104220.21E5A1F00A3D@smtp.kernel.org> References: <20260625104220.21E5A1F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fbtft_write_vmem16_bus8() and fb_ra8875's write_vmem16_bus8() offset txbuf16 by one byte for a command/start prefix, then store 16-bit pixel data via txbuf16[i]. On strict-alignment architectures this can fault the same way as the write_reg path fixed in the previous patch. Use put_unaligned() for these stores. Signed-off-by: suryasaimadhu --- drivers/staging/fbtft/fb_ra8875.c | 3 ++- drivers/staging/fbtft/fbtft-bus.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c index 0ab1de664..5b95b0095 100644 --- a/drivers/staging/fbtft/fb_ra8875.c +++ b/drivers/staging/fbtft/fb_ra8875.c @@ -10,6 +10,7 @@ #include #include +#include #include "fbtft.h" #define DRVNAME "fb_ra8875" @@ -262,7 +263,7 @@ static int write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len) to_copy, remain - to_copy); for (i = 0; i < to_copy; i++) - txbuf16[i] = cpu_to_be16(vmem16[i]); + put_unaligned(cpu_to_be16(vmem16[i]), &txbuf16[i]); vmem16 = vmem16 + to_copy; ret = par->fbtftops.write(par, par->txbuf.buf, diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index cfcf4d7e7..fc3faab7d 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c @@ -158,7 +158,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len) to_copy, remain - to_copy); for (i = 0; i < to_copy; i++) - txbuf16[i] = cpu_to_be16(vmem16[i]); + put_unaligned(cpu_to_be16(vmem16[i]), &txbuf16[i]); vmem16 = vmem16 + to_copy; ret = par->fbtftops.write(par, par->txbuf.buf, -- 2.47.3