From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B70B03D7D88 for ; Thu, 25 Jun 2026 11:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782386215; cv=none; b=RO9gB6RlMONiApFyFz4nC/uYa3i8Mb2UnlNYSCFEVkoUa/SjFQQk9hJbWuqoiePQvbF8cMfWbDstNnsYdOleXoW5yelNi2d+qk0aEQR4hInz0aXHL6iUPSBtTf+nGahdK9S3FPKVLSPaJ0qasCplYixTllyNhO/rFEu0Cj64SS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782386215; c=relaxed/simple; bh=JNPPCx1lHWFCtdTmAC7TGhYjYGRHFXbs0080/F7tOtg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FrFQw7ttuPTTi+pVNDSNLVuYa6ZCZO7irioOb/ba3/oFGNXMzWm6gX3YYhBgy2BwRXGXe19dmAu+OWLZ5ZITJci+o7ccaG3VG3QV+DaZH+E3xR/5zXYkaIVHCWbzVOHCtedE9AMo26AGlGLBiNdRnIobO6MMnJpVu7J98HWCIlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j61y4gGn; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j61y4gGn" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-30bf132969bso3004093eec.0 for ; Thu, 25 Jun 2026 04:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782386210; x=1782991010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B1lY6wwCmnan7xgttBtmnV+eq+UmPFxIzOyt1ELNCEc=; b=j61y4gGnwfazMJSoEAde6XY609EgEdfRbCFR0ccog9c920VRKgS0NXVzddnXOucIS4 GRQzBkHIV6jXThSraqkUt7kF012lojrC2FK+lw4CE1jjJIH8vqRKYKTkqRmUz5MXNRsC 5/6yjqp2nNvwnSzTm+iD6OPcZxLW8FfK0g3UAGv+40YqDNsjSC+XOAWW68s3S4VmsDFn 2G1QQGDnJeZ088ylw1kS1D3JXCoSF+HZHoHZ/rE5vMtbwM50P1vbqmc+vMx2XQrPX2y+ K44lgkkC3JTyx6KhVUn5AsN3HHJEyScplwQsPWLl/4mIXiJZIVZ0d5g5fbEaMBq0qALj dpYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782386210; x=1782991010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B1lY6wwCmnan7xgttBtmnV+eq+UmPFxIzOyt1ELNCEc=; b=WeFcybMp4oBrYQoDvI+sWk0MTlPbgC0lN9m/y6QwUBbJT45jitBeYYJCK4P905TISr Jmz1ufkjNCBl+2Iis0X4ISDBVWYCPztQ/nCVlVF9Vyi5E4iEIDkdpCVUkrXbLPkk5qyo DYTm/tUryfDtycGlnO2XKfV5mQ1dAkUNMXUe73FDO5agwTB2qoWWHsaUgFrXFglE/FB0 D1RegScUUcIZuqr5LfjF4ytok1Ou0Q31ttfFofgNIIi90tNFCkelFcvF7gyMO12rx46r U9y/46nJS20116cRCkZBI1Vjsb6BvF/IQCaFDwRAglh1t2bFL+ozsiKme8s4Ub6LoQtc uzgw== X-Forwarded-Encrypted: i=1; AHgh+Rqn5a4jF6/cP5h55smQJ1eGsp16WMgMK1Ggd6g9CybwEZaaFqbda6lFQG9S0IGMRAmkpTEdRChh1IO7qvg=@vger.kernel.org X-Gm-Message-State: AOJu0YxLpHEAZGDLmIsCsob7+aqMKqWXd5GudWHPOEh+jkVTvqFrdiF2 n49vSwugB6JKCsHUR7eveV4Yz9+flvJjSrxqqANoNYasOdUojDnpYk8rj13ZIrkg X-Gm-Gg: AfdE7cnndKhssa5nx5rUBGinouKbHSa/t1ROtzLS8BNC1CNzAjI/BaAd+Py/QzDrIjt JIui51mtXvM+MdxuWgZ0Nmw67g3nWhdCHh9fPgbTVoV7G45sc/fxJB1S1QqvUsFtNo5oG3Pw7ae j9LG++zuoHOKVpvUsZlZ44aVZszsXfYaUjkEnmHSHQnbEisWVHEmmcmADdHyXPudkzp30A432l3 kViq4X018IfrflZkAC3vOTVjsMlTFrXXBKKV65XCMXH2Q//up5lh2IMDgXjFcXCRDLcNoONORzP h83BklCPIPteagw90noPvCb9InehnyfPr3bI/vO1g1SAfACM5MB/ynf9V9WhRulaG9Dt4a3BnmI dK6GQ4iQB6djEEjaA3HeAY2YD9jYpgwucnMJ2PGOQ6VNe7uQ0F37OIcq4Ei0Y9yurI6t2TeCaRj C5jVWUWnzUsx8bRp6yQ7FJ9hJkAgxynfkt9A== X-Received: by 2002:a05:7300:e683:b0:30c:2964:67b5 with SMTP id 5a478bee46e88-30c84bccf37mr2272357eec.11.1782386210298; Thu, 25 Jun 2026 04:16:50 -0700 (PDT) Received: from 10-86-27-11.ban-spse ([165.204.217.251]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7ca5e601sm7915909eec.25.2026.06.25.04.16.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 04:16:49 -0700 (PDT) From: suryasaimadhu To: error27@gmail.com Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, suryasaimadhu Subject: [PATCH] staging: greybus: add meaningful comments to mutex declarations Date: Thu, 25 Jun 2026 19:16:37 +0800 Message-ID: <20260625111637.311831-1-suryasaimadhu369@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The gbaudio_codec_info struct has two mutexes whose purpose was not documented: - lock: serializes DAI stream enable/disable operations and module_list/dai_list access in gbaudio_module_update() and gbcodec DAI ops - register_mutex: serializes module register/unregister operations including DAPM controls, widgets and routes in gbaudio_register_module() and gbaudio_unregister_module() Signed-off-by: suryasaimadhu --- drivers/staging/greybus/audio_codec.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index f3f7a7ec6..3d92ac8a0 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -70,7 +70,15 @@ struct gbaudio_codec_info { struct list_head module_list; /* to maintain runtime stream params for each DAI */ struct list_head dai_list; + /* + * held during DAI stream ops and module_list/dai_list + * access (gbaudio_module_update, gbcodec DAI ops) + */ struct mutex lock; + /* + * held during module register/unregister including + * DAPM controls, widgets and routes + */ struct mutex register_mutex; }; -- 2.47.3