From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E53385D86 for ; Thu, 25 Jun 2026 12:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782389102; cv=none; b=fq+jGjBhrAmYKaBhdP9kla6Rm3xQc+erMn9UsZuS7cfMrF4BjVGuVjytliixzfU7iMX/QdWZDD6vwwYmE9/qW3lOmGXizxpwzUIL0CBhuq/DWWEOiwnywGV0QTW/4LbIh9R7NflAUcNJ2EBTW/hvYHere/t5DrV8RdOT4zEdFEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782389102; c=relaxed/simple; bh=KX4j5dfZ4TIbacLcQ0pYkg286VcTDip2XjdZMyDtwTE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G4aQ3gcAVjI2OVG4VMJnlouahciCcr/GGrG95DXok3PeTKBcmHwG8dnc7JGmEcmq95y0MYEXdofBYROpjj9yBT+Ms8ICdBfSD8fxBRN/wsogTvS2gZO/eG2Cga0ibVTUZI0xgmWkO6y2xVA1EoDhuKhZhMpG2nkMH0CR4IGzSkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pbj648/a; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pbj648/a" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49249072f03so12329395e9.0 for ; Thu, 25 Jun 2026 05:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782389100; x=1782993900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hys8RmE1l7PhUa99M9ZeaA23kXdy/j07bAQ7G83FKzg=; b=Pbj648/aeENpC4C4wkBxV4cst2k3Fl7tPXtMx9JSY6NWSZnkHMmgxjDBDbotVRs6kf o29o8GWNRANP13z7z1wG6zFbjeKRxs6XYz87Z2MosB8W/8y32CySWF63bAYuD0VXTRQU 7aHwCeVnvSMYatwFKUV6ywjlMKZtLg7CvzeJQl3Y8fi2C3Z2FQlNBo+XAEkXuzVtCKsy Bm4lQu53rnjXMr+VFQpEV44fjq7cNZNkAjFgyEFk+VVHJ8QCOBmXfJ/YVbD0f9WWdxNL Yui6FKdfYVfrY+eSmrsvtZXTvrFOqk+1QpWqpfE8ENzfrQGlgaFLlvQaLw4BXDcg12Zq JELw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782389100; x=1782993900; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hys8RmE1l7PhUa99M9ZeaA23kXdy/j07bAQ7G83FKzg=; b=aWQ6DYehkxmFfL1IFOemZAJ8tzyVu3k+bMzF1I/U2HDNAxViG1bHxtQKB10b5eMtu5 nWOBYKSFirAkd3m9babFkK74MazGvYLznzTKPUkmtREBABvop0zY0UYBSjH6ZrE9hgJ+ nqWRUM3Pk0MlBCyyQx4/NrblqzuPV5eMok0F2Mld9xXkEFG9IEJ2qjkWjPGeOZk+SqX5 QRlu64iKZzy4mBZWHORFS53yCM/Mq4jJ7d0NmGWcHVkXxafp9HXlMmk+/oZMOt3VOu7G LkUu0byyufFm4o3q8/voz/U/3CSf9GOq0NLPhWTPmq75z+85yTHIc3Vxl+MlUoqX0q2S BNcg== X-Forwarded-Encrypted: i=1; AFNElJ+B47b90SVmA80xuWQ39EWd/yvK5eNc3RQcGPae9d63afrUO4WDwj8CWEL9jES6XzISlhwHjChMMsqMLyE=@vger.kernel.org X-Gm-Message-State: AOJu0YwhJZmUSpT1oGKDzYZy+mjmf8yfDG/6xoXA1+53DqXHydVukx/H +SFkKviwxbKKullSXl+I6xmOFq0ZOQjcoRjpORvsKAjidaM4VYO22XbV X-Gm-Gg: AfdE7cmdRAiXsRLIKc1xmBMUzCAAiZbjdSEuKo/00pFNQv+EeFLSgQEyCNjlnHoMv8T 1o0dyIkJTKJCoDL2yK2mDN5DNl5HSArZtBTRiP0NsvNGLaDEaO4uZWzuDdRmpcD4bNFmAQvwQUy ynUHVX19aFvLZaqylfHu9iQGwgxO94J9yPng0tog3SMizSKxG3kU9rD6hQasQ1wMSeBeQoLmIue ywdTfmMynhVVPRCIj8A2CPEgYSwjRFb5fRRjBdHWQnk/9UzhYr1d0alVSIPH/5XCzJJXULjwlc3 DfwI5AAUNwin4yyy+7aILC2twcLUpMi0qm7KwLSN//uZSW7I3AC6yCoa2LPb63oD83wk1y6ENd1 JAUgcyLk50W8gQIvfcoAw0pbZrVqv18XtUCZ2K8S/d2il99D3mDMaDPpbVFy7sLGJLUhxvFHybM sCzpm2jPhq8vCXeF5U+gYrzzCRKitVdKOxXxC/g7HWlaNNtTTNAT3WfJnc X-Received: by 2002:a05:600c:1d0d:b0:492:1e36:85dd with SMTP id 5b1f17b1804b1-4926689f6d5mr32803555e9.37.1782389099369; Thu, 25 Jun 2026 05:04:59 -0700 (PDT) Received: from legion.localdomain ([31.223.63.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49265fa8004sm49941925e9.10.2026.06.25.05.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 05:04:58 -0700 (PDT) From: Batu Ada Tutkun To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Batu Ada Tutkun Subject: [PATCH] staging: iio: frequency: ad9834: use guard() for mutex locking Date: Thu, 25 Jun 2026 15:04:55 +0300 Message-ID: <20260625120456.1267-1-batuadatutkun@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace manual mutex_lock()/mutex_unlock() pairs with guard(mutex) in ad9834_write() and ad9834_store_wavetype(). The mutex is now released automatically when each function returns, removing the need for explicit unlock calls. Signed-off-by: Batu Ada Tutkun --- drivers/staging/iio/frequency/ad9834.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c index bdb2580e2..f15819eaf 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -152,7 +153,7 @@ static ssize_t ad9834_write(struct device *dev, if (ret) return ret; - mutex_lock(&st->lock); + guard(mutex)(&st->lock); switch ((u32)this_attr->address) { case AD9834_REG_FREQ0: case AD9834_REG_FREQ1: @@ -210,7 +211,6 @@ static ssize_t ad9834_write(struct device *dev, default: ret = -ENODEV; } - mutex_unlock(&st->lock); return ret ? ret : len; } @@ -226,7 +226,7 @@ static ssize_t ad9834_store_wavetype(struct device *dev, int ret = 0; bool is_ad9833_7 = (st->devid == ID_AD9833) || (st->devid == ID_AD9837); - mutex_lock(&st->lock); + guard(mutex)(&st->lock); switch ((u32)this_attr->address) { case 0: @@ -269,7 +269,6 @@ static ssize_t ad9834_store_wavetype(struct device *dev, st->data = cpu_to_be16(AD9834_REG_CMD | st->control); ret = spi_sync(st->spi, &st->msg); } - mutex_unlock(&st->lock); return ret ? ret : len; } -- 2.53.0