From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC00A3D7D6A for ; Thu, 25 Jun 2026 12:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782390499; cv=none; b=JdT2/nfHSm2pTDZHH0Xsu4wKi1G5/uKBKPD7HqR5T6ouOwFMIb87CEsi/a/Z7AgXfldto2AxqYs2q/9fkACeuz4AqO1Ek+pjryipSEToguBtCqQaVP4MSIgfHdpR4MaeIXcZI+ddaCIxVvSNFXAOAhybKA8Ls6II8auDTGA8m0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782390499; c=relaxed/simple; bh=KRKpkWP00bNEF4grMq3i5I7hOtSL5fvYq5mom76z2uE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=JiLpjZjIt8aJfDYKoFnYQ+WSGNKij1jMJv2uIOwLGuTunfcw7eS0bEm518+AnIrzgo9SF+POyhOwEk5y2G4nD/p6pyAXBBAL44SB3o0v+ZXSam6V8+ETERcGng/8p0e37OPus97ddOrYg7F0xJM38mUIGIHPu5/RYF/D7mR6YrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PkNv0HBS; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PkNv0HBS" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490b7866869so19583275e9.2 for ; Thu, 25 Jun 2026 05:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782390496; x=1782995296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=acZXyqUmvZIylO1mvvipo8nK5yGrkk/MIYuMVpE7WOk=; b=PkNv0HBSwpivNBK1VT44w7TZXyXQRGANOqWo01nOtpXg32tG+7Keqvk/EK/mAiAk3a EcOA3BziJBPYE8ddeGOqUHcQ+XVZJ2JeRJ1hX7PKPoGhvu/TEhXrgcXf1fLxq+Nrsg2Z ww7q2FUudFFtqwoYIArbuN1GLUt9QWrLp7h0GTQX5gpAygjUYW/2YHp/0kxrBvK/A+0z KvOLdkjxVHvkvuIoW9oq6fVnSOqHRBSA3vTyiQ33F3N5y5BN5wy3RNQwyI/du07bz6zu 5FLapm0CbJEfxNgPV8OAlostLWvM8WQ7lBrs3v4+196dEoEB6QXVq5P/j1IDV09YXnPd /s6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782390496; x=1782995296; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=acZXyqUmvZIylO1mvvipo8nK5yGrkk/MIYuMVpE7WOk=; b=HFtjKNUNA0ubh1wvEh3xn35hgFZENvsLyJ7679NYnfFrYyKfzOHsQG5PdC08O212L5 nDndAwqH8rChrsWsg/nCGigAgSZpkJRJYU/BeOUeUWTDWMLmUXRzYTugr3Y1toOHEk5g LHleVuPIREZ/IASMeyjJhcyjkksZFaMaSFKvW/N4DCD/9t45zZizwO71EtYkwkWcWOHD djehQMpWe7VHwRAVRaHInRyuvgpdmi0+flOFCDlNqkPNSPzDHo4gVCyXxhig+blJbdPX 245MQqDh/vNMIjFHDJwr1YFGK6+VU66fyvIIImlsA93Vab648weqFDYSsBIcjJa+bNuA 9qEw== X-Forwarded-Encrypted: i=1; AFNElJ8ZHdSqaEL7w8+en+AzR7xXSZlAJLxzfeutpR8AD1Xm3e8oKgh0iGuuOw1G2Ummyvpj3l4+MIxG6wG480w=@vger.kernel.org X-Gm-Message-State: AOJu0YyxhrV1XdjMWaC/Gzdht+dR4wCL0HMfouEwAKzybjzoFf2WNHiH ip+2dVfYG2FIk+WE9+Abjc8XGE3U7D0JbmGt0tDw3/IZbI4juFUcQSHc X-Gm-Gg: AfdE7clNxHdO+7U4Zro4L8n0x0OBFy6KZH9LSL1IrVu9k+03XdVdaTKvXDB4ExrNy9n og+jJvo70jcsAhtagYkxTV7FTDSuJJhkuzzDxa4l/W2NSthEtlGcZfTLUSt2d+2WrN372Q3Xyj8 jdQvrgrYeFEPm/2rZYkyZHM4G/Rk93FQo35Wz40sIqS8Tznfdcb7sp1+o9fHlpY0R7pwgtRvrCi PVr2960XTmSmQISZvpGJIi8//wXFmTZii3i8FAj1Xo/WD3O39nTSOPG4UOSfGXbBtuHgISCycFu 3qRey41SXXPxXjrYxBS2gXQWWN1Scbu+jppOGDI63/2zaER9byRSZ7CeV5CE2/KFADGms/1ADri NVb4AeT6Fzx/1PxtSGSBdX9w+JaokLbBVLihPzb087b1+c8hfzCBq+HFqi+rlYq+Mcz/aI1npNp uJ2W3q4brC6/6ERVCw X-Received: by 2002:a05:600c:8b03:b0:490:c2a2:e91c with SMTP id 5b1f17b1804b1-4926689ffb5mr32412945e9.34.1782390495974; Thu, 25 Jun 2026 05:28:15 -0700 (PDT) Received: from toolbox.. ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c1e840eefsm18779181f8f.1.2026.06.25.05.28.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 05:28:15 -0700 (PDT) From: Christian Hewitt To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ASoC: codecs: pcm512x: only print info once on no sclk Date: Thu, 25 Jun 2026 12:28:11 +0000 Message-ID: <20260625122811.4056274-1-christianshewitt@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If sclk is not provided the driver falls back to using bclk and prints an info message in the system log. Under normal operations the message is repeated many times: [ 17.929576] pcm512x 0-004c: No SCLK, using BCLK: -2 [ 17.949172] pcm512x 0-004c: No SCLK, using BCLK: -2 [ 17.953029] pcm512x 0-004c: No SCLK, using BCLK: -2 [ 17.965059] pcm512x 0-004c: No SCLK, using BCLK: -2 [ 82.592980] pcm512x 0-004c: No SCLK, using BCLK: -2 [ 82.866293] pcm512x 0-004c: No SCLK, using BCLK: -2 Switch from dev_info to dev_info_once to reduce log noise. Signed-off-by: Christian Hewitt --- Changes since v1: - Remove WIP tag from subject (oops) This was observed on an Odroid Hifi-Sheild2 board used with Kodi which appears to reset the audio connection frequently resulting in 100+ repeats of the message over time. sound/soc/codecs/pcm512x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index fdef98ce52f1..fe3b5011fa16 100644 --- a/sound/soc/codecs/pcm512x.c +++ b/sound/soc/codecs/pcm512x.c @@ -633,7 +633,7 @@ static int pcm512x_dai_startup_slave(struct snd_pcm_substream *substream, struct regmap *regmap = pcm512x->regmap; if (IS_ERR(pcm512x->sclk)) { - dev_info(dev, "No SCLK, using BCLK: %ld\n", + dev_info_once(dev, "No SCLK, using BCLK: %ld\n", PTR_ERR(pcm512x->sclk)); /* Disable reporting of missing SCLK as an error */ -- 2.43.0