From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 528C23E8330 for ; Thu, 25 Jun 2026 15:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782400602; cv=none; b=VaKGp+P0yXiY+HlLI23/eJrmzZ1NCxh0Vq04n6XWl1Gk3/aMwdgp18fN/0Eeehw56C9TF8uoBkK9cViKodXCF7jPN2BGct0KXDbYg4GiOhCwYBG+mi0xNHu+V4EIw9YqHSro+n+/ACFxdZQmQMe2vbgWJ2OUJGVJ5dzt2nJE+yg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782400602; c=relaxed/simple; bh=EIqqXcdIoOPiV+NIqbqMUH2LndGKssX7DiW9OtUpJvM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fs2IJtZxrNCDvPf1mMlgVNLwezF+lWee1Mclxzrrj7ZLbCQHEpI0rmwxr4Cv69nBHbzxBvqx+yO+Z9JdAy1YhiMCLI9CaXEIeBQKAVIJlnOufLHnXzJDLWl3dl3p3NB1KduYnBr7Ro1d9rKbRfMYFxVdxBcWK21O0TKmS6MdkW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o8tWQe6T; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o8tWQe6T" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-490b7866869so21493635e9.2 for ; Thu, 25 Jun 2026 08:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782400600; x=1783005400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EIqqXcdIoOPiV+NIqbqMUH2LndGKssX7DiW9OtUpJvM=; b=o8tWQe6TgCOjW4GcfxukVMX2yZt5Ba7rPvfpCIeWob0n/6JyDr3RWtbKbxkB1kQMfw Hx+16KIKShqqQMaVY+aRMrAQ6BjsggLnhYrQgshyTOnLsh6o5VUuaBjOIBGMYGOTJtGM RfFMfj7qmbdvS6TWwH9z6x6gINTTndBim24ZZzjzgqPlAtMqoRfpWnagJKrGG0OIgOdO buwJKxA2X25PkgGLWB3wJSTRJS/Cu8X0L9EiYoKv+0OTsbCQzvdMkweqqSDMzLODG3TJ 0LW1YzOum5bzCgh6qhwRqmG+a4qZ82rI+itvU6DNktZW9Hz4rTvCvTLAfwvXxeu6PB14 8Dmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782400600; x=1783005400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EIqqXcdIoOPiV+NIqbqMUH2LndGKssX7DiW9OtUpJvM=; b=WT9Bh1le7ZjtvOK5lFILU++hSYxPdpjn7SQqNNyeHcQ6s3M24NtUeYkbgItr8GkcxA DyUCH58NIVNoFG1ICeC56bLxpI5ielpH7+P0NahLMLWox1MzSpXRvqXqZEby1E4dzaG7 Sn6YTixQi9T+RAt+BZGqcoGe2tE4CMXEF5T5wX0hu7+laZ7ptFdFqBOP5BNdKJi/GeM8 DTASXVw+SxUMV1YyM9juUGNO3vZSrkvqdPXXqC+xnEy3k0vuhCgVqdbgYvVhRO9FsRqt SC1NaA0/d/9nEEHWThijT5qurEwMNX+ZGNVR/YlTULZc/RujvPOjLxs3PvKeNPlPjtv2 9Ncw== X-Forwarded-Encrypted: i=1; AFNElJ/Tof3hZG7OM+cATcuqgCCqfBZ0F/OhrQtGZeN6c15nxVBWYr5yqLTstfI5dV4+HfBryxKhWRmISgnR5dU=@vger.kernel.org X-Gm-Message-State: AOJu0YzkL/WttRQX4jG/scsooi7g9AvdrcGx7p9vuKdktXycQAG+HS3/ J7j7hi7QdQsPOTvzIXbSCdsxDQockVQePf2ZznOOr/hspcJ3YsA11YV9 X-Gm-Gg: AfdE7clb+gO7grUI+dWsM/t3lSvk1FYo6HS4c88xy1T0mz4EP0z1YMYHgll4bsKOGEt hodLGajJ0V6mD5C6f/sCFMLoO10+xmhzZP2eRA79mXR8EbusReEoo804bI+Flf9NMyu1661TV5+ TVKuD3Mf5UbqUCFqU84S0lm0rH6znfvdQPSQpJG7IheGmvCjaazapyXOZ1ev8hgFl+m6Ms+MAP2 mM+buAgrNxpFcGJf8O3J8/wQhhyzZ0zzH9cu6/o9kj2LnkM2H5Ji0xxthNy/Qmu46/aDNbDrWJJ PnbKP0ynNcQRAkWkr0w1jTP/hWKPQS27nS75QjqXfdE9PqcCSX2qHqrf8twstcWDLPJ5k5vAco2 /B/eIHs0hTreYCcdFKpyqBXadp6O/If6VecgxL4rZpclgsIAPZddu3ar/7cZK2fzEggKjCwdq0D CDIlG4/h+kMzXM9QCxfRBqUMvVWbHMdeXlySfH/yGhLSBOxW28i0efTMXA0VwhDYxoIr9kdDQMg 68ub5neFLurUhVobtf2hQu17D4= X-Received: by 2002:a05:600c:c4aa:b0:492:3445:ecf8 with SMTP id 5b1f17b1804b1-4926685fe2dmr40322555e9.3.1782400599376; Thu, 25 Jun 2026 08:16:39 -0700 (PDT) Received: from mskvarla-mac.redhat.com (adsl-dyn180.78-98-2.t-com.sk. [78.98.2.180]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-492691f60bcsm1420565e9.1.2026.06.25.08.16.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 25 Jun 2026 08:16:38 -0700 (PDT) From: skvarlamatus@gmail.com To: skvarlamatus@gmail.com, ericvh@kernel.org, lucho@ionkov.net, asmadeus@codewreck.org, linux_oss@crudebyte.com, stefanha@redhat.com Cc: sgarzare@redhat.com, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev Subject: Re: [PATCH] net/9p: add vsock transport Date: Thu, 25 Jun 2026 17:16:36 +0200 Message-ID: <20260625151636.26449-1-skvarlamatus@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260527073447.86538-1-skvarlamatus@gmail.com> References: <20260527073447.86538-1-skvarlamatus@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thank you all for reviewing this patch and sorry for the late reply. I am already working on a v2. I wanted to ask you about your opinions on the issue with port number truncation. The port number is parsed from mount options as u16, which is sufficient for TCP, but vsock uses u32. I see two ways to resolve this. One is adding a new command line option for vsock only that would be stored in a u32. The other is changing the type of the port variable to u32, and adding a range check for TCP. Personally, I would lean towards the second option. -- Matus