From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F9B219E8
	for <linux-kernel@vger.kernel.org>; Fri, 26 Jun 2026 00:55:19 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1782435321; cv=none; b=DvUqa6LanqzQdVljnK2qusl0/frJ0QoRV76QNy7XQuP3cmhufEw/VTkqRDoLlVTMYCn668VGu/QxNOPyefVnZl3vtAukMVrocY4qFl1pAtL2DrxcVR2g9jbsZq0flqO0lvR6VrbV8dDZf9fXSWQRap+tegyjMrsfOcqobyZtKXs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1782435321; c=relaxed/simple;
	bh=DR3hiB6nT+qhK4dqsqNWAmMEveSDCNYeMGiXTYy+tF4=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=bdbAAj/kbD3ZMCj3Ow83PIJp1cQhId70nPMPbvSk4qcQo9bOQNwkej9EZOtfp7nc0BUHtjb5IUFysjKLqoILhktehL8bB02FXrDuDozrkcmIvPWKEeVQwDyTkwkNLoPnPP6dxIwhklrHFSwgguSd5rJjEILRHpV6oXI0jz9UXCU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=AhNEfsFm; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="AhNEfsFm"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 517781F000E9;
	Fri, 26 Jun 2026 00:55:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=linux-foundation.org; s=korg; t=1782435319;
	bh=gAiyQmyQj1R9+q0zENY7sPgSGoLOh0EnuwizhQfIl/Y=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=AhNEfsFmx67rHeiLL+T94BMFTgF6Q7hVh990FIfGh5uc153zE4LuyC1AeFPGn9OOS
	 /NY5xr+An6611Ay7V55cHYIm1EFBTvzHXMbf91PpmDO9Q7+WmEMcXFF4VoPBUCtoHp
	 GEI77BU40OZj5syt5TizBcQy+6yT6Wn2pmXsIwe4=
Date: Thu, 25 Jun 2026 17:55:18 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "Zi Yan" <ziy@nvidia.com>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>, "Brendan Jackman"
 <brendan.jackman@linux.dev>, "Brendan Jackman" <jackmanb@google.com>,
 "Vlastimil Babka" <vbabka@kernel.org>, "Suren Baghdasaryan"
 <surenb@google.com>, "Michal Hocko" <mhocko@suse.com>, "Johannes Weiner"
 <hannes@cmpxchg.org>, "Harry Yoo (Oracle)" <harry@kernel.org>,
 "Gregory Price" <gourry@gourry.net>, <linux-mm@kvack.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm/page_alloc: drop flag-conversion "optimisation"
Message-Id: <20260625175518.d5b4a051cca43f03b1666a00@linux-foundation.org>
In-Reply-To: <DJII6XRAZ7K1.26C7HGGRAE5IW@nvidia.com>
References: <20260615-gfp-pessimisation-v2-1-65f1319e6818@google.com>
	<DJ9KK3Z7BPYU.2HDB5IVO6Q40@linux.dev>
	<DJD06ZZOC9IR.33KCFLM7L4267@linux.dev>
	<DJD0X2R79SVW.1XM7FV4REYCHS@nvidia.com>
	<DJD12YR8S99G.1I43PSHB77TA2@linux.dev>
	<fbe1e70b-2a33-4db0-b390-3841c1a84522@kernel.org>
	<20260625155045.b1e2262c552e5a5e0116f884@linux-foundation.org>
	<DJII6XRAZ7K1.26C7HGGRAE5IW@nvidia.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 25 Jun 2026 19:02:43 -0400 "Zi Yan" <ziy@nvidia.com> wrote:

> > This particular patch looks nice to me.  Code is cleaner and the change
> > reduces page_alloc.o's .text (x86_64 defconfig) from 46571 to 46443,
> > which is a good sign.  So I'll add it, along with a "needs more review"
> > note.
> 
> It is actually well reviewed[1], but Brendan forgot to add tags in the
> original patch.
> 
> [1] https://lore.kernel.org/all/DJ9KK3Z7BPYU.2HDB5IVO6Q40@linux.dev/

Yep, thanks, I saw.  I added your r-b: because you anticipated the
alloc_flags_nofragment() change.