From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FE5133BBA2 for ; Thu, 25 Jun 2026 19:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782414948; cv=none; b=oAT0hfiHrbfCxVMItITemDkK50YEaurKGg2uKjHwlzdBVpaceQ68NJGVwJI87xLtdy6ETu5QF5VVCfib3IlYq6qKg0dhywz0tTa9iZt9Z6Mx35ENt+4Rjx2Xfbn3OWoicAtebUhj+rbF5916bi8Rr6ZkMVp902uA6FAJC/bUIQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782414948; c=relaxed/simple; bh=0In8diwWOYQ7yP4vNQJ1muRLkMrsAa74ksEacPI3foI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TNYOjKC+pR80If2RFU36HKZTClxMuV/ZuoOl+ZokHY99CyC0LdIedjlttp9v5XPgKyyE3okmRuA2u88FY1shAaWO5IrTd8In1UqbScBcyYgjd1P8w3i0ODwHhxTcwffIm97TcNepUXsP4j5WDfO7brmdmQYlgFLAVKGdcc/qH3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GYTbPnoc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eAEPbeuD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GYTbPnoc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eAEPbeuD" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PFdv842510949 for ; Thu, 25 Jun 2026 19:15:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=MBmzUwdpwOW 8f0OBvo8XEGa9qbPb7NiLUabU+Y9s2y4=; b=GYTbPnocIofMqsHo/huqipvjJmd J0pUHz6JKq/DKk75RtGkNCC52Gcutz0fguNM9NE1IdBQRNtKlxy14lWr0togA7QP xqmxAsDAo8gZ6thvrrBelT/L6ucep4AXvEibIyAJhow5LTXczuEtqwb7mZssARZJ WW4GLiPgd9OPTF+y/d8o7OUYMr1ZW5ve0tLiE/4E4YrAh0RDnu9Zxgj+Bo3TDpO2 yhWluz5HfenRam/iGfcoKY530n+0bTT3SMYmyLKmIVP+2ymbY8pyat31IQu9oET3 /QYYMCgTpIVhC7vtMHstzSGhv0xApi3Orlc/pu32l6iCXDDNmAdwtB0qa2Q== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f16jg94r8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 19:15:45 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c898897816fso106761a12.1 for ; Thu, 25 Jun 2026 12:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782414945; x=1783019745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MBmzUwdpwOW8f0OBvo8XEGa9qbPb7NiLUabU+Y9s2y4=; b=eAEPbeuDKeBGkJhdjkljmxs1HFN4vXQAUVein+ayMweuPzmN6EMJt1CMYv43tnPbcD OkMpUOuQRXDeuPl3iYKJ4PfE3yUYBvHE/kC4K2e4NBR5PN1iAVUwQT4c0yf6/GBqQ1ls fMJf2Xu3GY9c/tL32ASJ42wULP54Yct1R+flvyv/NBOAyStFAyXYznuS0GYCbK8bM14I 8gpEHTnd5u455yNm149L8Nm135HS5+8PBQ9jU0TERTmOwkuErEfEVFjolUEifSGTBoZo kLcwpdMiLJ1Ubb7NlrylK24NfPw7VxU02CCMimhcyy8/zcz3V7sJUm8T5KQxpJMmC2BP SLUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782414945; x=1783019745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MBmzUwdpwOW8f0OBvo8XEGa9qbPb7NiLUabU+Y9s2y4=; b=tWHAW6F73Z79rCaZXHow/R3RChahmuVKYmeBpr6n96fkivtzAxB5W5tVnDCThzvRsK RoU1cSfMRtPGDmj06oN416rOrpjsjmLcR1SE+7TE+3M++cJd7TLqjtmO8BByUnSxVff6 LgLVPR8bp07S3ekC7MCT3bKiryCeWP4NQBPOXRSv//4Q3DTJJmHAQWRi9Vz6fP0+aKIa nUV8dcEpPp6804h4Tpbo0UF1SnOvCAx47UrOmTK+hDcbsOwUPJUyzKk2Z9VK740/YChM zZeR3kc4eXoGRZgzrVcy1jDZkAPaCcm6D5mc29AqqVckudlavbWIQ3K7GBDITiR0aSCH dC/g== X-Forwarded-Encrypted: i=1; AFNElJ9NSoqY88q34OgHqx9agLQwmI08Q3yJ+8EXDqP/fWZDJql8kN32oVd57/WnD8E6vcJniZHWvOdh/YXJ0Oc=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ1y45RrVykwEVA16wcUiexeIwvR/TmpCv33vFO24FQMFYP/M7 ZNN39/xjtWkAX+Ph8/tDKTXxiVAaZ6ibuz5PIrUfTOoL/jhBpfwFxcSAv7pKrG1BpHlIcL/0836 hkhcnOrlw686TNh36dPlfP6Fy+C96TeCc4QGc7646OpnhmqZYoQ7kkFGZZPkEdPeSkpI= X-Gm-Gg: AfdE7cmihGNWIpOG1NkvEHSde3rih79PkNTDI86h52XIUmuDY4T1u8mLAqVSnGTq1RA ZGh1Ir8UgBUVnmd8kaNrwH2lpxIqZ8EkBuRopbixR/dtSOlBi0PcSCkb370S4HuDSFtZ9Nhqb6k mdnCT8P/p6yIuNxVJQZNO3UHu522SIfXCRELAD67lFTbrJr8NbRlZoaOBFBO5qx/whW5LgCy9in eYoglQGT8GFyfr3bWG/paAIIeiOZuvZkZosQJQjUiTMXz7vXucKojdPlpkfrpv0wdgePzCD0NnO GKQNugqdo/lybioJ2S26EAuGEbKQ/5GzsPSde2ceKb2jfRvlIVt8be2ofDdy4fvDENAyjWYLzEz EyQ3ijCKL8qu6irh0MqY1RXKlsBg5chuVs3Jwq2zSeUAbJOtnRIpy5xP5tg== X-Received: by 2002:a05:6a20:7491:b0:398:7eea:50a0 with SMTP id adf61e73a8af0-3bd4ad9023cmr4376097637.18.1782414944635; Thu, 25 Jun 2026 12:15:44 -0700 (PDT) X-Received: by 2002:a05:6a20:7491:b0:398:7eea:50a0 with SMTP id adf61e73a8af0-3bd4ad9023cmr4376065637.18.1782414944010; Thu, 25 Jun 2026 12:15:44 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c92bcb9c813sm2176638a12.25.2026.06.25.12.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 12:15:43 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/3] drm/msm: Fix barriers accessing ctx vm Date: Thu, 25 Jun 2026 12:15:33 -0700 Message-ID: <20260625191537.47965-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625191537.47965-1-robin.clark@oss.qualcomm.com> References: <20260625191537.47965-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDE2NSBTYWx0ZWRfX9AQp72Lw+aP+ EtvUUHXPJ8X1BvcaZl7Szwdvjg4bCnYot6Lc3XgHo2aNZdHJX2sDWnqNCZto+IjvZK3kyJgfRgr L/I1wRC6DiaiR/9xWedxMNyjcNTZ4Q5eSDP0bT/I0PlAWP6fnAxwA0S663ikUXi1Ipe22KSza8C 41NQDKNy6euTTs/NzxRFhNjIkl4r0EzhqVavrC3xddjrvDfvz9sVNTCmPkILcNwA42Ppndvkz8W oaTmFnFrQ9P1PKjX6IltHl1CVZYErGz6QTuDpjRms45q5MqKcQNL2O7QoF1fj00fb/6jCc+tifR QaHRoVKsu8+LeXftTwJ2l5GYsVq2p2TGkf6vwLLXQS8VgjVVUxX9PfnUW1B9qjOmY5mqDYOrZku JV6bBNtmZltj+bFSs52FWTxI0UjnrkxrlvUF6EihEBfvQVsoc8l7aRCdyBDljGvFjWu6lmN+ce4 HUgC4ZAXWAVmmvZcnhA== X-Proofpoint-ORIG-GUID: jDwK5PzxwPvLFZvDnBFLq9Osjoi7mq8G X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDE2NSBTYWx0ZWRfXzJf/GIBuqRa7 e9InjyNSm+3Bq7sRzJv3KJI/sU5+q/7mACCs9u9lbuYacIx70UFznNylbhJKaIlO3WtkRPRAZYw xNkgkjcM21cv28eWDAveiy8bRuul9kc= X-Authority-Analysis: v=2.4 cv=daqwG3Xe c=1 sm=1 tr=0 ts=6a3d7e61 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=PXeb_Y4BrUyLDKu8J0IA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: jDwK5PzxwPvLFZvDnBFLq9Osjoi7mq8G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_02,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250165 Don't rely on store ordering to protect us from caller seeing a partially initialized vm. Reported-by: Sashiko Fixes: feb8ef4636a4 ("drm/msm: Add opt-in for VM_BIND") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 32d5ebea2596..ec88155e0ed7 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -224,18 +224,19 @@ struct drm_gpuvm *msm_context_vm(struct drm_device *dev, struct msm_context *ctx { static DEFINE_MUTEX(init_lock); struct msm_drm_private *priv = dev->dev_private; + struct drm_gpuvm *vm = smp_load_acquire(&ctx->vm); /* Once ctx->vm is created it is valid for the lifetime of the context: */ - if (ctx->vm) - return ctx->vm; + if (vm) + return vm; + + guard(mutex)(&init_lock); - mutex_lock(&init_lock); if (!ctx->vm) { - ctx->vm = msm_gpu_create_private_vm( + vm = msm_gpu_create_private_vm( priv->gpu, current, !ctx->userspace_managed_vm); - + smp_store_release(&ctx->vm, vm); } - mutex_unlock(&init_lock); return ctx->vm; } -- 2.54.0