From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D68B8362130 for ; Thu, 25 Jun 2026 19:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782414951; cv=none; b=jPseo5LMBgNs2GCwmdvbByAzSuKHh1rhBjl5rAiiCaQvam1E6ThdEMGQ9bopYDeo3WSx5BoJeklgWxmw7WdaQPT6GaIkjR/Qi092qDwJvKcuRGQD5iA1Ya+Xdmqr5Hat7GFP0Wy0tcl6dhvzMK5ujMWxfRJW/nwV8E657PGbD0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782414951; c=relaxed/simple; bh=KXwtNs5vrMjTCfjM/SAe7S3VaiWvP/VvYzYdKpdN/4s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p665dVBFAI+PZuLipK3w6MEe8+SmHzeMO2s+OEeL0gWN8SBdlAWaNgFctuYPLGCKswuRdBCWjQ1yx5YPmTtw4HugB4u+lYBvRJoWTH+XEzeHy9rF3RfxsHhNmoXghzjQRuMaxt1/ci7af43ilsKQuKduI3qBRjR433rVW5iPxFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ORUVndAI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VZXxjFxF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ORUVndAI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VZXxjFxF" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PFe9i72838448 for ; Thu, 25 Jun 2026 19:15:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=H5SCzfZY+cZ y5PgYB+6BQtHFEsZ/Uoh4sUu9a8QqdLQ=; b=ORUVndAIKrxwQHEALCGh5hLrjda svk+CMaVOz4ZYK8DUZxd9Eko5S4zLilyBdfSonXN0N8ac4NG/k3kHIEvQlUVnjJO CdfIzq67amHAXXHBZMTWIh8SBTG91jjQ86gJVnebJIxUgTzqs2pZAKph83RnDlA5 YX2ON/6nfLyrlwq8bimIgnHB78QfdxqCnCaPgaN85HBtBAk4VnFc98gL0w3G6JR8 +T/6rKDxA7TD123MaVwhvG9d+TrpeWCUd7Zo/kfHj13vmTQ2MDsfXRXXiGhYDYAJ s4mKvQwKvRcsYUlEKVWMEOj8W0rG5X+fDNgh2w7ikYEHZ1OW6SPJC6iC12A== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0uyqkuy6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 19:15:48 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c8894570b58so71750a12.3 for ; Thu, 25 Jun 2026 12:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782414948; x=1783019748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H5SCzfZY+cZy5PgYB+6BQtHFEsZ/Uoh4sUu9a8QqdLQ=; b=VZXxjFxFwv5r3g0wzBVI6k38mtZwB3gzx2BKh+SjtFdefT+Qp6xaH+s0Qm4vdRA+JP IqxM+KD8DI171qJywXgFfwWEmYH5Xcrebl0mxq5fzqwZoo+DipUrfcd/dr0ZAguEqFr8 +vUgwkZs2R9Ta8Jg73Jx/bgjJ4Mw1CwUilc2RmeuE6ge89BJZo2eakBBtXkr9JxDzGXc xWVw2mgkg6VNA4HyRj7h+Q10ZR2CAe7ooGsmUXFIoyZiDzXtO3UFs/XQYPBZZ0NfhVd4 yy3JctvKoCnff1frsfyK7euvo+bsyn7rhqbJDHzbjJf7PkDmJBuR7Z0KwwcUOPEKbXB8 +p2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782414948; x=1783019748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H5SCzfZY+cZy5PgYB+6BQtHFEsZ/Uoh4sUu9a8QqdLQ=; b=P7qCDTjiEaWcQu+rSEGukLgvBAE/G9uEzs1uwepNTwPmbd5FPhnqP98fpQRRLe7pF4 2fPlXxcDkOYKb8g/nkQ+Z+CWChi0CHTvxgEHb+4abjre0BJLy6Bivtrr7MvpqAEGe2Zt uum07/S1R2djEzYKNjkOiBSWIxf56xxh1AVyx7pHi9LvsKLFx/KibvX2QgkSVudxC1ra sE4Wjrcz58tWBhB7kpm+R6Wgofx35L30slk5GFxXx2nCU86CYhQJ1l4JryJpsLl35kIC EAs2bcrauMF+Z1YXGWtAIjbaDa2qPT52Z4SlS3R3Pb5RHlwJ40soYSS3Qb5DFNXB/aX5 3bOA== X-Forwarded-Encrypted: i=1; AHgh+RqmS+C0G1mrrw3gVB2YAlMaULb7ImJ9CBRu5852GoTAil8RuXzSQZV6MP7aIrE3UKVmmo+cLF8D/als+YE=@vger.kernel.org X-Gm-Message-State: AOJu0YxZE4fPl9LzSZ4bc4NIgO+1h1dqoDp+ZkRFzW4Xyk12x5RrlBYa EzHRBGDc8v4BCFuPkZxPZdOEMg83E0BsbXaqweqwz+pmN+QGHU+ko3JLbJ45b+buUqI9btzEE5z zuFCJp9BL9KRitN7hoAefD3fWPfcPgDywLDextryRLLs+BOsUCeLEwrxfCb9vzY/+2IQ= X-Gm-Gg: AfdE7cnsqLbwUf7zlqfxQBDXSTRsCbt0PZ/Z3oMoQsU9BGCten2EbPC8Gx4Cb9rlpmr WPzlwJdnkIemMa/bG0vONqkMYY6eUmJJjrvy4BOXo9yN0+NDvHwOkeLFQn9ka6kTF+5WWOKu949 FDP8K3062h1Gpymns81ZKCP+N341xnZt5GRvLT+JOKCnlZarD6u7BGcna1xYypAJK4QDOX6cF8F DMP6uFuySPpiK1RxV43sFp+DIqwrRiKx/Z2hUXrfHCPMkE/v9zE6MVGq3efIyQsqdWJ9ulYpBK4 8FFZXmsyHqyH1DT/bs1T9eV5enD3nbTqrqfKMm8tf8ELlpvJoVxWjmxqHIryua9KMOfm4MaYkOE BOyNTjwDJavBYrlUktkAVlJsFjiufYcuE1D21mUGXRa3iw0AYbjwDRbPKOQ== X-Received: by 2002:a05:6a00:1a8e:b0:845:363e:12d7 with SMTP id d2e1a72fcca58-845b3ac25b2mr4424210b3a.6.1782414947739; Thu, 25 Jun 2026 12:15:47 -0700 (PDT) X-Received: by 2002:a05:6a00:1a8e:b0:845:363e:12d7 with SMTP id d2e1a72fcca58-845b3ac25b2mr4424184b3a.6.1782414947298; Thu, 25 Jun 2026 12:15:47 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a3fcc773sm5423026b3a.11.2026.06.25.12.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 12:15:46 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 3/3] drm/msm: Validate lazy VM in GEM_NEW Date: Thu, 25 Jun 2026 12:15:35 -0700 Message-ID: <20260625191537.47965-4-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625191537.47965-1-robin.clark@oss.qualcomm.com> References: <20260625191537.47965-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Dx1C7JYz2mqbdwoU6M3raLh5_aWgMOuG X-Proofpoint-ORIG-GUID: Dx1C7JYz2mqbdwoU6M3raLh5_aWgMOuG X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDE2NSBTYWx0ZWRfX/IIdoPjXmZH2 VgFoctPj1Bb/xC7g9D9FgGXakZQ+suM+Ip7KJgF6FFg7kq10iuqWMyJ/GZv8Kd4sjRHpKyjowJS jp6A8eh7vZMmnc9LTATs+O9uCqd9QN0= X-Authority-Analysis: v=2.4 cv=EsLiaycA c=1 sm=1 tr=0 ts=6a3d7e64 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=VGCgC6sU4evaG-_1UnEA:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDE2NSBTYWx0ZWRfX0YaZDfDXjijJ eB6l5nTeUjmTei3JadRUSdvOosSzgYaiWJjaBL8uLRq8GJq5vUuwe+n0Ct9/SJ02TbEKqBZrcAe I01B/faQeqqMn4WrG4K5AajOa8nYLsIP1budAl2+ulAceo8M+SZ7p+RU9JkgwygQjAJAyejpAlX vAOviyMghKGnGFPiAAt+LqVDGXgfbTWf7See3Q+/sZMmWAI6sO8Dm9eDT5UEMZwbGbu0weogUPe P7IMNf2x7HyHZ2TzxZUVfk453WJkfeOUwPMftLy9xXPiJlfIyMR5Bf13wvEpsC+3qzGrf7fqTf9 Ezc6BRb6vEUByrFmQYFZbUbtLXb6L0h1ThCXdVRo2Fk0Yzowyyr/xxirdEO6gSL2ZdnHXGOoW7c Hr+LhQPjKa07JikM1KkN2pPNyROqTzazGTS8rn7+QRApEHHYrbrpXgSJx1c/JSRu7BPlVWkkyGa 2jXlJ8fUNNkCEaJBuRg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_02,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250165 Otherwise creating a _NO_SHARE BO before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: b58e12a66e47 ("drm/msm: Add _NO_SHARE flag") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index efd3d3c9a449..733a094354e1 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1147,7 +1147,12 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, if (flags & MSM_BO_NO_SHARE) { struct msm_context *ctx = file->driver_priv; - struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(ctx->vm); + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); + + if (!vm) + return UERR(EINVAL, dev, "not supported with shared VM"); + + struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(vm); drm_gem_object_get(r_obj); -- 2.54.0