From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4C4C377551 for ; Thu, 25 Jun 2026 21:58:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782424684; cv=none; b=FmFcdXdGT51WL2wE1Gc4EZxncgoNY9I/Q2+pnUDGu3hfPBTw16yEGp9GDQHBvkZe5PgSk5G2kVD7F+sinKGXTKurnFYD04zTIHJyU4INtPhU5OfFTJOjRlXPna8O0J6H1wXw5lNL7t3UWUUhijrfuR2vv7+o+kGhjZlTsLTGBu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782424684; c=relaxed/simple; bh=0ZSQQbQlHxoXzemDFX3axkGdUl2KuG/88n448GyArfI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PFO2vECIb836BriAdvpKop/3hO/NMyLUyeAiN1m+KexJwAUpqkpOsVZx6SAWm1FtZVZOUo/bmyt0RIGoifLNb9KS2nBCOtfM7buL9/GeDOhjVkCpZFdxshl3pOwiuzHczjKCfSBuYf+H3iWkv7GDJeDTYzWCIPpaLh2tsfW6Gz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g8c6a+AE; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g8c6a+AE" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49249072f03so1798285e9.0 for ; Thu, 25 Jun 2026 14:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782424680; x=1783029480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=uZznG8nXpNdUsgio0AWCkV/jSav7ySTRqhFzl8X19lM=; b=g8c6a+AEwgFmJNfumZy6IJ+Gq32+4GbdUiffTFxpg6Of3Vxl4ANW+i7z4G7nwzt0o7 Qq9VPRshMY9XDsKRc7+IMsjKkAog3zDVIfuxt3SzisNyDSr4xQp9NRuKIeq50bV00dcH 9fSph73MAB1LAKbSiMC6xCav//9WGzO3L+p+VdyLfSSuam7i9J4r8jGWPOKGAm/ssaHo oSliPHKxyE8FXhJidC6ZVFU9XiVIszQXCA+xx7PIOSjDxCb7nSn4ks/7aHgr1nj2AMZD +RqMWfpkzQutaYt+fuhQPd2TZ3xferMwIFNdKxUv/slmMRbfD0JwEyoQ2q7W82b7t2KB OCrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782424680; x=1783029480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uZznG8nXpNdUsgio0AWCkV/jSav7ySTRqhFzl8X19lM=; b=Jim3KBePKemTztzyrnntVOCOe/xALZH7gFee0fqROsGbUMofBr8WpCoPSNmsp9OpFP Z3siP/0j2pi5gyNphAh2c3eQZDDOWchkW7IhcKvovtc/tTPCc52aF7nuXg65ca1izM6p 8zKI3R+K1zH3w2WG8JLvN6z7M/DY4nVDQ+PzYEUeluSQcZERzR5XkdkjONm7XZu6cc+k oEmbdW30qwVrTG2o8aA4rY4iScjgyHb+o/XmTXUo35aezNyJ1ZxkLEXq1BGGP2Ia5gi+ su2lHMQmqiZUnhH60EX7GHTToBu0BVt+2VQUSM++IU7s/HculopjolLnJ32Uf9sJNEpb 8Nkg== X-Forwarded-Encrypted: i=1; AFNElJ8M6fLMLcU2mgDLpPwcmEftbw5FRliBmPoQA+iE4QTa+1VZynfkrldako1AV+wGP++0PYN+WNkzjw+EuCs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9YYPSBHLg0SBdrfHpnopp7sUrRrVp7zWdI28kZgTIbGnag9oN WAeW/y3ncVUzMUXlz74hzvzVtAtp/cDvB7XV7bNwDQ3P5r3lMOici8dh X-Gm-Gg: AfdE7clsKkr3Sx0hSImmfT+AedY0f1jKO5Bhbs5r25hEc3GtApp9sGuskHm0mNq4S// +igr3J27V1tQqFR3oGVQ/M8EQXrK1feHusNrbW6ExMIxk4gWRZADSfxhMu12C3ZHKeS04peRq4i pMAi8eoJOqTrMjxOwHWERjyKZkm0s7i3LaRiOIdWpkukSaZDHvbSWlnN/mIbm5WBqxXZOS1ragy MZyLpFGYoMXj/FjA+hSc6hspREi35apRZuy2brtcpFvvg4Uw4EaVvVYH/RqdDjmJ9rs/DfDTskP J9UeTAX/lhzvyW1BKllJ5um0r2ybRvkNdWG5/EwwKkZkK9PIsXCBRLdIiChweEhe5O2r5KpXshu DbgBVHzoB9pCEN1gg+GyaJevOo8Dz1t9V3vz6kfaezSbP3waQQgA2PzOlfVqRWIFAE5UOUtOcam zweXPTQYDzSqXS4HUvuQFPEA8ausDSglOOUUSo+C3IYKeRJIIHByFlbM1D6c9jKqNX4mWLckFiX dJ8Akzrk1/w X-Received: by 2002:a05:600d:8444:20b0:492:1e7f:d41e with SMTP id 5b1f17b1804b1-4926685aa04mr49083755e9.10.1782424680236; Thu, 25 Jun 2026 14:58:00 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-80-183-219-152.pool80183.interbusiness.it. [80.183.219.152]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-492690988e0sm27339185e9.14.2026.06.25.14.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 14:57:59 -0700 (PDT) From: Christian Marangi To: Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Ryder Lee , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Christian Marangi , Jianjun Wang , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] clk: en7523: add support for dedicated PCIe PERSTOUT reset Date: Thu, 25 Jun 2026 23:57:35 +0200 Message-ID: <20260625215741.3253212-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625215741.3253212-1-ansuelsmth@gmail.com> References: <20260625215741.3253212-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for resetting the PCIe lines with the PERSTOUT reset. These special reset are controlled by the PCIC register and are specific to each of the 3 PCIe lines. Notice that reset logic is inverted for these bit where 0 is assert and 1 deassert. This is intenrally handled in the reset function. PCI enable/disable are updated to drop PERSTOUT bits in favor dedicated reset handling. Signed-off-by: Christian Marangi --- drivers/clk/clk-en7523.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 1ab0e2eca5d3..a33cf2e1b76f 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -338,6 +338,7 @@ static const struct en_clk_desc en7581_base_clks[] = { static const u16 en7581_rst_ofs[] = { REG_RST_CTRL2, REG_RST_CTRL1, + REG_NP_SCU_PCIC, }; static const u16 en751221_rst_ofs[] = { @@ -450,6 +451,11 @@ static const u16 en7581_rst_map[] = { [EN7581_CPU_TIMER_RST] = RST_NR_PER_BANK + 28, [EN7581_PCIE_HB_RST] = RST_NR_PER_BANK + 29, [EN7581_XPON_MAC_RST] = RST_NR_PER_BANK + 31, + + /* RST_PCIC */ + [EN7581_PCIC_PERSTOUT0_RST] = 2 * RST_NR_PER_BANK + 29, + [EN7581_PCIC_PERSTOUT1_RST] = 2 * RST_NR_PER_BANK + 26, + [EN7581_PCIC_PERSTOUT2_RST] = 2 * RST_NR_PER_BANK + 16, }; static const u16 en751221_rst_map[] = { @@ -635,9 +641,7 @@ static int en7581_pci_enable(struct clk_hw *hw) void __iomem *np_base = cg->base; u32 val, mask; - mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1 | - REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT2 | - REG_PCI_CONTROL_PERSTOUT; + mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1; val = readl(np_base + REG_PCI_CONTROL); writel(val | mask, np_base + REG_PCI_CONTROL); @@ -650,9 +654,7 @@ static void en7581_pci_disable(struct clk_hw *hw) void __iomem *np_base = cg->base; u32 val, mask; - mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1 | - REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT2 | - REG_PCI_CONTROL_PERSTOUT; + mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1; val = readl(np_base + REG_PCI_CONTROL); writel(val & ~mask, np_base + REG_PCI_CONTROL); usleep_range(1000, 2000); @@ -754,14 +756,21 @@ static int en7523_reset_update(struct reset_controller_dev *rcdev, unsigned long id, bool assert) { struct en_rst_data *rst_data = container_of(rcdev, struct en_rst_data, rcdev); - void __iomem *addr = rst_data->base + rst_data->bank_ofs[id / RST_NR_PER_BANK]; + u32 offset = rst_data->bank_ofs[id / RST_NR_PER_BANK]; + void __iomem *addr = rst_data->base + offset; + bool inverted = false; u32 val; + /* For PCIC reset logic is inverted, 0:assert 1:deassert*/ + if (offset == REG_NP_SCU_PCIC) + inverted = true; + val = readl(addr); + val &= ~BIT(id % RST_NR_PER_BANK); if (assert) - val |= BIT(id % RST_NR_PER_BANK); + val |= inverted ? 0 : BIT(id % RST_NR_PER_BANK); else - val &= ~BIT(id % RST_NR_PER_BANK); + val |= inverted ? BIT(id % RST_NR_PER_BANK) : 0; writel(val, addr); return 0; -- 2.53.0