From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A8F37F00D for ; Thu, 25 Jun 2026 22:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426476; cv=none; b=KEv5+WACh9f/me1yT2M5QEDenpDsNqzvWhLD+gA1AdDhk0bUdJlA+k3yQ4Mi3jzMbn0DS+zh5pNB+NMdkPB/j8GpAu5KFFzvl8aeFRHf2WWLjR0j6pJ1cphWFp4GJiHRdSc9tTyrAAR0nhQgeCpKvnLx0JRnbRYbqu/mmWL4U5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426476; c=relaxed/simple; bh=0In8diwWOYQ7yP4vNQJ1muRLkMrsAa74ksEacPI3foI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RhpE2rhHAIXGrR88JfvLvoWs9SN++cSeuMOOPt1lIepkbmzUCbB++a2GbvtImnXtSZ1G+X+Km7NfYN3MaG/aqmzYZjCCdKA0mjMoW/FPthRJo/hgokjiiaoDdjKyFCGScN81Sux1Bjv5ldir7NZEE9L+tYtMXUSzA7B9R0gdnZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=myM28uFv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SESTfB9g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="myM28uFv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SESTfB9g" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PIQT7K1196410 for ; Thu, 25 Jun 2026 22:27:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=MBmzUwdpwOW 8f0OBvo8XEGa9qbPb7NiLUabU+Y9s2y4=; b=myM28uFv8n8UWaXZYxfhIindakH nWfZW5fPkLmlhcWJ08s4odSUI+PTUt1fJlDXs0xycsUgRkGNEVfA5HbmszEYwcZj +m6gnO5LaAJ8R1iMANajWnutUrFeETZ1APeysrh5Z+eq7YIPSbhNwjQtf9uNYYHi 5pB1KSrxztmvhZIoZYAsX3b6fhXkFvaByNs8oLsjpUIUpWJfjmwWioS4BhC+bNfR kJvVgfR+64mVNa1i6IU5AaGI2nSmTgaTXhzeEhc0uQsTKxEpCEo8mnZU/pnkoIO7 mkNRaO99vV576BEbFnDHkcaR0tUioYbqLGQXXaqogGjEHLOPtIdHMiz2qUg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f19m3rr84-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 22:27:53 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c804e38cb1so2050235ad.0 for ; Thu, 25 Jun 2026 15:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782426473; x=1783031273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MBmzUwdpwOW8f0OBvo8XEGa9qbPb7NiLUabU+Y9s2y4=; b=SESTfB9gkgPRghdkPwbPNi6jDZrFIr/y4n5zAk8LKVxeRy75iO2thCbHbFuALnaRlG PCW2TD4JklWIveP8/QYpwQKo8j+m1WLpSn8Ip80zpgKH2I8g7EPoy6MTglUmfOsRG8q7 BoFpGU14GxMR3b9bUBJ+bRoMObIymjprNjxEUzVMpPFzMfIB+V0H9NBWxB8kQF7+l2kQ 1U2Vo2BTcZeYtTKNkAvs2CytGB2rWLwo6j7TKxmLI0a5pzk6RJCCA0hk4Dj/WzEFPCqW tffi5llPb1RUpJ3T5aO0CyMfDnQiofjrqmCZGi7+Jcm/UUBNXUzLIfSaLov0QGzRhzWd D0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782426473; x=1783031273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MBmzUwdpwOW8f0OBvo8XEGa9qbPb7NiLUabU+Y9s2y4=; b=Pkf1R/c93SWHkWL9xZ03uNAm6R0EljFrXUEentVP4Tx3jqepD99g8L5GxfXn4MZUjU +1BYtpCO+BLZUHlecdDLf4GtoRAVxfmTmf7gr2RUqAaVblDAFu3RFN1A8ES8045HNfnh hMcU09lQ+8K3uJBOKH+irPTb9tlE0qk7hs/qds4EVqIAXakwbWs/I1qTUJtSbbIN/7oP 0q/KaQerBoxYSliks24GtwmvpGOxdGpWCaRFIF58mUgQURgJKUmVlYL6RefL+Yrvx4ph 3mQpZ3E5Ioch47vo9lt99cpAExQowybG2exsHJWpyE6qU9AO97IYhh+FCqWScmhvDNHC SF0g== X-Forwarded-Encrypted: i=1; AHgh+RqpDUYdRvjBwHLFSvUqrv6wL4xqrT/+mXVZmw1dWWon8IDs+CkSZ2q/V9WLTSy7g9cKYLvzAY+ubOPFXYI=@vger.kernel.org X-Gm-Message-State: AOJu0YzYf8kdE5RvB+1zx79LrcMs/xHMz3hOfMoquR04jxhzbVLpBR0f +OhttlzG1iM/dhc4Ay+d+4bhsjTfoKn98w5FB+HIxHMko8cxxHigrVDQZHUmbJ070pBmcK9VrT2 xQ1ntyURzW+8VyGB40F5bj8s6AekRktlQhy0lzIxhpYGobU0c08XTgE8fF5IbxMJiomE= X-Gm-Gg: AfdE7cksA095P+w3n92dgERR+uq5mGvicqt6zBtCXcaY1F6l80whRTNeI2z9x+zVD/W vJFdEOqwTsNsP8uzGvQfNVoVADRcksN8IwxKToTLX9s15yOQ+VoZOSw/SqKBDFDbDBGH8fBA2mC pb9HUF7lMAYVlring7Ho1S1GlgD/l7tJIo92PcbHhQi2zw8S99lHIUFGbzRMhzO6O5PC1uBmV8T gLEL1z0IAjuPuO/M1C+Ed5TzgJLv955tE641jH4Um4zLYhHb/qBfhwc+Gk4r64t+ls4o2qp/Qa4 SXG6eFeES0OKzG4HymxWeoNTKyu5jo/4SgkQO5G3KFryyem113GgYF1pTAeAqkZl9Lk/y63j7OM l+Byt3KkSm82ew0ze8+9UgQN7irKNc28383wfnvgu0wglzYhifj1dukZpaw== X-Received: by 2002:a17:902:c94c:b0:2c0:b081:84b1 with SMTP id d9443c01a7336-2c7fc681c93mr39522775ad.10.1782426472614; Thu, 25 Jun 2026 15:27:52 -0700 (PDT) X-Received: by 2002:a17:902:c94c:b0:2c0:b081:84b1 with SMTP id d9443c01a7336-2c7fc681c93mr39522645ad.10.1782426472202; Thu, 25 Jun 2026 15:27:52 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f5b04be8sm27459425ad.35.2026.06.25.15.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 15:27:51 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 1/4] drm/msm: Fix barriers accessing ctx vm Date: Thu, 25 Jun 2026 15:27:40 -0700 Message-ID: <20260625222744.22254-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> References: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfXy5AOmkbzKGNv RZO4j7fgsN+yMVVOr5HLT7OHwWon4PPAggFmhq0cR91YI1XHBzvvQMM4bmXestieiCcd8N6s7uU i6GA10XNk0st4Wt4+MJJHMzOgUi4TF4= X-Proofpoint-GUID: ONNeEa6B2Z-rSFVDKL59szBn9DB7Vcng X-Proofpoint-ORIG-GUID: ONNeEa6B2Z-rSFVDKL59szBn9DB7Vcng X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfXzswZq5ZSOqpK /fQYV3XJrqz6V170ZyrtiC79TBXhnicqrH1b97N4LNmCSmcXRC4LaCJLLyaQegNO7oIgBN8Ggee 2gwkeWQ1pV529IyazDHIHnntSSQWicnu95wuAHH4vhgGuWKlY6Z1ZQFBdcggSwogODw/U5bloJN bXYXtn2paMYjhbDob4JEzm912AaVGiEDyKgSa8ef84lSUJGudVaGb0pynuCuZWEXCzLff+r51No r4CwGC87cffav6C4M49fZgdyi5tN7S+MiFA/ZxsRnXPuon40kVB+l7mUziYxaCECSIY6wseyOuh 2sSL4z/mFZlamqX8zSCI9jxDK4Zw6Fk1x+TcqoMAAlQlGCkfMflHgn6fiHpXfVzU5BaCok/ATUa rPQlNaB17nVA3PJHUoYMARhmdrhRTCeB5BKtCNEDhmRIWy0dA/zBo6ZWOimYe7/hoDDnelijg/q 9Pv8DcAWmHNou7NPgpg== X-Authority-Analysis: v=2.4 cv=Vv0Txe2n c=1 sm=1 tr=0 ts=6a3dab69 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=PXeb_Y4BrUyLDKu8J0IA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_02,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250193 Don't rely on store ordering to protect us from caller seeing a partially initialized vm. Reported-by: Sashiko Fixes: feb8ef4636a4 ("drm/msm: Add opt-in for VM_BIND") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 32d5ebea2596..ec88155e0ed7 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -224,18 +224,19 @@ struct drm_gpuvm *msm_context_vm(struct drm_device *dev, struct msm_context *ctx { static DEFINE_MUTEX(init_lock); struct msm_drm_private *priv = dev->dev_private; + struct drm_gpuvm *vm = smp_load_acquire(&ctx->vm); /* Once ctx->vm is created it is valid for the lifetime of the context: */ - if (ctx->vm) - return ctx->vm; + if (vm) + return vm; + + guard(mutex)(&init_lock); - mutex_lock(&init_lock); if (!ctx->vm) { - ctx->vm = msm_gpu_create_private_vm( + vm = msm_gpu_create_private_vm( priv->gpu, current, !ctx->userspace_managed_vm); - + smp_store_release(&ctx->vm, vm); } - mutex_unlock(&init_lock); return ctx->vm; } -- 2.54.0