From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0FE3876B7 for ; Thu, 25 Jun 2026 22:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426478; cv=none; b=rcX5oOO6yOwfRWo4J9gIPMTdJPO12vE5NPOe06jq1fowMSgq2yGGIS8EwJbMr6hwTPk+b4Jz7Lcw3NWpU+HlegxEwp0cgr93Mzfr9R/sS6bqYESeqyt9g33Sx6TIDykzpYy3xArjuOzymZ8lDNkncwCeOlalNiHn+oynLeWSfpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426478; c=relaxed/simple; bh=/p15D98oWQTSYv5HabnMOz6/z7N7M8gk/34A7MEKXiE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pOeKQPANlfirnVbcQkYab0go9GCNG88u1ZGK79tEMLURo8Hi9FXbHBOCnR1kpBKYZQAwPZkOMs/z/S/HwBli12z8WvrtXwcBhpGrc3r80Mc2UH9aJYon+OzZ7sXF21+BTHMywSRsjiS8uIgtULo9qCDaVMbwurAD9lcSKvhlvhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XGqmr+Yi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ApWvPYp7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XGqmr+Yi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ApWvPYp7" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PIQRIO1196392 for ; Thu, 25 Jun 2026 22:27:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7V7Err/Z+6B Igi6OReMeeTwMA3vE41djVqJiMjm/22I=; b=XGqmr+YiJ+zTTAcHdKlbYzM616P AE3DNAHx4DTCD3ko3CAaH7JuCLhUzkfA5ERX/K17VQSHnZApjpprQDX7ENS95w1z ShZSdTDmCSShKrqNagoL6ZSFTepFlqNgOhzFzM23d8kdz35uwP4j4JxC2hUoVdTB xqm6cmfuMup2UF9u/JVtAn105Iu7se32GwwEy25Ng9wXPRBnVjiEob0UmiWzFhUW BypZHzO+dIMOuM6A0xzRGXPy8PqEb60wgyGqCoB+R8WlaPfZ+CdKMfkF+Fkvlc28 L5QS/EP1reV1lcOIJOV/cdtpEzLjxpdanm6nq0mZbYN7WZKmirrQKXdqQzA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f19m3rr88-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 22:27:54 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-845c6ab4975so74589b3a.2 for ; Thu, 25 Jun 2026 15:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782426474; x=1783031274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7V7Err/Z+6BIgi6OReMeeTwMA3vE41djVqJiMjm/22I=; b=ApWvPYp7cGTCbC6HH+LHC6qGg/LeF8O86mbHlpObQEg7a9yp4NDbE09qHKJ2gxNHkX HhlD0TaxuCXdljVJIofjerFIe+aH3MqScM7hLNmMR6wBZhbGwmZwBACv8k6faqg/1E3P +oxTtd6G7Vyfwe1Y2i4B7X8uxdsG5rajjNBztOsdVTfC74exScTnX/WtoMEfatu93lj6 cQlkQrwm3A3r+j+2sKkyaiLwo9KOhTzWmZHg3+A8+VGeXuCEodVFowZgVi0Afj4MnHqb Px1g9me1vDHsxEnY/cfcKsv7Ob9IhGpBa1I1uuRwjGV5LGtKGix237LHguiJmsj5K1Yg FNrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782426474; x=1783031274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7V7Err/Z+6BIgi6OReMeeTwMA3vE41djVqJiMjm/22I=; b=iezsxiuft3yGeNlzx51+O1mtI5DROzBeSj8av8lhgt29RsetY8sZTkWHaKnXQ9RIJp 3WwWNBBdfFU2wV9mzgP1KHf2GCWNwdMn+jO/CN7VVeSw2NmMvZsaSDd9tl3r6F1B5BJW ZtvSfY5IqqrXV+woO745pfLIMo59Pk4oUo5hn76SbfBmCX5wcvnATvNYDbxLJg8SouxE VEQD9CY6n93nMC2SjwBkK4e3Hy5C0RJJzdc2cOaX0BRtRrPsbaQlJRn9Td32KmRxQZqa /c9mJT7jWmxPtLqQ+N6uaYtY1wGVnoC2HMzOyzOMW9iL2D3wiCEyGDbXo59fKIJmmuaD O3ww== X-Forwarded-Encrypted: i=1; AHgh+RqFJWpp6VbC8rwpVS2BreBSlJtjfQlDL4kXj54xEWhPIjZ7Z6MbaP77l7Nvvk0SA9nM78vrSo3TJYWEnhc=@vger.kernel.org X-Gm-Message-State: AOJu0YyNn2Oc3ryRJUPqXf/spsSqF7DiB0dsn3gku0Qz6Fgfzwtupvv5 TyDf+9E8zCXHT015rwc4RV36ANLM613NJceTFBVc5T3LKz0Bn2STFw6GB93+q14cGN9QjQUrJIz IPeZdnzzoD5ymuL5Tub2q7l59qx6yUr1ObmSwN1Y1zyPl/MsHzB2WC+lG0EDErnKRMPk= X-Gm-Gg: AfdE7cngXZOsJ+RkPW/D7+aE3YnoNDkfUxfUwriSR9kYAcSOuUdsJlc4Jks4/jiCYux fV2xTqSnaNWGn1AfKmzW2WBBHFHn+Ws56cODCmMdWPbC0zdFZceoLHQhONBAx+evNLA1oA9NTLm YpmJz33IBzybG0p0Q6/hN7juPSDKyMOgbx1mu5Fi5wQXDl4LiTKlwqPExyPhAMqVPExIMIuTRIt /vDu3SOke0kfb0lwQjzRcGuWwMRfNnwSFMXpNTwI4BRrNc9GDlkliPUU6ujPzargX0FVSc28tGK QsA2OA6m0SAq/25pwSqrBMwpT9tV7E0m4KZhm+88ahMvv6LSbawy/tjfK6zr397umDIV7eeBL0a eUMECaEl5SvOeYA04bNEr5KZd9sE+jRnp+xJjHrX/El06U2DrjDWJt6PU/w== X-Received: by 2002:a05:6a00:94d6:b0:842:66af:5bf2 with SMTP id d2e1a72fcca58-845b3ae5703mr4586734b3a.38.1782426474193; Thu, 25 Jun 2026 15:27:54 -0700 (PDT) X-Received: by 2002:a05:6a00:94d6:b0:842:66af:5bf2 with SMTP id d2e1a72fcca58-845b3ae5703mr4586706b3a.38.1782426473642; Thu, 25 Jun 2026 15:27:53 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845c104113esm866863b3a.57.2026.06.25.15.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 15:27:53 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 2/4] drm/msm: Validate lazy VM is created in GEM_SUBMIT Date: Thu, 25 Jun 2026 15:27:41 -0700 Message-ID: <20260625222744.22254-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> References: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfX7dWRI9rHiE9B bXm8aa194BA8Sq4wOYF5FpkI+7qpKpxy1uuBxibC/KsosHzCxPmqDuJQyLVEyDrAwFclMgFpsKA YcUwr9iFcjdOIMOl5VecUR2V9S1prpc= X-Proofpoint-GUID: Pql2Ab1To9twJM5NSN_W1xQz6vHqJFN2 X-Proofpoint-ORIG-GUID: Pql2Ab1To9twJM5NSN_W1xQz6vHqJFN2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfX84Eh6jfpaOUh 2tc+FmYboFtdS5NAfQVS+T8V0OJDPPYCjaO81Ssm4VofdWgbUKB38+mRca3wN87JCZkHxt8EeE9 OAmP+p339juEwdCkHYzfp7ZkY5GvFJzpyfmHrOGaQRO+89hQZcgHGR5XZ7CWXF/pbseGyVIX8+J 2XN2h7rXPxtxsn6jaAErq+P/8S8MdDZONoHlFr7aM8xpGKG1haRSC550QthwSYltPol4ZvlgFpL Oau3ONMZQsZNLFMOK0GT5lrUXWhEy6SDmzol7S/mSl5ikHh5ELDEA/7AL4XKH2XJ71QErd3MRe4 +Td/GU0uL9oEs2/ZtD7vebsozYsNNOr+0KNdOoahISGnGf+COWO3m5/5EglKPXy+g17bSvW/P81 3ugCEsIPe04DuFqaZqMAEKQbNiB5coD6Rws88hqcscTVFIhpu6GMYv+yOZ7TBpeH7uakyY1oFZD oQIkIMig7/kaqKeCFkQ== X-Authority-Analysis: v=2.4 cv=Vv0Txe2n c=1 sm=1 tr=0 ts=6a3dab6a cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ZH_LIYEqPuu6AAuj7cUA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_02,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250193 Otherwise a GEM_SUBMIT ioctl before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: 6a4d287a1ae6 ("drm/msm: Mark VM as unusable on GPU hangs") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 3c6bc90c3d48..56929e821200 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -30,7 +30,7 @@ */ static struct msm_gem_submit *submit_create(struct drm_device *dev, - struct msm_gpu *gpu, + struct msm_gpu *gpu, struct drm_gpuvm *vm, struct msm_gpu_submitqueue *queue, uint32_t nr_bos, uint32_t nr_cmds, u64 drm_client_id) { @@ -66,7 +66,7 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev, kref_init(&submit->ref); submit->dev = dev; - submit->vm = msm_context_vm(dev, queue->ctx); + submit->vm = vm; submit->gpu = gpu; submit->cmd = (void *)&submit->bos[nr_bos]; submit->queue = queue; @@ -554,6 +554,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, struct msm_drm_private *priv = dev->dev_private; struct drm_msm_gem_submit *args = data; struct msm_context *ctx = file->driver_priv; + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); struct msm_gem_submit *submit = NULL; struct msm_gpu *gpu = priv->gpu; struct msm_gpu_submitqueue *queue; @@ -572,7 +573,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, if (args->pad) return -EINVAL; - if (to_msm_vm(ctx->vm)->unusable) + if (vm && to_msm_vm(vm)->unusable) return UERR(EPIPE, dev, "context is unusable"); /* for now, we just have 3d pipe.. eventually this would need to @@ -609,7 +610,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, } } - submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds, + submit = submit_create(dev, gpu, vm, queue, args->nr_bos, args->nr_cmds, file->client_id); if (IS_ERR(submit)) { ret = PTR_ERR(submit); -- 2.54.0