From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C785386450 for ; Thu, 25 Jun 2026 22:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426478; cv=none; b=iDB12b4VvgkbU3hbdjHD5SV2kdDFjy2Dx/LJsKiIZrd6hpdUn20bODQleEaO/J97irOwL+/su1z/9FWXmwJ+2DLHgEuEENU013hc1mjES9boHt+Aptl3o3yd9IHiSayPthPUX+lsSjhJuEkWGgxMo7vAnl2D/6jukDNDwZhmy1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426478; c=relaxed/simple; bh=78QZi+j6Y2VyxhafxfaICkEDWefl3Eh8NkMxLY818SM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ITtCEeV3MoniwBglegbbEWNQrDPioo/XJqZ8uPDGTazT7gLpvlL+Lq8LvPRzK9dmkI/QDQ8xPZ9Z++Es9IbIclkadu8UW+5GNsqOZ2MOwvzHVpfEiYqJ7ARFyADhle4xPVVhqfH8gLT5N7ZHxYUzKPe8Jd3uijlM+GbGQDwgp9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j9FEKbYs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i+d9SEfp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j9FEKbYs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i+d9SEfp" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PFe0TD2160437 for ; Thu, 25 Jun 2026 22:27:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=UhRPqBPtVcz hZaFi2XBpS+shrYhW3crlCtWaN/PGJnQ=; b=j9FEKbYsqGek9p/xF1e2n+le2BM ZuuU0Kyskzn0t3W7r9giUcqb/ZatXEkG2pASCI41rYD0YmAeu884us7ZYLPVi0aB xOeE+mL5eQV7l2/cGAynGCdGYV65iH9ddTIGp7p0tnELGmbFCNR8gtpetZJBkzk2 mkYIlWHhJSpzYHn3WdE2G0YpuEKq9FW5rhvLGGtzMqxlJIdp/52pRfsckRm+ODLp Duvq8VheQM7gWAaO1osEpi2Ng9I9t4Vpp5pA+DfSs3OUo9w1HTvrmZIrLZRYrQwx /0JFA8CBqoWt/AOX7tbcUkK+hqrFd6WBqttnsFabZP4uiZads1HS5Nlnhxg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0ymv3fue-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 22:27:56 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8453031c57cso391878b3a.0 for ; Thu, 25 Jun 2026 15:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782426476; x=1783031276; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UhRPqBPtVczhZaFi2XBpS+shrYhW3crlCtWaN/PGJnQ=; b=i+d9SEfpf8E5uBPCoivnz0/1n8lhZaYGRXTo0ACcoG8Q5U8zTpXRgwXc+dTKwamXOm k4dxCZGguAfy2QF4DS5OYF+ywLqkqzHDZc0J1iGFt9z8HffRLvgczeHHftviE5w0MM9Q ye5xlruimIjE45YR1Bj2fWJhlka+jSYszYVWMyBlCaf1Ov4bKlLW+59ULLCVtWRvT2i4 RfVwhvShVGq+4VMiNCREEW3cJEYBX+Gq1CumaZRYw86MqSjDsbcdkqZCcD0fz/CI0Qi5 TLQERr9WQ+JM57lxOccG9C18/DXYxD6/0e+fR+u8mSzLNS/7oZE/3F6253vGsKnR30/y lVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782426476; x=1783031276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UhRPqBPtVczhZaFi2XBpS+shrYhW3crlCtWaN/PGJnQ=; b=L5pG3abb1FZDX7oUMks9XenLTmVi5zTUOfkkg7W9Vi8mg93BVxEDc0A/iZFkFgpYvc sI+G3gXqpoCIFQYfZnmsHHe8NC3HwF5P8NAHoWYkk1LCPZykCxVJQZV7a0Vccl24Cvlx teyVqzyAp2tN7wbFb3zWA+UkPg8K6nFNTwLLDo27zTEDMgmx8IgLNCccDQcxs2wxldlC Cg9ceGLp9u8YDKBsJiA13pkUITGCgLsStlX1Tg5DmcskWWmm5fcaW78aG3kKEA3w2K0T Zwm4qWaJzlgUgMEa01CdusN8cZ0nc7zkYAmL1S+T/h1t2wFxHVYYioiiyXg9c/+qWEeX 2tGA== X-Forwarded-Encrypted: i=1; AFNElJ9rOczU6XtajOE3OJ2bfsWlk2zKBLZH9Jh+IJM+pRJo3YwXzqWeGQmVAx7g8paaPFKehPsYONuqZdohd+A=@vger.kernel.org X-Gm-Message-State: AOJu0YyjqNb+dPI593HDqvrZtBsJlhOaZ2IkxCImHIC0GiJzn5wQrhTk qxxlj8/qJGb2b+QmW18PEaXuDHeTlVjDSi+TORRmnj+63GypyN634F5YvQJu2zlyG+5uWl18hr9 p4VxzLoNzXnDs93ceBjy57qFLriLnbJ2nI+Eqm9GbBUSnGuA8rvNaoAFH1OflXU1OCC4= X-Gm-Gg: AfdE7cnxPs4cUWeo80t1klhB7azhZ0mnx6YL2Fh8CBX0BJTYQgxvkMhmvNYxAwsLhkM B3x7rrEfM/xbG/QlF1Hw1KG/NAm1LtD5BxwR3KnRK6uJ7ptKWAcb5FeOyqptEPofx4pXhdsmVHM OmK8uabR5Tg8gTXnUb9gejAUdCG/4kcN1yY1AZSNqsDpse6gcVNjFmv+36D3eG6iEV/tNb5invn 7H8EXKebCj523rLNuuuIER8chw0rRJmaTOFqEnoAFOAuqjThnPHGXf9BvTS6r9bumjuPhUwPHAz owrG7wum7RPYbjapK0cJTpScFpYFu6lYKLld5ImPBe8V3UHIQDFa7Ghb4pIbEi7Ty8HmqvZxx83 LSm0Zle3LXnzM7tePXIuXexNpYXsKjxSjiAuFOURX13HjUC4fCifAbIlUrg== X-Received: by 2002:a05:6a00:919d:b0:845:beb1:f05b with SMTP id d2e1a72fcca58-845beb1f4c6mr2206054b3a.45.1782426475786; Thu, 25 Jun 2026 15:27:55 -0700 (PDT) X-Received: by 2002:a05:6a00:919d:b0:845:beb1:f05b with SMTP id d2e1a72fcca58-845beb1f4c6mr2206022b3a.45.1782426475388; Thu, 25 Jun 2026 15:27:55 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a3fcc773sm5625925b3a.11.2026.06.25.15.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 15:27:54 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 3/4] drm/msm: Validate lazy VM in GEM_NEW Date: Thu, 25 Jun 2026 15:27:42 -0700 Message-ID: <20260625222744.22254-4-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> References: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=DqBmPm/+ c=1 sm=1 tr=0 ts=6a3dab6c cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mcLY6QNbnPi337aWdgEA:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfX6/qK/tkF6G9/ 7t4xx0X0rintMlG5XH0EUdZPXb3+ddizqlPp6tzmdKUhACovJbtcwTe3VXNAoWSmg6DrphR3upJ bUQRltfgAGftBAB4Ww0Cs8Drqo4sDSw= X-Proofpoint-ORIG-GUID: L9Bul4NzN_B9Cgd29xhhF3JPtiT9HcnN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfX5Q1aPIl/TaL6 5Qw7mtMfPP/iH5197xIIE5gJs+TO/ANqQ2rLifKqSmFioZY7/LYh9Qu7UHeGuQ8sQ36arSGltum Gt+3urtOQ6zUBa8u2txy5McsTZSDVu6hWC1s2VjzAfQ79qK/sDh5H24V8iYF2K32sRNSb192HGa 6p6FPdh4f5AsHVpQU7tFu3pMU93qCcHU6mFSCG0YNi2C7zvCLMRqIefG5d3YQenQVbKX6CjQHem QEXtVCmo041xQEp/nH291AvBAtSz3x9rYaYIKaZapzQtnui4QCm2LaW9U9C6h93+qrfNJ4kLIUO fw9s6UBgXrsGBGY1x2ehYfxGnUxIuDEh4zuWp0tsY4XsxPqa2ZwcRfesaBZnDQx4h/t1jkFVBn5 QK7zsar5/w+35pvuTw1v5SvqDAEZ7VsJronK2ks5r8MjE2ZIRqoxUkvoj0xBZXp+KTJFGdsEjw4 DjP+Cpv4bpTEQViO9Sw== X-Proofpoint-GUID: L9Bul4NzN_B9Cgd29xhhF3JPtiT9HcnN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_02,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250193 Otherwise creating a _NO_SHARE BO before any BOs are mapped could cause a NPE. Reported-by: Sashiko Fixes: b58e12a66e47 ("drm/msm: Add _NO_SHARE flag") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index efd3d3c9a449..3ff0399c020e 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -1147,7 +1147,14 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, if (flags & MSM_BO_NO_SHARE) { struct msm_context *ctx = file->driver_priv; - struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(ctx->vm); + struct drm_gpuvm *vm = msm_context_vm(dev, ctx); + + if (!vm) { + ret = UERR(EINVAL, dev, "not supported with shared VM"); + goto out_put; + } + + struct drm_gem_object *r_obj = drm_gpuvm_resv_obj(vm); drm_gem_object_get(r_obj); @@ -1157,6 +1164,7 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file, ret = drm_gem_handle_create(file, obj, handle); /* drop reference from allocate - handle holds it now */ +out_put: drm_gem_object_put(obj); return ret; -- 2.54.0