From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EAF37CD37 for ; Thu, 25 Jun 2026 22:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426481; cv=none; b=GkNbQg3xA1RPBRAghdWIBUT7B8VxwztbsdwQnsjwBQxGnTvo+/qjE8G0mdPcReex2s4dB2fi/UjrQq6gPPWVwgClZnQ8GkoyCrZ/ZvHV8wvRtDP/mVs3CqF3pcDwnJDI00loqb9qF8gS4SJmFJL9OF52pjZtix3zYYf9GId+zAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782426481; c=relaxed/simple; bh=UJzeniTUGEpiHfu9ZR+orQWkw+fF+r5Mn+nUSwed31g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nw06EhBH1G/2mSRizOUexINY8lYvk9CSMLjd3kvq2FfkzbhGaDSFhfgISfi0ZnZjEntqlihprCEt8CKCRIR4Uhk1SJEso1OogF8g1SrqLhv7HG4FwOq1KoUkhI7I6Z+IAlpXBMQsvCQFW+I1I6aFYdpiuKxWClXh+zFZ4nTL6dU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GIQNh9vj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MwzO/EJs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GIQNh9vj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MwzO/EJs" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PJkQhQ2809117 for ; Thu, 25 Jun 2026 22:27:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=CrqeyYgLg0O yN3yne80Nf16IikyqcRRNAcpAakZrOf8=; b=GIQNh9vj7976s1PV4uK6sNl1Ymh Irj/v3lo1FXnt0baIlR0HGIalpQURhWwD7ZF10IZfG4jm+Q2kmjUzcwmmbV682j9 wJ8V5S2skww2vmG4xrbktPSs7vhsAIQY8/+GliP5WAxKn5P/TRGbc803FgRjrsEu mOWUrbBUymUL5pG99Ef6PNWv6cyJcmLrmBikJRkW8brsLO1u9W3j48iJAhe/9AeO ngQwZ81/zcVbxPmMtYDjrVitEc4McFZ6Hu3NBJe/eQPQXwFqL+FlUi//jqNDckkj bfrtXSlTC4vwTfXhZR2C5aIYElL7raKT2CBAmz2QnPRVtsauJi9aQsxMsww== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f1asj8f2h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 22:27:57 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c80be91ea3so5138975ad.1 for ; Thu, 25 Jun 2026 15:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782426477; x=1783031277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CrqeyYgLg0OyN3yne80Nf16IikyqcRRNAcpAakZrOf8=; b=MwzO/EJsktPAX64ujRU/4vHPYOtnaw8tB3zsJYGrUh5MZCRDj/l81dSjTM1RkjaeSA JIifSeXBaD4huurunFhr7EmZGkFhctkIrqFqppJyVZbgfnnrycijB4BbSB/ZRPq6DCv8 XQV/kP0wfWLMZ9RxiSyW3Av6SouWuoxlYJCDoM73x4NsDAgIb3ehNL5SE+iABNDrKELB tz5CdN9voU6N3hTjBfjPk53nkHSaccDO2fb7H8Ebnx0EyL2xucepfbnrSsVrOLKH0QWo FBli8GBt9w69iAacr6uZ2ta5KOPXYJUS8PSd6uWg5nnHZJBDBYBIgqwH8Hj+1HQMAOkQ yS5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782426477; x=1783031277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CrqeyYgLg0OyN3yne80Nf16IikyqcRRNAcpAakZrOf8=; b=O58i1xYR8X7K1+DypucqJgriUrminInvBVJ+QC+ZyKCpGdqn9Svme+Nliq6e9xRnbH lGAbjPoexM3jqhejXYKy4vjWKQWrjLC/daC4+5s2x91wy5D04adtN5OEahQgIp8z+J2H AV8mDkJAu8+vITASEBFzu3qhSY8PEDts4U01O0in+I5y59V3wX9dnYq9ZBXASAm95l9v 3gxqiMhS+IasogQFOzO0iyQYTjiSssMeWrzsc3Oy+6K6tFF3I04ieIptokcxQX2lP2Sb fNzTBZoXkPMaKLhELeNHq7ORg3CzHFZZh1i1LrPST+reoQOrouRUzw/inqHTTW4LCqUF /oCA== X-Forwarded-Encrypted: i=1; AHgh+RrOvj3fEmpbDtzulr4/zrRaonBVZXJTEk4b37BrQO57bKCByEf3ljukGpqqbIruHaGysKfxSUeWXyZEquA=@vger.kernel.org X-Gm-Message-State: AOJu0YxCDXO17rInH/Xx58KZqPkjVdW6WZWYDr5eQD6GUWRe9tFQewqb xLhgTWWxTFj2kG7ZrPi58fboYHtNIxAw01XkGNVVQci+jdbrG40x7RGvNRXxQqlalBac0zWGDly kk5D4LPk/kwULDcJqaLcuzwt+gxdLn0hZSWpbO1otKTFbSqtRiqQxISPVlbnfEl4g8ic= X-Gm-Gg: AfdE7clT9aFF5gFv/0PbTrLkSLx8uDe1ktsIl4KwFORrriKF93mohkC/ZyPDWWgCe6B /Cfdkrsd9GNrAHbV50Ipkt2M3mQshWlpLG7N4yi+8aUUIMUIIs7eXxFh/OD12OqsAJ2zTypCN+G T8RoenaFvv1sN8dcuGl+clpXYy3zh+sf8zl0QkIbhvWqfyGJpkeR/mft6W7FqgPYKneoU5YsqxM Hm8lO9XkQqitUoVeRRRQKWNhC19uYItJ6OzUypuvlNgsOaxp68JOMhfu5ui8jYU4Wf2KPyYlDDt DctFthrcjLmE2FoeL2hRaSA6zxKiij9H2GuiNbCLvptVjciZwzUUYrH62OKbQaHmZVm6epDpzZu cIiYAFL7I3WgNeq7KYx4PFKPVH6JSCvvpvASrZlv3ief1q+4j7ITN1ilBwA== X-Received: by 2002:a17:902:e78d:b0:2c6:90ec:f601 with SMTP id d9443c01a7336-2c7fc632a17mr47006345ad.8.1782426477248; Thu, 25 Jun 2026 15:27:57 -0700 (PDT) X-Received: by 2002:a17:902:e78d:b0:2c6:90ec:f601 with SMTP id d9443c01a7336-2c7fc632a17mr47006145ad.8.1782426476790; Thu, 25 Jun 2026 15:27:56 -0700 (PDT) Received: from localhost (c-73-37-105-206.hsd1.or.comcast.net. [73.37.105.206]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f63b24a2sm28025595ad.50.2026.06.25.15.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 15:27:56 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Sashiko , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 4/4] drm/msm: Fix per-process-pgtables check Date: Thu, 25 Jun 2026 15:27:43 -0700 Message-ID: <20260625222744.22254-5-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> References: <20260625222744.22254-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=TO11jVla c=1 sm=1 tr=0 ts=6a3dab6d cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=19Wyn7e3V/0aNffMjNCMQw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vtH2vi951kckHO5NeAIA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: H03AF2OCpNGj2UjuONutZOdfyz9ReTnF X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfX8CgNUZ0yRTfU 8Gv6RY8Evfcy4zz2Q7q+lwXNNPcHsmRz9CYN3dSKB9mV2Qp6HYauJPQOVCH7XY4qoagor29frmt 1LXBdyEwU2eo5itCBH8wtea8FbvLmMg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDE5MyBTYWx0ZWRfX6WJ5K31KVQGx +KyfekUfzmn2HNFelxyqsLOl4RwxTeoc32M33j+zYO7HSCg29aTG3D/3mxN3SZVPGinCCUpeyum zsOU0QJCPKNWmZCzG/TGS2QPJCVD4Y58EmlVzjdlkZd+xZgWigyyx88lCULx5gm9nkcAx2eJYeP xvA9VaGgpunnl+PPSZpPeocyB38CPzk1UmgT8g80maWcXv5jUlQYKwkaJExoAriTTPD/obQYdwA tfm0wreX3+wiTY1Py7/PJbZSGj3IPjsKUXoqXfI09JtmUtjgD7Sz3E4EWkRkqrUdp0X+Oen5ouA 4uwubDBri4EGX9q3L5d2gQ76A8Psbqbj1mmcfpVe+4DedU9iIpmXZVjqinlp8qdIc6NtKTUtOJ2 xrpzdP0JD5hk+ivQRRbJuJTkbghKAU5ua1J32/MERAqEJySxRlOzJA3UOCNB0XRBGEH93y/R6kk Mud4xWED0+zTirihBgQ== X-Proofpoint-GUID: H03AF2OCpNGj2UjuONutZOdfyz9ReTnF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_02,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250193 ctx->vm should not be inialized yet (or if it has, an error is returned immediately following this check), so this isn't a valid way to check for per-process-pgtable support. Instead just check if create_private_vm() is supported. Reported-by: Sashiko Fixes: feb8ef4636a4 ("drm/msm: Add opt-in for VM_BIND") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index c62c45bb0ddb..bff2a773c0d4 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -505,7 +505,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: /* We can only support VM_BIND with per-process pgtables: */ - if (ctx->vm == gpu->vm) + if (!gpu->funcs->create_private_vm) return UERR(EINVAL, drm, "requires per-process pgtables"); /* -- 2.54.0