From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E0AB3803DB; Fri, 26 Jun 2026 15:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782486848; cv=none; b=RHYyZTwEexdqQUUNd5/CMhsxpJkljbdP/B0N6YMgGwzNgrHrDeWagntONnOdiKMPo8DmSPI6VNKC6cLZJfjhCgZK/5bSyxUJ7n04tQ+XLp2An90GEpNVjTIy9kOKlzNfmd3clf1geaRltK5WfdRp7IQjxG+UZnwWoABt5llKcJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782486848; c=relaxed/simple; bh=zhyxM5wg3b8dLCYsy8jC5g0uh0IufzUrGIs7mL6WjYo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BPmhkPvQyhQUrdACT4gjql4q3F2HVXhZmV1HmIjviyNu37KlGT1U4SYPLed51n2VwKkfKCaLRmzBBDqC9zXxVsKSAEkC7X188f+hEY3fP0uXvw5Ic4Y0/p7fhP9Ygr3ORx9YfOG1pv5QJmx1q7zci+ApklJQkqIzhF1y8/x1uc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=YZ9gz4/V; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YZ9gz4/V" Received: from [10.1.1.1] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 501511AE5; Fri, 26 Jun 2026 17:12:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782486778; bh=zhyxM5wg3b8dLCYsy8jC5g0uh0IufzUrGIs7mL6WjYo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YZ9gz4/VXbh9cg6S1gtjBjTZ4EtzGXShC+Cyd6vwMG+e+X3RkfQ6cOJ+BZiOdeGUd LSRvhEK2ixmed++CHcZUI9cPpNscWpy5yy67a8VY3CPvxqpQF7hC9oGFGTRYrO/d0b x3eEQcAvIxqgEM+hKdK2TZyDK5HkpUXGweOdc1Do= From: Jacopo Mondi Date: Fri, 26 Jun 2026 17:13:24 +0200 Subject: [PATCH v2 5/6] media: amlogic-c3: Implement per-block validation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260626-extensible-stats-v2-5-41fdd5cf728b@ideasonboard.com> References: <20260626-extensible-stats-v2-0-41fdd5cf728b@ideasonboard.com> In-Reply-To: <20260626-extensible-stats-v2-0-41fdd5cf728b@ideasonboard.com> To: Mauro Carvalho Chehab , Daniel Scally , Keke Li , Antoine Bouyer , Jai Luthra , =?utf-8?q?Niklas_S=C3=B6derlund?= , Ricardo Ribalda Cc: Laurent Pinchart , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2645; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=zhyxM5wg3b8dLCYsy8jC5g0uh0IufzUrGIs7mL6WjYo=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqPpcezhiBOFk257awnQ6iNwesoi8TqjxhnF5Dm 11h2HhL6ASJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaj6XHgAKCRByNAaPFqFW PFq6EADE1LDZ/NL8xl7x9LSaHJ/pQnlrxsAd2p/NzDUDr51CcC7ipeAuMzx1y+sXF9bI682205A HE8rv2YFLpUm9ibR7ShcNVrjfoeS/CGnOhNcIOCTLXR4jurUntcasdVNAimrbOivwcs0tmJT1dN bKPZsMj37hAug1FiTc35AeBLUKYfV8KNSqC9uy10p87eN1ENTJin4W6cGaTcHn5fsO/cjn9ytPg VZdABeTH71LlqD0c+X7WCNVciD7LCQMb6RPXVekKbShNvCzqELyINEuJLC6lBYY3jkAfAfi6WpC L/FCVz60O4pOoJnMUZzUHupXAKmm0yuDlKWiwNxH39DxjuSJ+vNOty5HLhq4DKNtF80sOOsucWI gcgTfLMdvBH21NZNIeRlXtaeRs1fweI3chC6zIQO19BvbjrMzJ+tl0OCttPcKfgSXqYC9h8rnqV ZkYX4HPaaeNnmAL/DxKRL3Vlxk/97Qlu+Uxfk71+PrsSWaUkM6Q8/YqLSSuEiFmSc4rflTXqbBO icn3gYS123onOGbTXHwKZ0H27uCR7RLE1QxkG1exbbzNUZpo25BshAWnThnrwr7L3iGRaOhPdUo VEAVkki7F3CLtQfJi/APzxAdHkQiWSMyMQaK3jII/wnzZ7oYZemVr5TIbuHon/ZANH6/nxEZPnm PUnYf/KwTZCiijw== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B Use the newly introduced per-block validation in v4l2-isp framework to implement a validation callback for the AWB and AE configuration blocks to make sure the configured metering zones do not exceed the hardware capabilities. Signed-off-by: Jacopo Mondi --- .../media/platform/amlogic/c3/isp/c3-isp-params.c | 42 ++++++++++++++++++++-- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c b/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c index aec3eed0e443..ae0777a20bda 100644 --- a/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c +++ b/drivers/media/platform/amlogic/c3/isp/c3-isp-params.c @@ -535,16 +535,52 @@ static const c3_isp_block_handler c3_isp_params_handlers[] = { [C3_ISP_PARAMS_BLOCK_BLC] = c3_isp_params_cfg_blc, }; -#define C3_ISP_PARAMS_BLOCK_INFO(block, data) \ +static int +c3_isp_params_awb_config_validate(struct device *dev, + const struct v4l2_isp_block_header *block) +{ + const struct c3_isp_params_awb_config *cfg = + (const struct c3_isp_params_awb_config *)block; + + if (cfg->horiz_zones_num * cfg->vert_zones_num > C3_ISP_AWB_MAX_ZONES) { + dev_dbg(dev, "Invalid number of AWB measurement zones\n"); + return -EINVAL; + } + + return 0; +} + +static int +c3_isp_params_ae_config_validate(struct device *dev, + const struct v4l2_isp_block_header *block) +{ + const struct c3_isp_params_ae_config *cfg = + (const struct c3_isp_params_ae_config *)block; + + if (cfg->horiz_zones_num * cfg->vert_zones_num > C3_ISP_AE_MAX_ZONES) { + dev_dbg(dev, "Invalid number of AE measurement zones\n"); + return -EINVAL; + } + + return 0; +} + +#define C3_ISP_PARAMS_BLOCK_INFO_CBK(block, data, cbk) \ [C3_ISP_PARAMS_BLOCK_ ## block] = { \ .size = sizeof(struct c3_isp_params_ ## data), \ + .block_validate = (cbk)\ } +#define C3_ISP_PARAMS_BLOCK_INFO(block, data) \ + C3_ISP_PARAMS_BLOCK_INFO_CBK(block, data, NULL) + static const struct v4l2_isp_params_block_type_info c3_isp_params_block_types_info[] = { C3_ISP_PARAMS_BLOCK_INFO(AWB_GAINS, awb_gains), - C3_ISP_PARAMS_BLOCK_INFO(AWB_CONFIG, awb_config), - C3_ISP_PARAMS_BLOCK_INFO(AE_CONFIG, ae_config), + C3_ISP_PARAMS_BLOCK_INFO_CBK(AWB_CONFIG, awb_config, + &c3_isp_params_awb_config_validate), + C3_ISP_PARAMS_BLOCK_INFO_CBK(AE_CONFIG, ae_config, + &c3_isp_params_ae_config_validate), C3_ISP_PARAMS_BLOCK_INFO(AF_CONFIG, af_config), C3_ISP_PARAMS_BLOCK_INFO(PST_GAMMA, pst_gamma), C3_ISP_PARAMS_BLOCK_INFO(CCM, ccm), -- 2.54.0