From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D7E018FDDE for ; Fri, 26 Jun 2026 14:37:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782484664; cv=none; b=hUdDhatgajwezH6Ny729OehnhqMfopCmbfCEP7VhxT8e8S/DQrCmIq9PoOQpt1eTfqWY9/SpoewzTOmdu8cxm23gD5MdJjM/Tq9z5tynCC9owMiUtYTmvOZG6ctP//q1Pf9wHD9l/+mOyi7EKHDHsoD3SlrSf6u99CGlMumFF2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782484664; c=relaxed/simple; bh=hdcucjKaXo99zIVLHqBl+pduwyuwZ1Ak8BLvT8zqF9k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=OH/U2vGPL0MNCFirWEXzHM4Vzma8hyZkxUt186Am9F0R1JzRgiFIdYskFu3gfrscKyhQPb3rJ1GcSvthcjfEt3c+lnd2H0wi3jlgceQSXZF5QCow4fWz/N3l0B6FpyBq0GjoGtl/FXXFSwTDqOgqfzz2eefVwY2uJI9qwJ/I4kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IQQRCcKh; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IQQRCcKh" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2c7ebfbf2d4so5889515ad.2 for ; Fri, 26 Jun 2026 07:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782484662; x=1783089462; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=f2zIaBu5egU2fz0I8v1SkUtexRvT+jWXEOgQa3ZIiEg=; b=IQQRCcKhOs2pceI5MqpPksuLsI5eQYti1QZSTUeQ9hBtplCpVlBDrWh1jivn/KCfwK +cf1llJq7o8O3EgHFHUayoqO+O5nTdvA8yaC/TFslNUUCUw2f13jlQGBuKlQcAi8C/3o cxqA/PtV3wxqBZbXqV5RHUXJ/SEvu1TR6WOu0XO0X7DFQIpBvN4GUNOCD4V0JXghlmmy 5epmxYnRUU5Jc+l1bKcuhSRrmen2GSdswjBMpD5sClquui3iat97PCj3ealst25iaTFM d4BOqXiXZ5L14L4LNOoqP/QswkL6fLvicQ7CNKQrK1QuqPdsIRQEPnbZGodNQ7HJHx4z pDmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782484662; x=1783089462; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f2zIaBu5egU2fz0I8v1SkUtexRvT+jWXEOgQa3ZIiEg=; b=PFwN5qIQzy/v22SyBtqnqlr6eadukWC4iw0DTgmOMABAmy9r60lMIrNSOlqzhnlgwI 4u5DRE7UBOixrdIv7VqIVfoF3bNC/e9zZwvpFR7J3r+dRz/8du8rZIe7MqfZ8kl6Sw/2 MZW+goItA2m96ng/2Sn1SNDzumVrZCGt9A1OMC7+0Ip5SkweRBocf7RVostZOAUMFml1 ZF7cs2Y55xR0nTrDhxnXv60lRwGXZ5FKHz56IwRGkf9rqIcOK0U1EBm/nhXPySZNs5J9 D1qJXwIHswOhngJvT8rLv7auY4AxcjSYEmGHv3x3m+ZEFn0WL7vVLE+dXdBXTsObNX3S wg5g== X-Forwarded-Encrypted: i=1; AHgh+RrRr+3wAYJqQU2OEppSvCSo3UMrNlAmL+Tx01KZ1wjLZ0TffqS1b3GQ665+gzNQ6b1cHGfug6SQnMZhK9Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7IuqsfwZmBV2r5DkoTwX3D7WgjfM5HI+Kuf17GijG24zNJ7Mh n3U0pyxty2DMy62AzoWd+hG42r5C+LGsfWuN5yTZs+5xr5XgMqL7I3SJ X-Gm-Gg: AfdE7ckXMz0P7aPdeakkY0YsiZgWpodhEdd2ivurMTmp+wXK4zwXWHh+gjuUqIP4Fbz NDMqHt2HaTuPXhhJQoxlRCPBKrxBZLVh2nr5kXPJvcBeNlt2KVPWoAi1Z4lm8k3mEt1p9W+5xYs R8K+BgoGDjHQn+k3NXJMpC1cicBqjQM/PbFsgbJagZg42acl+cspjjCLuOtgtfPt5fbOV/UNrzM PRXYFW8jtGUM4+j4t4mAzdMgK2lxGiQYxC0KDalhlOkookq0ZG0+cZ/bqfLYU5kWZ++qhxpxdx9 FPNQBTu4dv42gvErg+HQpU4jWskc0jVal5Rxdriy54hSZBa5+7TZb+4hmDv8Hm+kkMfWkYTceXB ikmT93KVham36ibPxRhOlyeFW3EEsJ+EGJ++24dRZwspr2D6G34ZbaGZ1pnLOYzr6+/bJ75oB+a FTpsvoi2rTF96J3/RhnUod+sZq0bsK+YBKxeisLpxFet7Lu5kuWSmcb+PIfLd6EQm3evxMbgPJY vTIp0c= X-Received: by 2002:a17:903:285:b0:2c9:97a7:f541 with SMTP id d9443c01a7336-2c997a7f613mr2239595ad.39.1782484661576; Fri, 26 Jun 2026 07:37:41 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.74]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f5ac8e3csm40667925ad.10.2026.06.26.07.37.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2026 07:37:41 -0700 (PDT) From: Felix Gu Date: Fri, 26 Jun 2026 22:37:35 +0800 Subject: [PATCH] soc: imx8m: fix clock reference leak in imx8m_soc_prepare() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260626-soc-imx8m-v1-1-62657e3376dc@gmail.com> X-B4-Tracking: v=1; b=H4sIAK6OPmoC/yXM3wpAMBSA8VfRubaaWWu8ilwwB0f50w5aybsbL n/19V3A6AkZyuQCjycxrUtElibgxmYZUFAXDUoqI40yglcnaA52FkVu0RaZ1FJriP3msafwvar 6Nx/thG5/B3DfD4YteVJtAAAA X-Change-ID: 20260626-soc-imx8m-938e89104044 To: Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Marco Felsch , Peng Fan , Shawn Guo Cc: imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782484658; l=1048; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=hdcucjKaXo99zIVLHqBl+pduwyuwZ1Ak8BLvT8zqF9k=; b=/JiTuhoNoGmbRMn7H8kiMgtE+3nCGhdX9twaHyi5h+Z4MushNSaK6p8SzSXEY0Are5Ox6mJEb yEATvpMTHfiDWPE6jnnXiBWPtLkIHVRX/wN3H9iNLUv5+gAKIy4IEow X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When clk_prepare_enable() fails, the error path does not release the clock reference obtained by of_clk_get_by_name(). Add clk_put() to the error path before iounmap(). Fixes: 390c01073f5d ("soc: imx8m: Cleanup with adding imx8m_soc_[un]prepare") Signed-off-by: Felix Gu --- drivers/soc/imx/soc-imx8m.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c index fc080e56f50d..de19972435f9 100644 --- a/drivers/soc/imx/soc-imx8m.c +++ b/drivers/soc/imx/soc-imx8m.c @@ -150,10 +150,12 @@ static int imx8m_soc_prepare(struct platform_device *pdev, const char *ocotp_com ret = clk_prepare_enable(drvdata->clk); if (ret) - goto err_clk; + goto put_clk; return 0; +put_clk: + clk_put(drvdata->clk); err_clk: iounmap(drvdata->ocotp_base); return ret; --- base-commit: 30ffa8de54e5cc80d93fd211ca134d1764a7011f change-id: 20260626-soc-imx8m-938e89104044 Best regards, -- Felix Gu