From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C8122EC54A for ; Fri, 26 Jun 2026 03:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782445075; cv=none; b=FspcpnZPRlEEP69pH/CVS73MFpFoMQu0mlg5cEFyWhuRg1HDQBnkBCZsN6X1k8D3msp5yqPzRJeOVCGnClb/htrDfDR3A0vrsifyiLwnu6pEauxXuEgHgm0JEgqIIVFfbuqfVrZ3fni9D6Fzailv2IuULQzqdyuQxXJlohJNUEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782445075; c=relaxed/simple; bh=oxH0iot1YAhCRMOTzj+q7wyWmFFto4Ym3ti53ZOvCm0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KjuEGB2crjua1M5AhrBd/XG3uaLqIlhl5yqk655ILcQuko7aEFYIDiD+eX8hsBXMBUnNnhyYKwUYINZvLCZr9MhTrbBVkFirSH8tfo8JnxywHbaswWEP9+vk6kMRvIjMzDtGmSWuqfijnEqy4GA0V5+97+grULzYlnAlMlJdDcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WvwAkH1s; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WvwAkH1s" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-91ae31bbaa9so52235885a.1 for ; Thu, 25 Jun 2026 20:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782445072; x=1783049872; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DXRbQdsGUO+OaF2qH7v2uVNyKE0DcMPVyC/pru11U+0=; b=WvwAkH1sumNREMgObLo8Kq9Klc6a378+aSdKyC4PxL0I3qawGL/oxXrTH1cYD3oNvt cxZiOJ5s+rIEBBwi8tVCNW6864Y804T4CXa1Fzw181gYWZShPjWRHJ0PsbPIi+bEH2MY FiR91fQRW/vRLyu4qRmrrt0ysVaM4KDgdxSbEn/rxygzEnnue2Qt/ARWSg/MrI414YUx I2T2IZQsfb5FLYpFZZyqp+hbeLZTPIBKij+C/eqZV1HHzBvEtKIcn0FVdA1ef0UHCAdT pyRUB2rT0Ru3CTJttsP+M0HahkItCjJor6dIeZbgyPr7JcKMchVGG2CB3fITnrX1Ot5G UBnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782445072; x=1783049872; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DXRbQdsGUO+OaF2qH7v2uVNyKE0DcMPVyC/pru11U+0=; b=IA+vdypLkdUOBe8dTbocd29Ndkq3J06Wrs0UW+lNQUkXOGJUhF40FWZujr1uMEP2bt 3WP2J32K1uFjbn7rA8/BfYlC6D8jIzHFtCtkdualnREE5DuaSvj4GmZQYQTYjH/exivK WO/iOR5vU3b0APEYirnnODuEVKy0enDuZZ2QtqUu+zXmhKbPfVZ/S6VHBsfV20QPNCmB IE6SU5PVSyx42oyQxiLRIYCj9mYTaqgYJxAPtG62EsC3N39mXPVDvv7lQhpr0D0/wZU0 YmzXybhFE28lTeQ5Kb7NHFTNO4ZHxMqVIX2i67+5wFIoDR8JuRywybb0kyR4BKRQvB+B ZJPg== X-Forwarded-Encrypted: i=1; AFNElJ+a2ypoU7pFqbNlmBZZ4dTa9JUJ0XtolTy2daVF15EwXXslwtC7E7Pb0ITnOkyunBCzG18DpF0HXSLpDT0=@vger.kernel.org X-Gm-Message-State: AOJu0YyH76bzTrmXbiCIoqv448gGcjWeX5CmhQMQm4U3AlJNgd50ldEC SSQbJouZdriQCiqSGXmZZeZXjWEVC4hTxCsxGvR/pw98aon5IE0JZdkN X-Gm-Gg: AfdE7ck8E6HZwnEsnTqT44rjzwZQq6sC5XrixkNoeILTF71diHsSUaT83j7KmloFyYW QS34IJRgcPqBljbD1mHbH2CIlWCM0sVXCHvNkYGAtSU6g64svuB97THREpOiGiG6ng3h1pNW1TH VP9N5utgelheqqCzofNY9GKuK+Fzvbg1u3p4AazNgXusMsqK/xa3OToaBAoY9w9gfyhqlGDWUDM GQKLw3odB8ybPp+wyubya3+bB/g6ZwhVje8YcqWtJh4RjRy/XnklnVGcsOdv7lTIZ3QsJFX/G4K sw87pEE9MEK2Z+iDV5kG7hneXqDeQcRwhB6Ht+tJPP6vpcc01OGMCWj4tdoFYSjsfAvKbA8Fqls rXS1aCfUH015rZ+PHyqku3bTiniVRS/9EWgQwba3SDAFKVw35veTAi1yElktq+FyJGB+SgYHd6b 1H//evo8hx74cAUmYBdO10zSNlIEsqVued3Su1ifGY X-Received: by 2002:a05:620a:271a:b0:923:3062:9046 with SMTP id af79cd13be357-9293abaeb24mr803214385a.23.1782445071924; Thu, 25 Jun 2026 20:37:51 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-925fe040904sm1032082985a.20.2026.06.25.20.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 20:37:51 -0700 (PDT) From: Yuho Choi To: Marc Zyngier , Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v2] irqchip/gic-v3-its: Fix OF node reference leak Date: Thu, 25 Jun 2026 23:37:47 -0400 Message-ID: <20260626033747.1515585-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_get_cpu_node() returns a referenced device node. In its_cpu_init_collection(), the Cavium 23144 workaround only uses the node to compare the CPU NUMA node, but the reference is never dropped. Use the device_node cleanup helper for the CPU node reference so it is released when leaving the workaround block, including the NUMA mismatch return path. Fixes: fbf8f40e1658 ("irqchip/gicv3-its: numa: Enable workaround for Cavium thunderx erratum 23144") Signed-off-by: Yuho Choi --- - Use __free(device_node) for the CPU node reference. - Correct the Fixes tag to fbf8f40e1658. drivers/irqchip/irq-gic-v3-its.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index b57d81ad33a0..63942cf1dbe3 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3290,9 +3290,9 @@ static void its_cpu_init_collection(struct its_node *its) /* avoid cross node collections and its mapping */ if (its->flags & ITS_FLAGS_WORKAROUND_CAVIUM_23144) { - struct device_node *cpu_node; + struct device_node *cpu_node __free(device_node) = + of_get_cpu_node(cpu, NULL); - cpu_node = of_get_cpu_node(cpu, NULL); if (its->numa_node != NUMA_NO_NODE && its->numa_node != of_node_to_nid(cpu_node)) return; -- 2.43.0