From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF9C73A6B81 for ; Fri, 26 Jun 2026 05:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451101; cv=none; b=d08UoxdN2Tai8f8vLW/AF1H72Ks6cX2BQvbLE6Iv15NrHWS/D0lEhals8ipjOeyysUKlEAzyJZa7qGhl0HtP795nb5Ud5jh7yovE8ptLMzJBMVJSJmzm3XuOFNY5avThbBulIsuImIo55AZyW44r+gVb/axzgyiLO0G74mlquIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451101; c=relaxed/simple; bh=S7VgKpfTgBnjIiGJp9xV7qsZ8eY/ftmXoOJ79RnATH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G+/dy7YCL8FNK4WEDqOqm0azlzcHmzSlXG77lh/yFKJSVuGYA+r8Ul5hj+wJEAjdrBXsJ6YkGs0niyQX47doH5erjt4YhMFyPySQ3QaTwxQPirRk3rdzCa6a6uhl+FEXP+Wdux8a3AzZrFMuWc9uIYgSwzIakfHQeZtyu5WVX64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wzlih0Yf; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wzlih0Yf" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-30c591fb1cbso890303eec.1 for ; Thu, 25 Jun 2026 22:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782451099; x=1783055899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cvogOYoQA8k/YjrXfsKH1k1eYaj9ZaJ63lBakDvIi20=; b=Wzlih0YfkY4ks6ybRL5TjcVX3UcJNt1EwS2sez0d++ncFEX87FezpJJuyOhW49xZn7 7/QahloI2hLel9rsR+/faD26QVTKfwadKarab53LbTBkdOhu2jPWDBvvaRn4Qc/qEntG FEHI8gvP+EQJJia1VtgtE2DZ8f/lK3x6Gxkh0C25myeZYvwhTmCMhgg1HlRZnAwlyxlr nGYR5DOlClTbs2/FQC0nA0gDKvU9aDvku0CnJbkz5oizDm3o0DIox6p5cVzsknlkCD74 HKYCgMlNhb79Qm69tarJET4CHSOD2v/Nj5mAJCOfjjb9St02KNwDV889Ev1KCFe7ul/M ElkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782451099; x=1783055899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cvogOYoQA8k/YjrXfsKH1k1eYaj9ZaJ63lBakDvIi20=; b=n1hUx2srt/1y548D/rQewpflACY9jRdEF43yzIPgvjQbQzhaEFovm5rW/M2h1giDYe Gtd0+OKPELcQiWky8F2sa5+e/2vk1kEpizXgGN9oc8txdTTo/v5fahXRARZ6FK36uSTn XtOKrNr2NLId80/wZ/3+OFmExnmr0UcFYvp7AcxsIru4FVqIwb4Tzc/3VP/UU94/FqCP 3/1VaiKlc/gnZtdef/pBbrEnenHzeIWULrFWbRNHqBZmZiALh9N1vVoa5hmssP9qD0hZ j9FsAn+K8Rpf0s962S5lH/Rxj4VULseUts4c0dKJNtmjPPfhykdT+PKEe5sFZErJTBxC YGsw== X-Forwarded-Encrypted: i=1; AHgh+RqcD9qCzo2XOxT9dLIR/2douQz4xB4R8if46TAxf+Lokd5c1DRiCsq60g8EecJuCm0EyjFznoaGnAeBlN4=@vger.kernel.org X-Gm-Message-State: AOJu0YyJZ+5up5Bf2B2/MBUkv0xvYJsiZDVCaNMDR6q0adCWGB5opJ+o DUk/UlS2rgATmU9Sw4MzqplCl6IYxUPPETD6/jnKEx5VJWLTnbBFPI1h X-Gm-Gg: AfdE7clZebenYDv8QJ8DHUJX7DfDV1a+zMJIH/5qcULVuxnTYm8OiTyVYX8MKhG1LM8 AVBIbA5zTwOTSW+xzAHReGdirZKh5W6wQMPvmIyes9oCFYsBuviEgntsPbhH/PBXB1lUVq/ievK AXyPt+LTQl8qY9DjNMlIwePNhgiBUJqm5jslfQ6jvb+9NEn5xVLA6dqQZVGnq/gUIEA6+AsB79Y d9qVMA88AsWjT9b3HhQhdUY04DnkW5+6RtOdCY9YrIxqjpb5HSetEF3aOOfMHLrUsIXVx1IqZD0 1cjaYIMWo4UogA6UbZnXC4uoFfyd5viZEg+Lx+52cUn6vLhPYa65AVRUnF264rLLZxJOEDJwJ1j 6rNFWVAoZuv4Y5TRydnek51E6v7b0nMmfTrD+gBPwpcGT2k+SLFlIa8saSX4lbsViaKd4Sh3C4g IC61jroIg3wEQbcwgKSnvaOTOA7vLZhYJAoL5mlED9MFGWtJ3ygkj52UqV99W0lPSM9z/J3T7fT cGH X-Received: by 2002:a05:7300:2321:b0:30a:e52d:fb27 with SMTP id 5a478bee46e88-30c84b84f6dmr5504142eec.11.1782451098857; Thu, 25 Jun 2026 22:18:18 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:a474:bf4a:4966:8d97]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c9e9214sm14804188eec.20.2026.06.25.22.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 22:18:18 -0700 (PDT) From: Dmitry Torokhov To: Bryam Vargas , Hans Verkuil Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/10] Input: synaptics-rmi4 - use __le16 for FIFO offset in F54 Date: Thu, 25 Jun 2026 22:17:59 -0700 Message-ID: <20260626051802.4033172-10-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog In-Reply-To: <20260626051802.4033172-1-dmitry.torokhov@gmail.com> References: <20260626051802.4033172-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of manually splitting the 16-bit offset into a 2-byte array, use __le16 and cpu_to_le16() to serialize the FIFO offset in rmi_f54_work(). This is cleaner and more portable. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f54.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c index 5d045ece3c2f..3eeb189be18b 100644 --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "rmi_driver.h" #define F54_NAME "rmi4_f54" @@ -552,7 +553,6 @@ static void rmi_f54_work(struct work_struct *work) { struct f54_data *f54 = container_of(work, struct f54_data, work.work); struct rmi_function *fn = f54->fn; - u8 fifo[2]; size_t report_size; u8 command; int error; @@ -597,12 +597,11 @@ static void rmi_f54_work(struct work_struct *work) for (size_t i = 0; i < report_size; i += F54_REPORT_DATA_SIZE) { size_t size = min_t(size_t, F54_REPORT_DATA_SIZE, report_size - i); + __le16 fifo = cpu_to_le16(i); - fifo[0] = i & 0xff; - fifo[1] = i >> 8; error = rmi_write_block(fn->rmi_dev, fn->fd.data_base_addr + F54_FIFO_OFFSET, - fifo, sizeof(fifo)); + &fifo, sizeof(fifo)); if (error) { dev_err(&fn->dev, "Failed to set fifo start offset\n"); goto out; -- 2.55.0.rc0.799.gd6f94ed593-goog