From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570AE3A59BC for ; Fri, 26 Jun 2026 05:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451099; cv=none; b=PDF8ttF7SQYhFAh7ClzRO6y6H3QgUoXZ4l+C3BUcRqzSTbKakiqLrg6U6Ec+eOJJzkMWVfrdwF/4q4YzP495ECpka8XvLLjBQ77s4Xs754BbT0VPZx31C/D412NUsraze36OHYnkHzObrZbuMvnlbkC3PHGecmm6rf+a8C1JKP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782451099; c=relaxed/simple; bh=yMXPdGDW2lfGhnHWFTL7FoN3LjO+95A3FRC+1uOxj7U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AcN2KpVbF01HspjXi1Oowbf1bZRKLAprwsT9zlLYYYPKnPX14eJM6pcz36LyICR8jgRsfhmxeGFn39RSsvNPPumHJOKZLU4Ho5x+fPh6bQ269aiY5C+iMw43hoQ58pYYgB0edDfPW9YtciejkHoMxyXPVaLFjyNUegnGOL1sSZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OIHbk1en; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OIHbk1en" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-30b6dad2382so1285113eec.0 for ; Thu, 25 Jun 2026 22:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782451097; x=1783055897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=POLQLR6buhFN05Ket/1VgymD6hL5YrZUJpiEgczNqtQ=; b=OIHbk1enKRUpLLRMH+uH/SGzWBO5qIprZcSo3VWpnhOEpojjhz8vjhsIGbHejgtPG+ ECrvjr8o4wSay/HRLVmzoff0MbTJB5FFy3X9txO5FGLzlccjq0UgnrGHcDEh92X93Peq bwrWV1dovx5aXxgxIvfXqKgaixDQfs8ghT6ge62o79W35k4l8RStamnk6Hh3FWMY3Le9 C5QeUxLhW9O8TPtgsZ1HlkJOYNIMnDqVZgTSkK9b0rTa+bfQru4rRQrMkW1OeLk/MMzy LYP4M1YlqR+wTlWFDX1C7ks/xnBJs24QpSsz2VHmZBy+qB4l5+HzTQ/gYk1cxms6eRkg BISw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782451097; x=1783055897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=POLQLR6buhFN05Ket/1VgymD6hL5YrZUJpiEgczNqtQ=; b=iT1XIgkguL5/ETFIGdBE67aLMBibZGsExGG+8hKESUxpC/Y9me9FTMvoTuwJSpdTJz z5cVqmayaRFWS3aAjoMhyCDW0GMDEoSpMlPPHCJJ9xSY5ix7U4EJYo5uKOHJhLaGWPk/ g4o4o0FyOZkrIfuqdCtf8BGQBbJDPZ3F+g+BL8/rp3jxFyOE0IBd+28QK4DpuYCf6kBf k5rgaewJ4snHNxyEH3xSV3xyYB3dlpxbQRj5ajfnb03TzqIHmmL5SF1zo1oLTaDvroOb ra2VhD0kBf7vRckiCO6AvBa2MmD+FKUy5KWv13K82rXcZh4qgR+AOCX/edTspSrL3ZbJ QinQ== X-Forwarded-Encrypted: i=1; AHgh+RpvwmQBynoHp6gXUwsuvu7u+MQFf5bjxa6k7y/J6w5dZPbslyWgaImQzmw+tyX9YCf6ceYcBt9d3yBIRaw=@vger.kernel.org X-Gm-Message-State: AOJu0YxzZpIQtZlzbcktxP9vLe5qbwQSxMrwX5bA8etnbG0A5hrBBSMQ QWKo3TnODiJZJHNHt8YA8sCWBFZv0nM+PbRJphoRru1XqESYzcUYrFcAedXDPA== X-Gm-Gg: AfdE7cnl8sZmySG/JuUr1dfkbR7nxctErpisW0Ok5oWyQY0fdogroPFrmV5gFqr8Cq8 0WnDU59+xIwgRgwyUdrTU+kBz0It2+UIKNNnGrcoJF6lXMtUhaE/S6j15o8PBZgnVj+FGoF6gSr g9VdvGigWqc19Z8K6ldHRZBeDNoOXQTGVpn+ZYOBzFMFQnWhRINlePOM5V2bInQ4C4KzdtzekiW fxme/mK7Cf9gNI6MJmRoMEDZmcbqfKSOIFoEIY+gXO2XcJxh3rKxpmtkn6kJJ3N29S7Re+DsOYu /D8fNpWPqys41ptXpSOHOrBfPvHu/+C5//gX5XC4A4KkVxAY0skRHc6ocnFfcAXo1MIvlctfLeU xSWfyPrPHBgqwvfDRPZ2F1p0tze+kAv7w4GPBPn3+EbNQUi+syBHbzSw6tIXIkQWBNiMyeOEF1K yjsm3b5m+Drn+WzoIUaGpTsMsDE/oIIj4LAdE9SP7wXVOlFxV1U9mrRiROngQyHPia4CuzSIdDL cMK X-Received: by 2002:a05:693c:2285:b0:30c:45de:8fbc with SMTP id 5a478bee46e88-30c84b64cb7mr5070108eec.9.1782451097513; Thu, 25 Jun 2026 22:18:17 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:a474:bf4a:4966:8d97]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30c7c9e9214sm14804188eec.20.2026.06.25.22.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 22:18:16 -0700 (PDT) From: Dmitry Torokhov To: Bryam Vargas , Hans Verkuil Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/10] Input: synaptics-rmi4 - change report_size to size_t in F54 Date: Thu, 25 Jun 2026 22:17:58 -0700 Message-ID: <20260626051802.4033172-9-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog In-Reply-To: <20260626051802.4033172-1-dmitry.torokhov@gmail.com> References: <20260626051802.4033172-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Change report_size from int to size_t in struct f54_data and update all its usages. This avoids signed/unsigned comparison warnings when comparing with size_t variables and matches the signature of rmi_read_block() which takes size_t for length. Also move the declaration of the loop variable 'i' into the 'for' loop header. Assisted-by: Antigravity:gemini-3.5-flash Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f54.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c index 850e1742c480..5d045ece3c2f 100644 --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -105,7 +105,7 @@ struct f54_data { enum rmi_f54_report_type report_type; u8 *report_data; size_t max_report_size; - int report_size; + size_t report_size; int report_error; bool is_busy; @@ -355,7 +355,7 @@ static void rmi_f54_buffer_queue(struct vb2_buffer *vb) } if (f54->report_size > vb2_plane_size(vb, 0)) { - dev_err(&f54->fn->dev, "Buffer too small (%lu < %d)\n", + dev_err(&f54->fn->dev, "Buffer too small (%lu < %zu)\n", vb2_plane_size(vb, 0), f54->report_size); state = VB2_BUF_STATE_ERROR; goto data_done; @@ -553,10 +553,9 @@ static void rmi_f54_work(struct work_struct *work) struct f54_data *f54 = container_of(work, struct f54_data, work.work); struct rmi_function *fn = f54->fn; u8 fifo[2]; - int report_size; + size_t report_size; u8 command; int error; - int i; mutex_lock(&f54->data_mutex); @@ -569,7 +568,7 @@ static void rmi_f54_work(struct work_struct *work) } if (report_size > f54->max_report_size) { - dev_err(&fn->dev, "Report size %d exceeds buffer size %zu\n", + dev_err(&fn->dev, "Report size %zu exceeds buffer size %zu\n", report_size, f54->max_report_size); error = -EINVAL; goto out; @@ -596,8 +595,8 @@ static void rmi_f54_work(struct work_struct *work) rmi_dbg(RMI_DEBUG_FN, &fn->dev, "Get report command completed, reading data\n"); - for (i = 0; i < report_size; i += F54_REPORT_DATA_SIZE) { - int size = min(F54_REPORT_DATA_SIZE, report_size - i); + for (size_t i = 0; i < report_size; i += F54_REPORT_DATA_SIZE) { + size_t size = min_t(size_t, F54_REPORT_DATA_SIZE, report_size - i); fifo[0] = i & 0xff; fifo[1] = i >> 8; @@ -613,7 +612,7 @@ static void rmi_f54_work(struct work_struct *work) F54_REPORT_DATA_OFFSET, f54->report_data + i, size); if (error) { - dev_err(&fn->dev, "%s: read [%d bytes] returned %d\n", + dev_err(&fn->dev, "%s: read [%zu bytes] returned %d\n", __func__, size, error); goto out; } -- 2.55.0.rc0.799.gd6f94ed593-goog