From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D30043D9020 for ; Fri, 26 Jun 2026 06:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782455632; cv=none; b=BOK38YxepGixR4eKO+3ncZr2Q/KKsk9DRiDxayU3dNyLWKv5WmmbmRiTE5j3Rvk9lYsQQolWn4i4M+MvCKYITpdEMTpop81T2nJqAYWcKkQwkwOPPDJtCHw8BmLHDqUfYtBOXJ+jEuG8zoidNjkA2fgiQU3UQ5mXBEM5RA9cazg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782455632; c=relaxed/simple; bh=A+ppS2KfetbowCTKK8GhbLBOQG+aJbbn/pveOx2ALyA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mGUPmtfIeycrduUCXhfC0DBPEhQCQ/vLB3kx6Ylld7Rc3jn0PFyEXInGRwh7HAIhMOLyG40fYW8hN7q0lYB0e/uZf3oQCkSGbenVqgACwchM8ZSF5fvw9egSv2XsTUuoLe2qQUGS6DsWoSfD2BGyoab+rfyDl0ZxE25emgIXcHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id CFBBE68B05; Fri, 26 Jun 2026 08:33:47 +0200 (CEST) Date: Fri, 26 Jun 2026 08:33:47 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, elver@google.com, gjoyce@linux.ibm.com Subject: Re: [PATCHv2 02/17] nvme: add Clang context annotations for nvme_passthru_{start|stop} Message-ID: <20260626063347.GB10731@lst.de> References: <20260614131541.2017845-1-nilay@linux.ibm.com> <20260614131541.2017845-3-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260614131541.2017845-3-nilay@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Note on the subject (also the following ones): please just say context analysis. Currently only clang implements them, but that's an implementation detail. Otherwise looks good: Reviewed-by: Christoph Hellwig