From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C1B35CBD6 for ; Fri, 26 Jun 2026 09:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782464633; cv=none; b=FuA3t+jy0wcFrZsIo5pPJ6g6V7L5Z/LPaffDKwT5h1drgWp/ZMFmcQpKE7wzbNAWORT1azFVejHlYtRPVKWvZaUu1jwZn/yW3GsuG576DIIWm3T+RFPIlqhGg1q2df3E+HyfhApYF5y+jUqyrUBpYq3TsKMxL0UEygSnUNnD6Jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782464633; c=relaxed/simple; bh=XhFvV3Pst9OQZ0KTgYAScYpo3nLbmT7aSzDFADrNCk0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EzwMDmCLnwR4RorG/lSffxgaW/Rr2P50CbjHMrCgzE9NaEFfEF/mQIFOoymW63TjOymUNtSwdXmZXV0M0FoCIUozIsJ1O/e+hrdb2/wxbb6BMJ9NdI4XBlq3BNpZv4Msc4uwcg8CdCzl+XKs050pMkMUCOK2h2VCZH3IHXZHLfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e2xFVZ7S; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e2xFVZ7S" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c81d799ef2so1300135ad.3 for ; Fri, 26 Jun 2026 02:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782464629; x=1783069429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iknM7cswknxj4qdDnOVnIMU9meZwE3Gb+QzXsxgdJD4=; b=e2xFVZ7SjT2pUOlz32GWGFfm90J1BKUvyYRqjFB4gjsBrRNt/QEOYHssvC+pFBmFK6 FUSl70iSiWDUeXhOKIZVX8W/potHzFySkirKiqsewN9D8yfmV0qzR6MxF5CxxcVj9Eda S36YyZ1MU5DgXz1guu7WdDc5NyVqIs0kstddbbz3Gaf7VqW0c5YXgi42Sh/J6wdlimoY zf1LWBVoPWnp025mV8PimuBhZHVL7WQUZEBVCTs1Hx9iRiAMDHBKodW7XfFL4+GsnF6h aOsXtAOrkpyJFbISzCItbqBn+7SAKUC61+U10ucj2jyNRWqRli+oGIF/+9YC5Nlub2W0 HA0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782464629; x=1783069429; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iknM7cswknxj4qdDnOVnIMU9meZwE3Gb+QzXsxgdJD4=; b=DolKcWSq/cCqOG4r8pC1BhxdKZ1KWlThbp2YhyPLA71ZPGX+ZbxS7fqfolOzSeH/qm J+8BbuXBtx5zsLgVJEPDaU0g9i+8SOBJgThdsjvuBwGg4CV/OiUkmSMfF7do034YD7t0 XASHq8z6G/N9wyPS0eDTNluxtvmx8a+nAEOF1R0P9UzNyeMKFVCbvOO0q1Qty9tJflZ7 y+1P7hXi4Pvjg0zaZJO3KhupjTV1j/Yv8ObKCyfl64Pp12/Q9mzIlkjxK+2rb3Ibd6sj 6jPGV0owV+hXqE0Fw3i1txt8/U1NM4DEyPk1nITxGeTupo+9GxPsGaXBv1l85PaO0SdE UJYg== X-Forwarded-Encrypted: i=1; AHgh+RoR+uZBE0Gf/fWnnGvse4Gg+oi7pZWl1x6WSCQdH5ZxMY7KPkIUCXpoe64coyFObDDi/iSYH5PFr/NgON0=@vger.kernel.org X-Gm-Message-State: AOJu0YyMtMuL45rydNxXvTW9m4xALo5qhoDSqU2ybPse41n0n4XmBO6w 6dX65/DHFbxLmu10tOSrmvXslzxucHV1K5BDwD8sC79lNYzqLYfE328= X-Gm-Gg: AfdE7cmLR6iUyIQA6iyul4d0h50WX9gOeuE4KPRfOYg2iUhkKBg0xuB595+EMf/SI+J 1MrBbUVg4VryTelZ2v4PXq1wZZboCEWZS8VL/Ioc1cuoSWlWvl1dVkJH6AGnvOCkwaF5ezsYSVW ATRH2wNN49uiywU1eeSyFr5wD2GKEMUnXM2LxcHPSf8JGMrn+4CPmBX4e6vpKMp4n/AdASj9pwx QF2dZJ4q7n+myRY9wDhFiYx4L4MNYXxZl0etzfFPfd7Ouw6DxR0PvHh5DWwHJjm4qdKwslhSMqw lXYAk2iCp3uAPP00VodPGkrJ8L+E942ACfILbHXojCVXbEfSffd1s9YUypguoAEOBub6vlOa30t b/O+/Rgut/GYg1hDngf02RtDAB0r6CplwJaiDo2gfSlIanguFi54j7MU+CN9BIqkCTROzHU0MKV fHLfChAKRezZlVrGAIxRU9aRKJR4nwohggkQjNemxTw4ZaoEcTXM5/gpq7c4xaZ/m1 X-Received: by 2002:a17:903:40ce:b0:2c7:e2bc:6705 with SMTP id d9443c01a7336-2c7fc9c1861mr61671745ad.23.1782464629059; Fri, 26 Jun 2026 02:03:49 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f6509ca0sm35075495ad.81.2026.06.26.02.03.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 26 Jun 2026 02:03:48 -0700 (PDT) From: Myeonghun Pak To: Deepak Saxena Cc: Olivia Mackall , Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] hwrng: omap: disable runtime PM on resume failure Date: Fri, 26 Jun 2026 18:02:13 +0900 Message-ID: <20260626090302.42134-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit omap_rng_probe() enables runtime PM before calling pm_runtime_resume_and_get(). If the resume call fails, the error path currently jumps to err_ioremap and returns without disabling runtime PM again. Add a runtime-PM-only error label and route the resume failure through it. The label is placed after the runtime PM usage-count unwind, so later probe failures keep using the existing pm_runtime_put_sync() path while this early failure only disables the runtime PM state that was already enabled. Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/char/hw_random/omap-rng.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c index 5e8b50f15dc3..44b8bb4a24a8 100644 --- a/drivers/char/hw_random/omap-rng.c +++ b/drivers/char/hw_random/omap-rng.c @@ -455,7 +455,7 @@ static int omap_rng_probe(struct platform_device *pdev) ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { dev_err(&pdev->dev, "Failed to runtime_get device: %d\n", ret); - goto err_ioremap; + goto err_pm_disable; } priv->clk = devm_clk_get(&pdev->dev, NULL); @@ -499,6 +499,7 @@ err_register: err_register: priv->base = NULL; pm_runtime_put_sync(&pdev->dev); +err_pm_disable: pm_runtime_disable(&pdev->dev); clk_disable_unprepare(priv->clk_reg); -- 2.47.1